[GitHub] [flink] Myasuka commented on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side

2019-06-28 Thread GitBox
Myasuka commented on issue #7942: [FLINK-11696][checkpoint] Avoid to send mkdir requests to DFS from task side URL: https://github.com/apache/flink/pull/7942#issuecomment-506924134 Build failed due to [FLINK-12164](https://issues.apache.org/jira/browse/FLINK-12164), re-trigger again. ---

[jira] [Created] (FLINK-13030) add more test case for blink planner

2019-06-28 Thread godfrey he (JIRA)
godfrey he created FLINK-13030: -- Summary: add more test case for blink planner Key: FLINK-13030 URL: https://issues.apache.org/jira/browse/FLINK-13030 Project: Flink Issue Type: Improvement

[jira] [Reopened] (FLINK-12164) JobMasterTest.testJobFailureWhenTaskExecutorHeartbeatTimeout is unstable

2019-06-28 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang reopened FLINK-12164: -- > JobMasterTest.testJobFailureWhenTaskExecutorHeartbeatTimeout is unstable > -

[jira] [Commented] (FLINK-12164) JobMasterTest.testJobFailureWhenTaskExecutorHeartbeatTimeout is unstable

2019-06-28 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875361#comment-16875361 ] Yun Tang commented on FLINK-12164: -- This problem happened again, here is the instance:

[GitHub] [flink] Myasuka commented on issue #8909: [FLINK-13004][table-runtime-blink] Correct the logic of needToCleanupState in KeyedProcessFunctionWithCleanupState

2019-06-28 Thread GitBox
Myasuka commented on issue #8909: [FLINK-13004][table-runtime-blink] Correct the logic of needToCleanupState in KeyedProcessFunctionWithCleanupState URL: https://github.com/apache/flink/pull/8909#issuecomment-506920344 @wuchong Thanks for your review, rebase with latest code to fix build er

[GitHub] [flink] xuefuz commented on a change in pull request #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service

2019-06-28 Thread GitBox
xuefuz commented on a change in pull request #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service URL: https://github.com/apache/flink/pull/8889#discussion_r298778900 ## File path: flink-connectors/flink-connect

[jira] [Updated] (FLINK-13021) unify catalog partition implementations

2019-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13021: --- Labels: pull-request-available (was: ) > unify catalog partition implementations >

[GitHub] [flink] flinkbot commented on issue #8926: [FLINK-13021][table][hive] unify catalog partition implementations

2019-06-28 Thread GitBox
flinkbot commented on issue #8926: [FLINK-13021][table][hive] unify catalog partition implementations URL: https://github.com/apache/flink/pull/8926#issuecomment-506901123 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review y

[GitHub] [flink] bowenli86 opened a new pull request #8926: [FLINK-13021][table][hive] unify catalog partition implementations

2019-06-28 Thread GitBox
bowenli86 opened a new pull request #8926: [FLINK-13021][table][hive] unify catalog partition implementations URL: https://github.com/apache/flink/pull/8926 ## What is the purpose of the change This PR unifies catalog partition implementations. ## Brief change log - Uni

[GitHub] [flink] xuefuz commented on issue #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service

2019-06-28 Thread GitBox
xuefuz commented on issue #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service URL: https://github.com/apache/flink/pull/8889#issuecomment-506900050 Thanks for the update. Looking at the required libraries, I'm wonderin

[GitHub] [flink] bowenli86 commented on a change in pull request #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service

2019-06-28 Thread GitBox
bowenli86 commented on a change in pull request #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service URL: https://github.com/apache/flink/pull/8889#discussion_r298769864 ## File path: flink-connectors/flink-conn

[GitHub] [flink] xuefuz commented on a change in pull request #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service

2019-06-28 Thread GitBox
xuefuz commented on a change in pull request #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service URL: https://github.com/apache/flink/pull/8889#discussion_r298768463 ## File path: flink-connectors/flink-connect

[GitHub] [flink] bowenli86 commented on issue #8919: [FLINK-13022][table][hive] unify catalog function implementations

2019-06-28 Thread GitBox
bowenli86 commented on issue #8919: [FLINK-13022][table][hive] unify catalog function implementations URL: https://github.com/apache/flink/pull/8919#issuecomment-506892579 cc @xuefuz @lirui-apache @zjuwangg This is an automa

[GitHub] [flink] bowenli86 removed a comment on issue #8919: [FLINK-13022][table][hive] unify catalog function implementations

2019-06-28 Thread GitBox
bowenli86 removed a comment on issue #8919: [FLINK-13022][table][hive] unify catalog function implementations URL: https://github.com/apache/flink/pull/8919#issuecomment-506892579 cc @xuefuz @lirui-apache @zjuwangg This is a

[GitHub] [flink] bowenli86 commented on issue #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service

2019-06-28 Thread GitBox
bowenli86 commented on issue #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service URL: https://github.com/apache/flink/pull/8889#issuecomment-506859928 @xuefuz after considering it carefully, I decided to make them as `

[GitHub] [flink] bowenli86 commented on issue #8904: [FLINK-13005][hive] HiveCatalog should not add 'flink.is_generic' key for Hive table

2019-06-28 Thread GitBox
bowenli86 commented on issue #8904: [FLINK-13005][hive] HiveCatalog should not add 'flink.is_generic' key for Hive table URL: https://github.com/apache/flink/pull/8904#issuecomment-506834286 @xuefuz I've updated the PR with new design as we discussed yesterday. Can you take another look?

[GitHub] [flink] bowenli86 commented on issue #8800: [FLINK-12627][doc][sql client][hive] Document how to configure and use catalogs in SQL CLI

2019-06-28 Thread GitBox
bowenli86 commented on issue #8800: [FLINK-12627][doc][sql client][hive] Document how to configure and use catalogs in SQL CLI URL: https://github.com/apache/flink/pull/8800#issuecomment-506827758 cc @xuefuz @wuchong @lirui-apache @zjuwangg

[GitHub] [flink] xuefuz commented on issue #8921: [FLINK-13023][hive] Generate HiveTableSource from from a Hive table

2019-06-28 Thread GitBox
xuefuz commented on issue #8921: [FLINK-13023][hive] Generate HiveTableSource from from a Hive table URL: https://github.com/apache/flink/pull/8921#issuecomment-506804032 Thanks for the review. Not sure it was due to the inclusion of #8890, but I rebased to master to retest. -

[jira] [Updated] (FLINK-12989) Generate HiveTableSink from from a Hive table

2019-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12989: --- Labels: pull-request-available (was: ) > Generate HiveTableSink from from a Hive table > --

[GitHub] [flink] asfgit closed pull request #8890: [FLINK-12989][hive] Generate HiveTableSink from from a Hive table

2019-06-28 Thread GitBox
asfgit closed pull request #8890: [FLINK-12989][hive] Generate HiveTableSink from from a Hive table URL: https://github.com/apache/flink/pull/8890 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [flink] ifndef-SleePy commented on issue #8870: [FLINK-12974][checkstyle] Bump checkstyle to 8.14

2019-06-28 Thread GitBox
ifndef-SleePy commented on issue #8870: [FLINK-12974][checkstyle] Bump checkstyle to 8.14 URL: https://github.com/apache/flink/pull/8870#issuecomment-506799770 To @hmcl , I wish I could. But I have no authorization to merge your PR since I'm not a committer of Flink project. I would sugges

[jira] [Closed] (FLINK-12989) Generate HiveTableSink from from a Hive table

2019-06-28 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12989. Resolution: Fixed merged in 1.9.0: f1721293b0701d584d42bd68671181e332d2ad04 > Generate HiveTableSink from

[jira] [Assigned] (FLINK-13027) StreamingFileSink bulk-encoded writer supports file rolling upon customized events

2019-06-28 Thread Ying Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ying Xu reassigned FLINK-13027: --- Assignee: (was: Ying Xu) > StreamingFileSink bulk-encoded writer supports file rolling upon cus

[jira] [Assigned] (FLINK-13027) StreamingFileSink bulk-encoded writer supports file rolling upon customized events

2019-06-28 Thread Ying Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ying Xu reassigned FLINK-13027: --- Assignee: Ying Xu > StreamingFileSink bulk-encoded writer supports file rolling upon customized >

[GitHub] [flink] bowenli86 commented on issue #8890: [FLINK-12989][hive] Generate HiveTableSink from from a Hive table

2019-06-28 Thread GitBox
bowenli86 commented on issue #8890: [FLINK-12989][hive] Generate HiveTableSink from from a Hive table URL: https://github.com/apache/flink/pull/8890#issuecomment-506793531 Merging This is an automated message from the Apache

[GitHub] [flink] bowenli86 commented on issue #8921: [FLINK-13023][hive] Generate HiveTableSource from from a Hive table

2019-06-28 Thread GitBox
bowenli86 commented on issue #8921: [FLINK-13023][hive] Generate HiveTableSource from from a Hive table URL: https://github.com/apache/flink/pull/8921#issuecomment-506793351 There's a compile failure in flink-table-common. I don't think that's because of this PR, thus I restarted the build

[GitHub] [flink] Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-06-28 Thread GitBox
Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-506787729 @rmetzger it took a while for travis to run, but it just succeeded

[GitHub] [flink] zhijiangW commented on issue #8880: [FLINK-12986] [network] Fix instability of BoundedBlockingSubpartition under memory pressure.

2019-06-28 Thread GitBox
zhijiangW commented on issue #8880: [FLINK-12986] [network] Fix instability of BoundedBlockingSubpartition under memory pressure. URL: https://github.com/apache/flink/pull/8880#issuecomment-506758658 No other concerns on my side atm. LGTM! -

[GitHub] [flink] asfgit closed pull request #8901: [FLINK-13003][table-planner-blink] Support Temporal TableFunction Join in blink planner

2019-06-28 Thread GitBox
asfgit closed pull request #8901: [FLINK-13003][table-planner-blink] Support Temporal TableFunction Join in blink planner URL: https://github.com/apache/flink/pull/8901 This is an automated message from the Apache Git Servic

[jira] [Closed] (FLINK-13003) Support Temporal TableFunction Join in processing time and event time

2019-06-28 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-13003. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in 1.9.0: 4b7ca247431e727ac0533cf767d43615bbaf07c0 > Su

[GitHub] [flink] asfgit closed pull request #8757: [FLINK-12850][core] Introduce TypeInfo for LocalDate/LocalTime/LocalDateTime

2019-06-28 Thread GitBox
asfgit closed pull request #8757: [FLINK-12850][core] Introduce TypeInfo for LocalDate/LocalTime/LocalDateTime URL: https://github.com/apache/flink/pull/8757 This is an automated message from the Apache Git Service. To respo

[jira] [Closed] (FLINK-12850) Introduce TypeInfo for LocalDate/LocalTime/LocalDateTime

2019-06-28 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-12850. --- Resolution: Fixed Fix Version/s: 1.9.0 Release Note: Support LocalDate & LocalTime & LocalDataTim

[jira] [Closed] (FLINK-12592) StreamTableEnvironment object has no attribute connect

2019-06-28 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-12592. --- Resolution: Fixed Fix Version/s: 1.9.0 This problem has disappeared, So close this JIRA > St

[GitHub] [flink] asfgit closed pull request #8910: [hotfix][python] Aligns with Java Table API by removing methods exec_env and query_config

2019-06-28 Thread GitBox
asfgit closed pull request #8910: [hotfix][python] Aligns with Java Table API by removing methods exec_env and query_config URL: https://github.com/apache/flink/pull/8910 This is an automated message from the Apache Git Serv

[GitHub] [flink] flinkbot edited a comment on issue #8910: [hotfix][python] Aligns with Java Table API by removing methods exec_env and query_config

2019-06-28 Thread GitBox
flinkbot edited a comment on issue #8910: [hotfix][python] Aligns with Java Table API by removing methods exec_env and query_config URL: https://github.com/apache/flink/pull/8910#issuecomment-506250830 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I hel

[GitHub] [flink] sunjincheng121 commented on issue #8910: [hotfix][python] Aligns with Java Table API by removing methods exec_env and query_config

2019-06-28 Thread GitBox
sunjincheng121 commented on issue #8910: [hotfix][python] Aligns with Java Table API by removing methods exec_env and query_config URL: https://github.com/apache/flink/pull/8910#issuecomment-506706349 Thanks for the update @dianfu +1 to merged. @flinkbot approve all

[GitHub] [flink] wenhuitang commented on a change in pull request #8711: [FLINK-12817][docs]Correct the import in Processing function example.

2019-06-28 Thread GitBox
wenhuitang commented on a change in pull request #8711: [FLINK-12817][docs]Correct the import in Processing function example. URL: https://github.com/apache/flink/pull/8711#discussion_r298561043 ## File path: docs/dev/stream/operators/process_function.md ## @@ -97,9 +97,7

[GitHub] [flink] StephanEwen commented on issue #8880: [FLINK-12986] [network] Fix instability of BoundedBlockingSubpartition under memory pressure.

2019-06-28 Thread GitBox
StephanEwen commented on issue #8880: [FLINK-12986] [network] Fix instability of BoundedBlockingSubpartition under memory pressure. URL: https://github.com/apache/flink/pull/8880#issuecomment-506702770 @zhijiangW and @wsry I would merge this now unless you have further comments I should ad

[jira] [Updated] (FLINK-9036) Add default value via suppliers

2019-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9036: -- Labels: pull-request-available (was: ) > Add default value via suppliers > ---

[GitHub] [flink] StephanEwen closed pull request #5735: [FLINK-9036] [core] Add default values to State Descriptors via suppliers

2019-06-28 Thread GitBox
StephanEwen closed pull request #5735: [FLINK-9036] [core] Add default values to State Descriptors via suppliers URL: https://github.com/apache/flink/pull/5735 This is an automated message from the Apache Git Service. To re

[GitHub] [flink] zhijiangW commented on issue #8924: [hotfix][docs] Update the generated configuration docs for previous changes

2019-06-28 Thread GitBox
zhijiangW commented on issue #8924: [hotfix][docs] Update the generated configuration docs for previous changes URL: https://github.com/apache/flink/pull/8924#issuecomment-506698607 Thanks for the review @zentol ! I have addressed the above comments.

[GitHub] [flink] sunjincheng121 edited a comment on issue #8910: [hotfix][python] Aligns with Java Table API by removing methods exec_env and query_config

2019-06-28 Thread GitBox
sunjincheng121 edited a comment on issue #8910: [hotfix][python] Aligns with Java Table API by removing methods exec_env and query_config URL: https://github.com/apache/flink/pull/8910#issuecomment-506690440 Hi, I think we also need to update the `shell.py`, the test fails in `shell.py`.

[GitHub] [flink] zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298552634 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongr

[GitHub] [flink] dianfu commented on issue #8910: [hotfix][python] Aligns with Java Table API by removing methods exec_env and query_config

2019-06-28 Thread GitBox
dianfu commented on issue #8910: [hotfix][python] Aligns with Java Table API by removing methods exec_env and query_config URL: https://github.com/apache/flink/pull/8910#issuecomment-506697353 @sunjincheng121 Thanks a lot for the review. Updated the PR.

[GitHub] [flink] zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298552634 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongr

[GitHub] [flink] zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298552634 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongr

[GitHub] [flink] flinkbot commented on issue #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers

2019-06-28 Thread GitBox
flinkbot commented on issue #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers URL: https://github.com/apache/flink/pull/8925#issuecomment-506695220 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Updated] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12852: --- Labels: pull-request-available (was: ) > Deadlock occurs when requiring exclusive buffer fo

[GitHub] [flink] gaoyunhaii opened a new pull request #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers

2019-06-28 Thread GitBox
gaoyunhaii opened a new pull request #8925: [FLINK-12852][network] Fix the deadlock occured when requesting exclusive buffers URL: https://github.com/apache/flink/pull/8925 ## What is the purpose of the change This pull request tries to fix the deadlock problem during requesting exc

[GitHub] [flink] asfgit closed pull request #8850: [FLINK-12954] Supports create(drop) view grammar for sql parser

2019-06-28 Thread GitBox
asfgit closed pull request #8850: [FLINK-12954] Supports create(drop) view grammar for sql parser URL: https://github.com/apache/flink/pull/8850 This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Closed] (FLINK-12954) Supports create(drop) view grammar for sql parser

2019-06-28 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-12954. --- Resolution: Fixed Fixed in 1.9.0: 71570bc9a5dc549a34b020981e5cf87c479658e9 > Supports create(drop) view gra

[GitHub] [flink] sunjincheng121 commented on issue #8910: [hotfix][python] Aligns with Java Table API by removing methods exec_env and query_config

2019-06-28 Thread GitBox
sunjincheng121 commented on issue #8910: [hotfix][python] Aligns with Java Table API by removing methods exec_env and query_config URL: https://github.com/apache/flink/pull/8910#issuecomment-506690440 Hi, I think we also need to update the `shell.py`, What do you think? ---

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298543321 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java ## @@

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298518652 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerImp

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298500217 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerImp

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298494696 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerImp

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298537362 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java #

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298524076 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerImp

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298524932 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTracker.ja

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298527316 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTracker.ja

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298538571 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerImp

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298539553 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.jav

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298493297 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerFac

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298534681 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerFac

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298495055 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerImp

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298493519 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerFac

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298509021 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java #

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298540751 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java #

[GitHub] [flink] azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-28 Thread GitBox
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298504283 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerImp

[GitHub] [flink] pnowojski commented on a change in pull request #8811: [FLINK-12777][network] Support CheckpointBarrierHandler in StreamTwoInputSelectableProcessor

2019-06-28 Thread GitBox
pnowojski commented on a change in pull request #8811: [FLINK-12777][network] Support CheckpointBarrierHandler in StreamTwoInputSelectableProcessor URL: https://github.com/apache/flink/pull/8811#discussion_r298540216 ## File path: flink-streaming-java/src/main/java/org/apache/flink

[GitHub] [flink] GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298539105 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/f

[GitHub] [flink] pnowojski commented on issue #8455: [FLINK-12284, FLINK-12637][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-06-28 Thread GitBox
pnowojski commented on issue #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#issuecomment-506683902 > In addition, one PR should not connect to two jira tickets in general

[GitHub] [flink] GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298538461 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/A

[GitHub] [flink] GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298538576 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/A

[GitHub] [flink] GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298538537 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/A

[GitHub] [flink] GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298536587 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/A

[GitHub] [flink] GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298536587 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/A

[GitHub] [flink] dawidwys merged pull request #8876: [FLINK-12985][core][streaming] Rename StreamTransformation to org.apache.flink.api.dag.Transformation

2019-06-28 Thread GitBox
dawidwys merged pull request #8876: [FLINK-12985][core][streaming] Rename StreamTransformation to org.apache.flink.api.dag.Transformation URL: https://github.com/apache/flink/pull/8876 This is an automated message from the A

[jira] [Closed] (FLINK-12985) Move & rename StreamTransformation to org.apache.flink.api.dag.Transformation

2019-06-28 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-12985. Resolution: Fixed Implemented in fd511c345eac31f03b801ff19dbf1f8c86aae760 > Move & rename

[GitHub] [flink] zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298517179 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongr

[GitHub] [flink] zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298529362 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongr

[GitHub] [flink] zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
zhuzhurk commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298524268 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongr

[GitHub] [flink] flinkbot edited a comment on issue #8924: [hotfix][docs] Update the generated configuration docs for previous changes

2019-06-28 Thread GitBox
flinkbot edited a comment on issue #8924: [hotfix][docs] Update the generated configuration docs for previous changes URL: https://github.com/apache/flink/pull/8924#issuecomment-506655381 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the communit

[GitHub] [flink] zentol commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
zentol commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298517846 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongrap

[GitHub] [flink] zentol commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
zentol commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298503935 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongrap

[GitHub] [flink] zentol commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
zentol commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298508743 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongrap

[GitHub] [flink] zentol commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
zentol commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298520665 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongrap

[GitHub] [flink] zentol commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-28 Thread GitBox
zentol commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298526519 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongrap

[GitHub] [flink] ifndef-SleePy commented on issue #8894: [FLINK-12961][datastream] Providing an internal execution method of StreamExecutionEnvironment accepting StreamGraph as input parameter

2019-06-28 Thread GitBox
ifndef-SleePy commented on issue #8894: [FLINK-12961][datastream] Providing an internal execution method of StreamExecutionEnvironment accepting StreamGraph as input parameter URL: https://github.com/apache/flink/pull/8894#issuecomment-506671123 @aljoscha I think you have raised a good

[jira] [Commented] (FLINK-13025) Elasticsearch 7.x support

2019-06-28 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874807#comment-16874807 ] Aljoscha Krettek commented on FLINK-13025: -- If it is possible, i.e. if the inte

[GitHub] [flink] yanghua commented on issue #8871: [FLINK-12976] Bump Kafka client version to 2.3.0 for universal Kafka connector

2019-06-28 Thread GitBox
yanghua commented on issue #8871: [FLINK-12976] Bump Kafka client version to 2.3.0 for universal Kafka connector URL: https://github.com/apache/flink/pull/8871#issuecomment-50645 I commented some code for testing because I found if we close the Kafka producer the Transaction with id :

[GitHub] [flink] twalthr closed pull request #8874: [FLINK-12968][table-common] Add a utility for logical type casts

2019-06-28 Thread GitBox
twalthr closed pull request #8874: [FLINK-12968][table-common] Add a utility for logical type casts URL: https://github.com/apache/flink/pull/8874 This is an automated message from the Apache Git Service. To respond to the m

[jira] [Updated] (FLINK-13029) Remove expressionBridge from QueryOperations factories

2019-06-28 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-13029: - Summary: Remove expressionBridge from QueryOperations factories (was: Remove expression

[jira] [Created] (FLINK-13029) Remove expressionBridge from OperationTreeBuilder's factories

2019-06-28 Thread Dawid Wysakowicz (JIRA)
Dawid Wysakowicz created FLINK-13029: Summary: Remove expressionBridge from OperationTreeBuilder's factories Key: FLINK-13029 URL: https://issues.apache.org/jira/browse/FLINK-13029 Project: Flink

[GitHub] [flink] flinkbot commented on issue #8924: [hotfix][docs] Update the generated configuration docs for previous changes

2019-06-28 Thread GitBox
flinkbot commented on issue #8924: [hotfix][docs] Update the generated configuration docs for previous changes URL: https://github.com/apache/flink/pull/8924#issuecomment-506655381 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] zhijiangW commented on issue #8924: [hotfix][docs] Update the generated configuration docs for previous changes

2019-06-28 Thread GitBox
zhijiangW commented on issue #8924: [hotfix][docs] Update the generated configuration docs for previous changes URL: https://github.com/apache/flink/pull/8924#issuecomment-506655017 @flinkbot attention @azagrebin @zentol Thi

[GitHub] [flink] zhijiangW opened a new pull request #8924: [hotfix][docs] Update the generated configuration docs for previous changes

2019-06-28 Thread GitBox
zhijiangW opened a new pull request #8924: [hotfix][docs] Update the generated configuration docs for previous changes URL: https://github.com/apache/flink/pull/8924 ## What is the purpose of the change *Some configuration docs were forgot to update for previous changes, so run `gen

[GitHub] [flink] dawidwys commented on a change in pull request #8874: [FLINK-12968][table-common] Add a utility for logical type casts

2019-06-28 Thread GitBox
dawidwys commented on a change in pull request #8874: [FLINK-12968][table-common] Add a utility for logical type casts URL: https://github.com/apache/flink/pull/8874#discussion_r298500052 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/infere

[GitHub] [flink] twalthr commented on issue #8874: [FLINK-12968][table-common] Add a utility for logical type casts

2019-06-28 Thread GitBox
twalthr commented on issue #8874: [FLINK-12968][table-common] Add a utility for logical type casts URL: https://github.com/apache/flink/pull/8874#issuecomment-506650471 Thanks @dawidwys. Will merge... This is an automated mes

[GitHub] [flink] 1u0 commented on a change in pull request #8692: [FLINK-12804] Introduce mailbox-based ExecutorService

2019-06-28 Thread GitBox
1u0 commented on a change in pull request #8692: [FLINK-12804] Introduce mailbox-based ExecutorService URL: https://github.com/apache/flink/pull/8692#discussion_r298498045 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxProce

  1   2   >