azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298527316
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTracker.java ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition; + +import org.apache.flink.runtime.clusterframework.types.ResourceID; +import org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptor; +import org.apache.flink.runtime.executiongraph.ExecutionAttemptID; +import org.apache.flink.runtime.shuffle.PartitionDescriptor; +import org.apache.flink.runtime.shuffle.ProducerDescriptor; +import org.apache.flink.runtime.shuffle.ShuffleDescriptor; + +import java.util.Collection; +import java.util.concurrent.CompletableFuture; + +/** + * Utility for tracking partitions and issuing release calls to task executors and shuffle masters. + */ +public interface PartitionTracker { + + /** + * Asynchronously starts tracking the given partition. + * + * @param partition descriptor for the partition + * @param producerDescriptor descriptor for the producer + * @param resultPartitionDeploymentDescriptorFactory factory for the ResultPartitionDeploymentDescriptor + * @return future containing the assembled result partition deployment descriptor + */ + CompletableFuture<ResultPartitionDeploymentDescriptor> registerPartition( + PartitionDescriptor partition, + ProducerDescriptor producerDescriptor, + ResultPartitionDeploymentDescriptorFactory resultPartitionDeploymentDescriptorFactory); + + /** + * Returns all tracked partitions for the given producer. + * + * @param producerId producer to return tracked partitions for + * @return tracked partitions for the given producer + */ + Collection<ResultPartitionDeploymentDescriptor> getTrackedDeploymentDescriptors(ExecutionAttemptID producerId); + + /** + * Stops the tracking of all partitions for the given task executor ID, without issuing any release calls. + * + * @param producingTaskExecutorId task executor id to determine relevant partitions + */ + void stopTrackingAllPartitions(ResourceID producingTaskExecutorId); + + /** + * Releases all partitions for the given producer, and stop the tracking of partitions that were released. + * + * @param producerId producer id to determine relevant partitions + */ + void stopTrackingAndReleasePartitions(final ExecutionAttemptID producerId); Review comment: atm it is stop all for exec id and release what needs release. I think comment needs adjustment and function could be called: `stopTrackingAndReleasePartitionsForExecution` same for the next method, stop all for task executor and release what needs release: `stopTrackingAndReleasePartitionsOnTaskExecutor` (release all is a bit confusing) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
