azagrebin commented on a change in pull request #8778: 
[FLINK-12615][coordination] Track partitions on JM
URL: https://github.com/apache/flink/pull/8778#discussion_r298537362
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
 ##########
 @@ -285,7 +281,13 @@ public LogicalSlot getAssignedResource() {
 
        public Optional<ResultPartitionDeploymentDescriptor> 
getResultPartitionDeploymentDescriptor(
                        IntermediateResultPartitionID id) {
-               return Optional.ofNullable(producedPartitions.get(id));
+               Collection<ResultPartitionDeploymentDescriptor> 
trackedDeploymentDescriptors = 
vertex.getExecutionGraph().getPartitionTracker().getTrackedDeploymentDescriptors(getAttemptId());
+               for (ResultPartitionDeploymentDescriptor 
resultPartitionDeploymentDescriptor : trackedDeploymentDescriptors) {
 
 Review comment:
   anyways I think the method rather belongs to the tracker with the exec id 
added to the signature

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to