azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#discussion_r298504283
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerImpl.java ########## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition; + +import org.apache.flink.api.common.JobID; +import org.apache.flink.runtime.clusterframework.types.ResourceID; +import org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptor; +import org.apache.flink.runtime.executiongraph.ExecutionAttemptID; +import org.apache.flink.runtime.shuffle.PartitionDescriptor; +import org.apache.flink.runtime.shuffle.ProducerDescriptor; +import org.apache.flink.runtime.shuffle.ShuffleDescriptor; +import org.apache.flink.runtime.shuffle.ShuffleMaster; +import org.apache.flink.util.Preconditions; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.CompletableFuture; +import java.util.stream.Collectors; + +/** + * Utility for tracking partitions and issuing release calls to task executors and shuffle masters. + */ +public class PartitionTrackerImpl implements PartitionTracker { + + private final JobID jobId; + + private final Map<ExecutionAttemptID, InternalPartitionInfo> partitionInfoByProducer = new HashMap<>(); + private final Map<ResourceID, Collection<ExecutionAttemptID>> producersByExecutor = new HashMap<>(); + + private final ShuffleMaster<?> shuffleMaster; + + private PartitionTrackerFactory.TaskExecutorGatewayLookup taskExecutorGatewayLookup; + + public PartitionTrackerImpl( + final JobID jobId, + final ShuffleMaster<?> shuffleMaster, + final PartitionTrackerFactory.TaskExecutorGatewayLookup taskExecutorGatewayLookup) { + + this.jobId = Preconditions.checkNotNull(jobId); + this.shuffleMaster = Preconditions.checkNotNull(shuffleMaster); + this.taskExecutorGatewayLookup = taskExecutorGatewayLookup; + } + + @Override + public CompletableFuture<ResultPartitionDeploymentDescriptor> registerPartition( + final PartitionDescriptor partitionDescriptor, + final ProducerDescriptor producerDescriptor, + final ResultPartitionDeploymentDescriptorFactory resultPartitionDeploymentDescriptorFactory) { + + CompletableFuture<? extends ShuffleDescriptor> shuffleDescriptorFuture = shuffleMaster.registerPartitionWithProducer(partitionDescriptor, producerDescriptor); + + return shuffleDescriptorFuture + .thenApply(shuffleDescriptor -> + resultPartitionDeploymentDescriptorFactory.createResultPartitionDeploymentDescriptor(partitionDescriptor, shuffleDescriptor)) + .thenApply(deploymentDescriptor -> { + startTrackingPartition(producerDescriptor.getProducerLocation(), deploymentDescriptor); Review comment: At the moment, there is no requirement that shuffle master returns the descriptor into the main thread which is not even given to the shuffle master. This was the reason why `Execution.registerProducedPartitions` (non-static) modified its state in `getJobMasterMainThreadExecutor`. I would give the `JobMasterMainThreadExecutor` to `PartitionTrackerImpl` and do `assertRunningInJobMasterMainThread();` for state modifying methods. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
