zentol commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r298508743
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest.java ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.runtime.executiongraph; + +import org.apache.flink.metrics.groups.UnregisteredMetricsGroup; +import org.apache.flink.runtime.akka.AkkaUtils; +import org.apache.flink.runtime.checkpoint.CheckpointCoordinator; +import org.apache.flink.runtime.checkpoint.CheckpointRetentionPolicy; +import org.apache.flink.runtime.checkpoint.CheckpointStatsTracker; +import org.apache.flink.runtime.checkpoint.StandaloneCheckpointIDCounter; +import org.apache.flink.runtime.checkpoint.StandaloneCompletedCheckpointStore; +import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutor; +import org.apache.flink.runtime.concurrent.ManuallyTriggeredScheduledExecutor; +import org.apache.flink.runtime.execution.ExecutionState; +import org.apache.flink.runtime.executiongraph.failover.AdaptedRestartPipelinedRegionStrategyNG; +import org.apache.flink.runtime.executiongraph.restart.InfiniteDelayRestartStrategy; +import org.apache.flink.runtime.executiongraph.utils.SimpleSlotProvider; +import org.apache.flink.runtime.jobgraph.JobGraph; +import org.apache.flink.runtime.jobgraph.JobVertex; +import org.apache.flink.runtime.jobgraph.ScheduleMode; +import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable; +import org.apache.flink.runtime.jobgraph.tasks.CheckpointCoordinatorConfiguration; +import org.apache.flink.runtime.state.memory.MemoryStateBackend; +import org.apache.flink.runtime.taskmanager.TaskExecutionState; +import org.apache.flink.runtime.testingUtils.TestingUtils; +import org.apache.flink.util.TestLogger; + +import org.junit.Before; +import org.junit.Test; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.Iterator; +import java.util.List; + +import static org.apache.flink.util.Preconditions.checkState; +import static org.hamcrest.Matchers.equalTo; +import static org.hamcrest.Matchers.hasSize; +import static org.hamcrest.Matchers.is; +import static org.junit.Assert.assertThat; + +/** + * Tests for {@link AdaptedRestartPipelinedRegionStrategyNG}. + */ +public class AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest extends TestLogger { + + private ManuallyTriggeredScheduledExecutor manualMainThreadExecutor; + + private ComponentMainThreadExecutor componentMainThreadExecutor; + + @Before + public void setUp() { + manualMainThreadExecutor = new ManuallyTriggeredScheduledExecutor(); + componentMainThreadExecutor = new ScheduledExecutorToComponentMainThreadExecutorAdapter(manualMainThreadExecutor, Thread.currentThread()); + } + + @Test + public void abortPendingCheckpointsWhenRestartingTasks() throws Exception { + final JobGraph jobGraph = createStreamingJobGraph(); + final ExecutionGraph executionGraph = createExecutionGraph(jobGraph); + + final Iterator<ExecutionVertex> vertexIterator = executionGraph.getAllExecutionVertices().iterator(); + final ExecutionVertex onlyExecutionVertex = vertexIterator.next(); + + setTaskRunning(executionGraph, onlyExecutionVertex); + + final CheckpointCoordinator checkpointCoordinator = executionGraph.getCheckpointCoordinator(); + checkState(checkpointCoordinator != null); + + checkpointCoordinator.triggerCheckpoint(System.currentTimeMillis(), false); + final int pendingCheckpointsBeforeFailure = checkpointCoordinator.getNumberOfPendingCheckpoints(); + + failVertex(onlyExecutionVertex); + + assertThat(pendingCheckpointsBeforeFailure, is(equalTo(1))); + assertNoPendingCheckpoints(checkpointCoordinator); + } + + private void setTaskRunning(final ExecutionGraph executionGraph, final ExecutionVertex executionVertex) { + executionGraph.updateState( + new TaskExecutionState(executionGraph.getJobID(), + executionVertex.getCurrentExecutionAttempt().getAttemptId(), + ExecutionState.RUNNING)); + } + + private void failVertex(final ExecutionVertex onlyExecutionVertex) { + onlyExecutionVertex.getCurrentExecutionAttempt().fail(new Exception("Test Exception")); + manualMainThreadExecutor.triggerAll(); + } + + private static JobGraph createStreamingJobGraph() { + final JobVertex v1 = new JobVertex("vertex1"); + v1.setInvokableClass(AbstractInvokable.class); + + final JobGraph jobGraph = new JobGraph(v1); + jobGraph.setScheduleMode(ScheduleMode.EAGER); + + return jobGraph; + } + + private ExecutionGraph createExecutionGraph(final JobGraph jobGraph) throws Exception { + final ExecutionGraph executionGraph = new ExecutionGraph( + new DummyJobInformation( + jobGraph.getJobID(), + jobGraph.getName()), + TestingUtils.defaultExecutor(), + TestingUtils.defaultExecutor(), + AkkaUtils.getDefaultTimeout(), + new InfiniteDelayRestartStrategy(10), + AdaptedRestartPipelinedRegionStrategyNG::new, + new SimpleSlotProvider(jobGraph.getJobID(), 1)); + + executionGraph.attachJobGraph(jobGraph.getVerticesSortedTopologicallyFromSources()); + enableCheckpointing(executionGraph); + executionGraph.setScheduleMode(jobGraph.getScheduleMode()); + executionGraph.start(componentMainThreadExecutor); + executionGraph.scheduleForExecution(); + manualMainThreadExecutor.triggerAll(); + return executionGraph; + } + + private static void enableCheckpointing(final ExecutionGraph executionGraph) { + final List<ExecutionJobVertex> jobVertices = new ArrayList<>(executionGraph.getAllVertices().values()); + final CheckpointCoordinatorConfiguration checkpointCoordinatorConfiguration = new CheckpointCoordinatorConfiguration( + Long.MAX_VALUE, + Long.MAX_VALUE, + 0, + 1, + CheckpointRetentionPolicy.RETAIN_ON_CANCELLATION, + true, + false, + 0); + + executionGraph.enableCheckpointing( + checkpointCoordinatorConfiguration, + jobVertices, + jobVertices, + jobVertices, + Collections.emptyList(), + new StandaloneCheckpointIDCounter(), + new StandaloneCompletedCheckpointStore(1), + new MemoryStateBackend(), + new CheckpointStatsTracker( + 0, + jobVertices, + checkpointCoordinatorConfiguration, + new UnregisteredMetricsGroup())); + } + + private static void assertNoPendingCheckpoints(final CheckpointCoordinator checkpointCoordinator) { + assertThat(checkpointCoordinator.getPendingCheckpoints().keySet(), hasSize(0)); Review comment: maybe also check that `CheckpointCoordinator#getSuccessfulCheckpoints()` is empty ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
