bowenli86 commented on a change in pull request #8889: [FLINK-12934][hive] add
additional dependencies for flink-connector-hive to connect to remote hive
metastore service
URL: https://github.com/apache/flink/pull/8889#discussion_r298769864
##########
File path: flink-connectors/flink-connector-hive/pom.xml
##########
@@ -452,29 +493,15 @@ under the License.
<configuration>
<shadeTestJar>false</shadeTestJar>
<artifactSet>
- <!-- Needs
end-to-end tests to ensure the built flink-connector-hive jar contains all
required dependencies and can run -->
<includes>
-
<include>commons-dbcp:commons-dbcp</include>
-
<include>commons-pool:commons-pool</include>
-
<include>commons-beanutils:commons-beanutils</include>
-
<include>com.fasterxml.jackson.core:*</include>
-
<include>com.jolbox:bonecp</include>
-
<include>org.apache.thrift:libthrift</include>
-
<include>org.datanucleus:*</include>
-
<include>org.antlr:antlr-runtime</include>
+
<include>*:*</include>
</includes>
</artifactSet>
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<!-- DO NOT RELOCATE
GUAVA IN THIS PACKAGE -->
<filters>
<filter>
- <!--
some dependencies bring their own LICENSE.txt which we don't need -->
<artifact>*:*</artifact>
-
<excludes>
Review comment:
because we don't package any hive/hadoop dependencies anymore a long time
ago. They are all provided, so we don't need to filter anything for them. This
is a kind of historical leftover, and can be on its own PR if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
