alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2703664954
> Should
[ScalarUDFImpl::invoke_batch](https://github.com/apache/datafusion/blob/43ecd9b807877946706628633308f73a4645de1f/datafusion/expr/src/udf.rs#L616)
be marked as deprecated?
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2707248187
The release was approved and published to crates.io
See thread here:
https://lists.apache.org/thread/rmvsc1ffpqd2z3m0c9lptjypzl83k2j8
I have filed a ticket for 47
alamb closed issue #14123: Release DataFusion `46.0.0`
URL: https://github.com/apache/datafusion/issues/14123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
Blizzara commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2703526303
I tested the upgrade on our system, and ran into bunch of runtime errors
with `Function X does not implement invoke but called`. They seem to come from
us wrapping some DF UDFs
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2706188668
> [@alamb](https://github.com/alamb) i will catch a flight today and have a
short vacation, do you have time to do the final release?
Yes, absolutely -- thank you for all yo
xudong963 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2705790015
@alamb i will catch a flight today and have a short vacation, do you have
time to do the final release?
--
This is an automated message from the Apache Git Service.
To respo
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2704322682
> > I think we should mark it deprecated
>
> Filed a PR here:
[#15049](https://github.com/apache/datafusion/pull/15049). Though I see there's
already a release branch, how
Blizzara commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2703727887
> I think we should mark it deprecated
Filed a PR here: https://github.com/apache/datafusion/pull/15049. Though I
see there's already a release branch, how does that work
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2697426444
We have merged the fix here
- https://github.com/apache/datafusion/pull/14990
To simplify votiing I suggest we backport that fix to the `branch-46` line
and make a second
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2695597051
Update : the error with validation is related to a change in rustup, not the
release candidate directly. I am working on a fix
--
This is an automated message from the Apache Gi
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2694932150
I found an issue while validation:
- https://github.com/apache/datafusion/issues/14982
--
This is an automated message from the Apache Git Service.
To respond to the message,
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2694820798
> [@alamb](https://github.com/alamb) My pleasure
>
> I sent the release email to
[d...@datafusion.apache.org](mailto:d...@datafusion.apache.org), did you see it?
Yup!
xudong963 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2694451125
@alamb My pleasure
I sent the release email to d...@datafusion.apache.org, did you see it?
--
This is an automated message from the Apache Git Service.
To respond to t
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2694403217
> > Would you like to try and make the release candidate now?
>
> Yes, but need to wait a bit. I'm out now
SOunds good -- let me know if you hit issues or want me to t
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2694187272
Thanks @xudong963!
I also pushed a note about the upgrade guide into the branch
- https://github.com/apache/datafusion/pull/14979
Would you like to try and make the
xudong963 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2694262604
> Would you like to try and make the release candidate now?
Yes, but need to wait a bit. I'm out now
--
This is an automated message from the Apache Git Service.
To re
xudong963 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2694098342
All PRs have been patched to branch-46！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
xudong963 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2693752495
> Remaining steps are:
>
> * Merge [Deprecate `Expr::Wildcard`
#14959](https://github.com/apache/datafusion/pull/14959)
> * Make a backport and merge of Expr wildcard
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2692731904
Ok I think we are very close to being able to make a release candidate for 46
- I merged https://github.com/apache/datafusion/pull/14956
- And backported it https://github
linhr commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2692282881
> Can someone make a PR soon? We are in the final phases of getting ready
for 46 release
I've created a PR to deprecate `Expr::Wildcard`: #14959.
--
This is an automated
xudong963 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2692260440
@alamb Make sense, made the branch:
https://github.com/apache/datafusion/tree/branch-46
--
This is an automated message from the Apache Git Service.
To respond to the messag
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2692196440
We found one more issue while testing 46 in delta-rs:
- https://github.com/apache/datafusion/issues/14957
@blaginin has a PR up to address it:
- https://github.com/apac
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2692200337
@xudong963
I just merged
- https://github.com/apache/datafusion/pull/14903
Can you now make a `branch-46` branch?
That will then allow us to merge additiona
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2692195887
> +1 for marking `Expr::Wildcard` as deprecated.
>
> > Expr::Wildcard is still used in other cases not only count(*). We only
remove the count wildcard case, so we can't dep
linhr commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2691905103
+1 for marking `Expr::Wildcard` as deprecated.
> Expr::Wildcard is still used in other cases not only count(*). We only
remove the count wildcard case, so we can't deprecate
jayzhan211 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2691801390
> I think this sounds like a good idea to me. I don't think we are actively
trying to cause pain for downstream users, more like we struggle to find the
time to properly thin
shehabgamin commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2691748036
> [@shehabgamin](https://github.com/shehabgamin) /
[@jayzhan211](https://github.com/jayzhan211) should we makr `Expr::Wildcard` as
deprecated?
I'm in support of this!
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2691604815
I have a PR up to fix the regression
- https://github.com/apache/datafusion/pull/14948
--
This is an automated message from the Apache Git Service.
To respond to the message,
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2691572889
My update here:
1. We fixed all the known bugs
https://github.com/apache/datafusion/issues/14123#issuecomment-2689507558
2. I found another regression today that I think need
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2691106681
> If Expr::Wildcard no longer works, why is it still being kept around?
I don't know -- maybe we should mark it deprecated
> There is a concerning pattern of various
shehabgamin commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2690645120
We were able to work around the `count(*)` regression in Sail by doing the
following when constructing an `Expr::AggregateFunction` for `count_udaf`:
https://github.com/l
xudong963 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2690357837
> So I am hopeful we'll be able to close out the tickets tomorrow and maybe
create a release branch over the weekend or Monday.
>
> FYI [@xudong963](https://github.com/x
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2689507558
I suggest we move the discussion about what expected Expr / Logical Plans to
a separate ticket and leave this one to cover release cooedination
Update for the release
jayzhan211 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2688082518
> Would this imply that LogicalPlan is closer to a "resolved" representation
of the query
yes, this is our goal.
> but such capability cannot be leveraged for pr
linhr commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2687940726
@jayzhan211 Thanks for the context. For this particular regression, we can
implement the wildcard logic in the Sail codebase [as you have
suggested](https://github.com/lakehq/sail
jayzhan211 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2687278508
For count wild case, `SqlToRel` is customizable by
`AggregateFunctionPlanner`. For non-sql case like dataframe API,
`count_wildcard` is changed to `count_all` which use `coun
shehabgamin commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2687207106
@jayzhan211 Thanks for the explanation!
@linhr and I are a bit concerned about the general direction of #14618.
Logical analyzers are modular components in DataFusion
jayzhan211 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2687033429
> If something built and rewrite by analyzer before, it will now fail
If you have count wildcard and is rewritten by analyzer, it fails because we
remove the count wild
shehabgamin commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2687025000
> ```
> query I
> SELECT count(*) FROM VALUES (NULL), (5), (5), (20) AS tab(col);
>
> 4
> ```
>
> Is there other query reproducible in main branch? T
jayzhan211 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2686936016
```
query I
SELECT count(*) FROM VALUES (NULL), (5), (5), (20) AS tab(col);
4
```
Is there other query reproducible in main branch? The query given d
shehabgamin commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2686821819
@alamb @jayzhan211 @xudong963 Unfortunately
https://github.com/apache/datafusion/pull/14824 did not fix the wildcard issue.
I'm currently working on Sail's upcoming release,
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2684735863
> There is a concerning regression appearing frequently in Sail tests:
>
> Physical plan does not support logical expression Wildcard { qualifier:
None, options: WildcardOpt
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2684731708
I started writing an upgrade guide as I go through the upgrade process with
delta-rs:
- https://github.com/apache/datafusion/pull/14891
--
This is an automated message fr
shehabgamin commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2684612667
> I am running into one error in Comet: `Function sha256 does not implement
invoke but called`. I will investigate this today.
@andygrove I encountered the same error
shehabgamin commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2684037703
Is there a reason why some `arrow` crates are using version `54.2.0` while
others are using `54.1.0`?
```
arrow = { version = "54.2.0", features = [
"prettyprint
xudong963 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2682266300
I'll open the changelog PR tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
andygrove commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2682135437
I am running into one error in Comet: `Function sha256 does not implement
invoke but called`. I will investigate this today.
--
This is an automated message from the Apache
shehabgamin commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2680109294
I will test with Sail by Wednesday!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2679454880
I made a PR for testing in delta here:
- https://github.com/delta-io/delta-rs/pull/3261
Still has some issues to work out
--
This is an automated message from the Apac
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2679109654
> [@alamb](https://github.com/alamb) In `Bugs that would be good to fix`,
~four issues already have PRs, and one does not~ four issues and all have PRs.
I'll focus on reviewing th
xudong963 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2676905580
In `Bugs that would be good to fix`, four issues already have PRs, and one
does not. I'll focus on reviewing the four in the next two days and plan to
update version and chang
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2676857655
@xudong963 are we still thinking of trying to get the release ready this
upcoming week?
I will try and focus my efforts starting tomorrow on ensuring the bugs
listed in "B
andygrove commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2672760938
I noticed that older releases have not been removed from
https://dist.apache.org/repos/dist/release/datafusion/. Perhaps this can be
cleaned up as part of this release.
andygrove commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2669417488
I've created a draft PR to upgrade Comet to use latest DataFusion:
https://github.com/apache/datafusion-comet/pull/1423
--
This is an automated message from the Apache Git
xudong963 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2649751148
> [@xudong963](https://github.com/xudong963) when would you like to start
making the release? Maybe we should targe the week of Feb 24 🤔
yes, the week is suitable.
--
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2648320294
@xudong963 when would you like to start making the release? Maybe we should
targe the week of Feb 24 🤔
--
This is an automated message from the Apache Git Service.
To respond t
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2648317619
> [@alamb](https://github.com/alamb) I'll also do some updates in the issue
summary.
>
> Considering that this is the first time I've been involved in this
process, could y
xudong963 commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2647969513
@alamb I'll also do some updates in the issue summary.
Considering that this is the first time I've been involved in this process,
could you please remind me if some cri
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2589707349
I think @xudong963 said they might be interested in running this one:
- https://github.com/apache/datafusion/issues/14008#issuecomment-2589148761
> Thanks, alamb, I book
59 matches
Mail list logo
