linhr commented on issue #14123: URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2687940726
@jayzhan211 Thanks for the context. For this particular regression, we can implement the wildcard logic in the Sail codebase [as you have suggested](https://github.com/lakehq/sail/pull/388#issuecomment-2687452817). This makes sense if `Expr::Wildcard` is going to be removed. (Would this imply that `LogicalPlan` is closer to a "resolved" representation of the query?) Our concerns is mostly around the general direction of #14618. It seems that `SqlToRel` is acquiring more capability for logical analysis, but such capability cannot be leveraged for projects that builds `LogicalPlan` from non-SQL inputs (e.g. Sail). So I'm wondering if it's possible to improve the modularity of logical analysis and benefit downstream projects. (This probably goes beyond the scope of the 46.0.0 release though.) Do you have thoughts around this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
