jayzhan211 commented on issue #14123: URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2687278508
For count wild case, `SqlToRel` is customizable by `AggregateFunctionPlanner`. For non-sql case like dataframe API, `count_wildcard` is changed to `count_all` which use `count(1)` directly, so it doesn't need the rewrite after all. The only concern left in #14618 the name is changed from `count(*)` to `count(1)` so the name is not preserved but this is not your case too. I guess you aren't using `count_wildcard` but directly build the `Expr::Aggregate()` with `Expr::Wildcard`? You can use `count_all` to get the equivalent `Expr`, since Expr::Wildcard is planned to be deprecated #7765 so making this backward compatible is not ideal. Is there any other way to construct LogicalPlan? 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
