Blizzara commented on issue #14123: URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2703526303
I tested the upgrade on our system, and ran into bunch of runtime errors with `Function X does not implement invoke but called`. They seem to come from us wrapping some DF UDFs inside our own, and us calling their `invoke_batch` methods, which then fail to work as that delegates to `invoke` but the DF UDFs only implement `invoke_with_args`. Should [ScalarUDFImpl::invoke_batch](https://github.com/apache/datafusion/blob/43ecd9b807877946706628633308f73a4645de1f/datafusion/expr/src/udf.rs#L616) be marked as deprecated? (There is already a comment saying that in the docstring, but the compiler doesn't catch that 😅 ) That way we'd at least get some compile-time warning that we're doing something bad, now there was only runtime failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
