alamb commented on issue #14123: URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2692195887
> +1 for marking `Expr::Wildcard` as deprecated. > > > Expr::Wildcard is still used in other cases not only count(*). We only remove the count wildcard case, so we can't deprecate it until other cases (select * from table) are addressed. > > We cannot **remove** `Expr::Wildcard` since other use cases are not addressed yet, but I feel we should mark it as deprecated to raise awareness to downstream users, since the deprecation process has already (partially) happened. It might be a good idea to communicate this now so that other projects can have time to adapt to the upcoming changes. Can someone make a PR soon? We are in the final phases of getting ready for 46 release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
