shehabgamin commented on issue #14123: URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2687207106
@jayzhan211 Thanks for the explanation! @linhr and I are a bit concerned about the general direction of #14618. Logical analyzers are modular components in DataFusion that downstream projects can configure as needed, whereas `SqlToRel` isn't customizable. Moreover, `SqlToRel` doesn’t address cases where the `LogicalPlan` is not built from SQL. This is particularly relevant for Sail, where we need to construct `LogicalPlan`s from both SQL and the protobuf received via the Spark Connect protocol. @alamb's comment here is particularly relevant to Sail's use case: https://github.com/apache/datafusion/issues/14618#issuecomment-2660868799 cc @findepi as this may relate to you as well. Is there a chance that the breaking changes could be reevaluated? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
