shehabgamin commented on issue #14123: URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2687025000
> ``` > query I > SELECT count(*) FROM VALUES (NULL), (5), (5), (20) AS tab(col); > ---- > 4 > ``` > > Is there other query reproducible in main branch? The query given doesn't produce error. @jayzhan211 These are failures on the Sail codebase. > If something built and rewrite by analyzer before, it will now fail I don’t quite understand this, can you explain this further? Sail doesn't use DataFusion's `SqlToRel` but we use all of the DataFusion analyzers and optimizers. The fix in https://github.com/apache/datafusion/pull/14824 wouldn't be relevant to Sail because we assign unique names in the schema when constructing the `LogicalPlan`. With that in mind, it seems like the regression is not fully addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
