iffyio commented on code in PR #1865:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1865#discussion_r2131627748
##
tests/sqlparser_common.rs:
##
@@ -9132,7 +9132,9 @@ fn test_create_index_with_with_clause() {
#[test]
fn parse_drop_index() {
let sql = "DROP
pepijnve commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2948268910
@zhuqi-lucas @alamb I wanted to work on measuring the performance impact of
this PR today, but looking at
https://github.com/apache/datafusion/pull/16262#pullrequestreview-290313953
xudong963 merged PR #16267:
URL: https://github.com/apache/datafusion/pull/16267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
pepijnve commented on code in PR #16262:
URL: https://github.com/apache/datafusion/pull/16262#discussion_r2131600952
##
benchmarks/compare.py:
##
@@ -148,10 +174,23 @@ def compare(
)
continue
-total_baseline_time += baseline_result.execution_t
pepijnve commented on code in PR #16262:
URL: https://github.com/apache/datafusion/pull/16262#discussion_r2131585926
##
benchmarks/bench.sh:
##
@@ -66,10 +67,11 @@ DATAFUSION_DIR=/source/datafusion ./bench.sh run tpch
**
* Commands
**
-data: Generates
ding-young opened a new pull request, #16268:
URL: https://github.com/apache/datafusion/pull/16268
## Which issue does this PR close?
- Closes #16130 .
## TODO
- [ ] add test for compression in spill file
- [ ] refine arg names
- [ ] check config docs
xudong963 commented on issue #15771:
URL: https://github.com/apache/datafusion/issues/15771#issuecomment-2948082010
https://github.com/apache/datafusion/pull/16267 After it's merged, I'll push
the 48.0.0-rc2 and start vote
--
This is an automated message from the Apache Git Service.
T
xudong963 opened a new pull request, #16267:
URL: https://github.com/apache/datafusion/pull/16267
## Which issue does this PR close?
- Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes teste
clflushopt commented on issue #14608:
URL: https://github.com/apache/datafusion/issues/14608#issuecomment-2948048431
Hey @alamb following suggestions from @kevinjqliu I am happy to say that
https://github.com/clflushopt/datafusion-tpch provides a ux on par with duckdb
and what we discussed
kosiew commented on code in PR #16257:
URL: https://github.com/apache/datafusion/pull/16257#discussion_r2131457267
##
datafusion/sqllogictest/test_files/limit.slt:
##
@@ -860,6 +860,7 @@ query I
with selection as (
select *
from test_limit_with_partitions
+order b
kosiew opened a new issue, #16266:
URL: https://github.com/apache/datafusion/issues/16266
#16258 closes #16228
We should [update the fuzz tests to include Dict with null
values](https://github.com/apache/datafusion/pull/16258#issuecomment-2944973123).
--
This is an automated messa
xudong963 commented on issue #15771:
URL: https://github.com/apache/datafusion/issues/15771#issuecomment-2948015656
> It looks like these changes all went into the `main` branch. I've been
testing off of the `48.0.0-rc1` tag, should I switch to test off of `main`?
I'll update branch46
kosiew commented on code in PR #16258:
URL: https://github.com/apache/datafusion/pull/16258#discussion_r2131413138
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -5030,6 +5030,20 @@ select count(distinct column1), count(distinct column2)
from dict_test group by
sta
parthchandra commented on issue #1849:
URL:
https://github.com/apache/datafusion-comet/issues/1849#issuecomment-2947748623
I wonder how likely is it that a comet user would be on an architecture that
does not support unaligned memory access.
--
This is an automated message from the Apac
parthchandra commented on issue #1843:
URL:
https://github.com/apache/datafusion-comet/issues/1843#issuecomment-2947362362
Why would the expected result be `[null], [null], [null]` ? This means that
all the structs are null but that is not the actual data. Only in the third
row, is the str
Copilot commented on code in PR #16262:
URL: https://github.com/apache/datafusion/pull/16262#discussion_r2131026859
##
benchmarks/compare.py:
##
@@ -148,10 +174,23 @@ def compare(
)
continue
-total_baseline_time += baseline_result.execution_ti
2010YOUY01 commented on code in PR #16262:
URL: https://github.com/apache/datafusion/pull/16262#discussion_r2131020155
##
benchmarks/bench.sh:
##
@@ -66,10 +67,11 @@ DATAFUSION_DIR=/source/datafusion ./bench.sh run tpch
**
* Commands
**
-data: Generate
shehabgamin commented on issue #15771:
URL: https://github.com/apache/datafusion/issues/15771#issuecomment-2947035398
> I think we have merged all the desired PRs now:
>
> * [fix: NaN semantics in GROUP BY
#16256](https://github.com/apache/datafusion/pull/16256)
>
> * [
GitHub user lwwmanning added a comment to the discussion: DISCUSSION:
DataFusion Meetup in New York, NY, USA
I’d love to give a talk on DataFusion/Vortex stuff! Specifically, how
DataFusion’s extensibility was hugely useful for bootstrapping,
building/testing, & benchmarking a new file format
huaxingao commented on issue #1833:
URL:
https://github.com/apache/datafusion-comet/issues/1833#issuecomment-2946713655
To work around the shading issues, I'm working on higher-level abstractions
so that we don't need to pass any Parquet objects.
--
This is an automated message from the
jonathanc-n commented on code in PR #16258:
URL: https://github.com/apache/datafusion/pull/16258#discussion_r2130695219
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -5030,6 +5030,20 @@ select count(distinct column1), count(distinct column2)
from dict_test group by
jonathanc-n commented on code in PR #16258:
URL: https://github.com/apache/datafusion/pull/16258#discussion_r2130695219
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -5030,6 +5030,20 @@ select count(distinct column1), count(distinct column2)
from dict_test group by
alamb commented on PR #1869:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1869#issuecomment-2946189427
ICEBERG!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
andygrove commented on PR #1736:
URL:
https://github.com/apache/datafusion-comet/pull/1736#issuecomment-2946200491
The Spark SQL tests for 3.5.5 are now all passing, and there is just the
TPC-DS issue left
--
This is an automated message from the Apache Git Service.
To respond to the mes
alamb commented on code in PR #16255:
URL: https://github.com/apache/datafusion/pull/16255#discussion_r2130289823
##
datafusion/physical-plan/src/metrics/baseline.rs:
##
@@ -117,9 +117,10 @@ impl BaselineMetrics {
}
}
-/// Process a poll result of a stream pr
alamb commented on issue #15771:
URL: https://github.com/apache/datafusion/issues/15771#issuecomment-2946169144
I think we have merged all the desired PRs now:
- https://github.com/apache/datafusion/pull/16256
- https://github.com/apache/datafusion/pull/16261
- https://github.com/apa
alamb commented on code in PR #16257:
URL: https://github.com/apache/datafusion/pull/16257#discussion_r2130296313
##
datafusion/sqllogictest/test_files/limit.slt:
##
@@ -860,6 +860,7 @@ query I
with selection as (
select *
from test_limit_with_partitions
+order by
alamb closed issue #14562: Expose user defined functions in the FFI
URL: https://github.com/apache/datafusion/issues/14562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
alamb merged PR #16261:
URL: https://github.com/apache/datafusion/pull/16261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb merged PR #16255:
URL: https://github.com/apache/datafusion/pull/16255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
GitHub user leoDYL added a comment to the discussion: DISCUSSION: DataFusion
Meetup in New York, NY, USA
We're looking for a variety of topics with the theme of reflecting on the 50
releases of DataFusion! Seems [VegaFusion](https://vegafusion.io/) has been
using DataFusion for a while so it
alamb commented on PR #16261:
URL: https://github.com/apache/datafusion/pull/16261#issuecomment-2945974874
If the tests pass I'll merge it in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
alamb commented on PR #16261:
URL: https://github.com/apache/datafusion/pull/16261#issuecomment-2945974005
I rebased this PR on main so it was ready to go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
alamb commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2945964478
gogogo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
alamb merged PR #14775:
URL: https://github.com/apache/datafusion/pull/14775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16264:
URL: https://github.com/apache/datafusion/pull/16264#issuecomment-2945947663
WOOHOO 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
jonathanc-n commented on PR #16210:
URL: https://github.com/apache/datafusion/pull/16210#issuecomment-2945916745
There's an interesting implementation of index joins
[here](https://github.com/duckdb/duckdb/pull/1008), but this would involve
creating indexes. What are the thoughts on support
alamb commented on code in PR #16258:
URL: https://github.com/apache/datafusion/pull/16258#discussion_r2130020509
##
datafusion/functions-aggregate/src/count.rs:
##
@@ -711,8 +711,8 @@ impl Accumulator for DistinctCountAccumulator {
}
(0..arr.len()).try_for_e
andygrove closed issue #1739: Enable more DPP Spark SQL tests
URL: https://github.com/apache/datafusion-comet/issues/1739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
andygrove commented on issue #1739:
URL:
https://github.com/apache/datafusion-comet/issues/1739#issuecomment-2945837570
Fixed in https://github.com/apache/datafusion-comet/issues/1831 and
https://github.com/apache/datafusion-comet/pull/1838
--
This is an automated message from the Apache
alamb commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2945762124
It seems github is experiencing issues. I will close/reopen this PR to
restart the checks
https://www.githubstatus.com/
https://github.com/user-attachments/assets/2bc627ef
timsaucer opened a new pull request, #14775:
URL: https://github.com/apache/datafusion/pull/14775
## Which issue does this PR close?
This PR addresses part of #14562
## Rationale for this change
This change allows for using user defined **aggregate** functions across FFI
alamb closed pull request #14775: feat: Add Aggregate UDF to FFI crate
URL: https://github.com/apache/datafusion/pull/14775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
dependabot[bot] commented on PR #16143:
URL: https://github.com/apache/datafusion/pull/16143#issuecomment-2945761029
Dependabot tried to update this pull request, but something went wrong.
We're looking into it, but in the meantime you can retry the update by
commenting `@dependabot rebase`
GitHub user jonmmease added a comment to the discussion: DISCUSSION: DataFusion
Meetup in New York, NY, USA
What kinds of talks are you looking for? I may be available to give one on how
[VegaFusion](https://vegafusion.io/) uses DataFusion.
GitHub link:
https://github.com/apache/datafusion/d
adriangb commented on PR #16014:
URL: https://github.com/apache/datafusion/pull/16014#issuecomment-2945656786
I've rebased this and it's looking nice now.
I think the main open question is the concern about performance / overhead:
https://github.com/apache/datafusion/pull/16014/file
adriangb commented on code in PR #16014:
URL: https://github.com/apache/datafusion/pull/16014#discussion_r2129798435
##
datafusion/proto/src/physical_plan/to_proto.rs:
##
@@ -506,7 +506,7 @@ pub fn serialize_file_scan_config(
.iter()
.cloned()
.collect
andygrove commented on PR #1830:
URL:
https://github.com/apache/datafusion-comet/pull/1830#issuecomment-2945620138
The Spark version will also need to be updated in
`.github/workflows/spark_sql_test_ansi.yml`
--
This is an automated message from the Apache Git Service.
To respond to the
adriangb commented on PR #16264:
URL: https://github.com/apache/datafusion/pull/16264#issuecomment-2945617720
Worked!! Sweet. Thank you Andrew (for the fix and nudge).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
adriangb merged PR #16264:
URL: https://github.com/apache/datafusion/pull/16264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
adriangb commented on PR #16264:
URL: https://github.com/apache/datafusion/pull/16264#issuecomment-2945616545
Ah I was waiting for the email but in reality I just missed it 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
alamb commented on issue #15771:
URL: https://github.com/apache/datafusion/issues/15771#issuecomment-2945615819
> I would also like to include
https://github.com/apache/datafusion/pull/16256
Merged!
--
This is an automated message from the Apache Git Service.
To respond to the message,
alamb merged PR #16183:
URL: https://github.com/apache/datafusion/pull/16183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16183:
URL: https://github.com/apache/datafusion/pull/16183#issuecomment-2945612836
Thank you for the review @2010YOUY01
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
GitHub user timsaucer added a comment to the discussion: DISCUSSION: DataFusion
Meetup in New York, NY, USA
I am interested in attending and there are a few topics I could present on,
depending on what time we have available.
GitHub link:
https://github.com/apache/datafusion/discussions/1626
alamb commented on code in PR #16183:
URL: https://github.com/apache/datafusion/pull/16183#discussion_r2129704959
##
.github/workflows/rust.yml:
##
@@ -476,6 +476,28 @@ jobs:
POSTGRES_HOST: postgres
POSTGRES_PORT: ${{ job.services.postgres.ports[5432] }}
alamb commented on PR #16195:
URL: https://github.com/apache/datafusion/pull/16195#issuecomment-2945581697
Let's wait to merge this PR until we ship DataFusion 48 to limit the
breaking changes
- #15771
I think we'll be able to merge this in the next few days
--
This is an autom
alamb commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2945599542
I merged up one more time to make sure the CI tests pass but assuming they
do I plan to merge this one in
--
This is an automated message from the Apache Git Service.
To respond to t
jonathanc-n commented on PR #16210:
URL: https://github.com/apache/datafusion/pull/16210#issuecomment-2945598547
@2010YOUY01 I was doing some benchmarks on NLJs vs. HJs and it looked bad
even for cases where one table is very small which is what NLJs should excel
at. One thing is to note th
andygrove merged PR #1848:
URL: https://github.com/apache/datafusion-comet/pull/1848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
alamb commented on PR #16264:
URL: https://github.com/apache/datafusion/pull/16264#issuecomment-2945558949
https://github.com/user-attachments/assets/ddaa3822-df51-44b0-ad00-6cd2503d894b";
/>
🤔 your github account doesn't seem to be linked to your apache account yet
so the checkmark
andygrove commented on PR #1848:
URL:
https://github.com/apache/datafusion-comet/pull/1848#issuecomment-2945589324
Thanks for the review @huaxingao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alamb commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2945576944
Thank you very much @m09526 for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alamb commented on PR #16264:
URL: https://github.com/apache/datafusion/pull/16264#issuecomment-2945549922
Thank you @adriangb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
andygrove commented on issue #1820:
URL:
https://github.com/apache/datafusion-comet/issues/1820#issuecomment-2945503093
Thanks @rishvin. I assigned the issue to you. Let me know if you have any
questions.
--
This is an automated message from the Apache Git Service.
To respond to the mess
rishvin commented on issue #1820:
URL:
https://github.com/apache/datafusion-comet/issues/1820#issuecomment-2945492404
@andygrove I can work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
andygrove commented on PR #1736:
URL:
https://github.com/apache/datafusion-comet/pull/1736#issuecomment-2945396822
Current failures:
core1:
```
2025-06-05T16:40:13.0938574Z [info] - avoid reordering broadcast join keys
to match input hash partitioning *** FAILED *** (2 seco
Dandandan commented on PR #15591:
URL: https://github.com/apache/datafusion/pull/15591#issuecomment-2945391975
thanks @Rachelint and congratulations!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
timsaucer opened a new issue, #1142:
URL: https://github.com/apache/datafusion-python/issues/1142
## Background
Right now in the python interface the catalog provider is mostly not useful.
We have a PR incoming that will change that. The issue I see is that in
datafusion core reposit
alamb commented on PR #16069:
URL: https://github.com/apache/datafusion/pull/16069#issuecomment-2945338342
This PR caused a minor issue when testing an upgrade. Here is a proposed fix:
- https://github.com/apache/datafusion/pull/16264
--
This is an automated message from the Apache Git
alamb opened a new pull request, #16264:
URL: https://github.com/apache/datafusion/pull/16264
## Which issue does this PR close?
- Found while testing https://github.com/delta-io/delta-rs/pull/3520
- Related to #15771
## Rationale for this change
While testing the Dat
alamb commented on issue #15771:
URL: https://github.com/apache/datafusion/issues/15771#issuecomment-2945310225
I started testing with delta.rs:
https://github.com/delta-io/delta-rs/pull/3520
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Luigi6821 opened a new issue, #1875:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1875
Hi all,
I am writing you after @TylerBrinks suggested me to open a discussion on the
issue mentioned in title.
Basically I am using the C# porting version of Rust one (thanks Tyler)
alamb opened a new pull request, #16263:
URL: https://github.com/apache/datafusion/pull/16263
## Which issue does this PR close?
- Related to https://github.com/delta-io/delta-rs/pull/3521
## Rationale for this change
While testing a DataFusion upgrade in delta.rs I found
andygrove commented on code in PR #1851:
URL: https://github.com/apache/datafusion-comet/pull/1851#discussion_r2129233751
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1394,10 +1394,10 @@ class CometExpressionSuite extends CometTestBase with
Adapti
ozankabak commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2945161909
I will be traveling tomorrow, but myself and @berkaysynnada will help drive
this to completion early next week. I made some progress on sketching out a
good API and will circle bac
pepijnve commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2945139509
Changing hats to DataFusion user mode where I need to make sure that the end
users of our system can press 'cancel' at any time and that works as expected.
From that perspecti
blaginin merged PR #15871:
URL: https://github.com/apache/datafusion/pull/15871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
blaginin closed issue #258: Improve performance of COUNT (distinct x) for
dictionary columns
URL: https://github.com/apache/datafusion/issues/258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on PR #16251:
URL: https://github.com/apache/datafusion/pull/16251#issuecomment-2945038255
> Thank you @alamb , is it possible for --complete also generate substring
which matches in CI?
Yes, the question is what is the most important substring 🤔
Maybe just the
blaginin commented on code in PR #16258:
URL: https://github.com/apache/datafusion/pull/16258#discussion_r2129123740
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -5030,6 +5030,20 @@ select count(distinct column1), count(distinct column2)
from dict_test group by
s
pepijnve opened a new pull request, #16262:
URL: https://github.com/apache/datafusion/pull/16262
## Which issue does this PR close?
- No issue created yet, related to PR #16196.
## Rationale for this change
The current benchmark comparison script compares
andygrove opened a new issue, #1852:
URL: https://github.com/apache/datafusion-comet/issues/1852
### What is the problem the feature request solves?
The following tests in WholeStageCodegenSuite currently pass because we are
falling back to Spark, but they fail when they run natively
timsaucer commented on issue #581:
URL:
https://github.com/apache/datafusion-python/issues/581#issuecomment-2944981399
Can you give me a little more context about what you're trying to
accomplish? There is some discussion on this page about the difficulties with
sharing data between python
blaginin commented on PR #16258:
URL: https://github.com/apache/datafusion/pull/16258#issuecomment-2944973123
Thank you @kosiew! Do you mind also changing
https://github.com/apache/datafusion/pull/16232/files#diff-08d7a1f4d6a968c393a2a0f2a2f54118f38d6a29009ce31b261f3ca27a2d3396R733
and maki
zhuqi-lucas commented on PR #16251:
URL: https://github.com/apache/datafusion/pull/16251#issuecomment-2944937313
Thank you @alamb , is it possible for --complete also generate substring
which matches in CI?
--
This is an automated message from the Apache Git Service.
To respond to the me
codecov-commenter commented on PR #1851:
URL:
https://github.com/apache/datafusion-comet/pull/1851#issuecomment-2944850645
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1851?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove commented on PR #1851:
URL:
https://github.com/apache/datafusion-comet/pull/1851#issuecomment-2944836969
> oh yeah, here we go! lgtm thanks @andygrove
Thanks for the review @comphead. This was partly inspired by our
conversation yesterday.
We typically use `checkSpar
zhuqi-lucas commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2944834501
@ozankabak @pepijnve
Interesting, i have added interleave corner testing case
**test_infinite_interleave_agg_cancel** now which try to reproduce the corner
case, but it works
comphead commented on code in PR #1851:
URL: https://github.com/apache/datafusion-comet/pull/1851#discussion_r2129022559
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1394,10 +1394,10 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
andygrove commented on issue #581:
URL:
https://github.com/apache/datafusion-python/issues/581#issuecomment-2944796949
Perhaps @timsaucer can provide some guidance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
mara-schulke commented on issue #581:
URL:
https://github.com/apache/datafusion-python/issues/581#issuecomment-2944785439
Hi @andygrove, we are currently using `PyDataFrame` and would like to use it
to convert back to a `datafusion::DataFrame` do you have any information /
guidance on how
alamb commented on issue #6543:
URL: https://github.com/apache/datafusion/issues/6543#issuecomment-2944658229
> would it be correct to use statement visitors here to add unique aliases?
I think that is actually a pretty neat idea -- specifically add the aliases
in the SQL planner
alamb commented on PR #16195:
URL: https://github.com/apache/datafusion/pull/16195#issuecomment-2944619110
> > Should it target main or the 47 branch ?
>
> The `main` branch is the good one (I don't think the branch-47 is the most
recent release branch anyway)
yeah, let's targe
andygrove commented on code in PR #1851:
URL: https://github.com/apache/datafusion-comet/pull/1851#discussion_r2128955528
##
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##
@@ -399,12 +399,7 @@ class CometArrayExpressionSuite extends CometTestBase with
andygrove opened a new pull request, #1851:
URL: https://github.com/apache/datafusion-comet/pull/1851
## Which issue does this PR close?
N/A
## Rationale for this change
Improve testing and help prevent regressions
## What changes are included in th
alamb commented on PR #16251:
URL: https://github.com/apache/datafusion/pull/16251#issuecomment-2944591691
> I am confused why CI will not fail for this case, i remember some cases i
run locally to -- --complete, but the CI failed, so i add RUST_BACKTRACE to
generate.
I think sqllogi
pepijnve commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2944505070
> I feel like we are getting close to a point where we start having
not-so-fruitful discussions. I think I have made a good effort to make my
arguments and reasoning clear.
@
andygrove closed issue #16254: Inconsistency with count distinct on NaN values
URL: https://github.com/apache/datafusion/issues/16254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
HuyNguyen7994 commented on issue #1475:
URL:
https://github.com/apache/datafusion-sqlparser-rs/issues/1475#issuecomment-2944295472
@cisaacson I'm having the same problem. Turn out you want to visit
`SelectItem`:
https://github.com/HuyNguyen7994/datafusion-sqlparser-rs/tree/add-select-item-
1 - 100 of 146 matches
Mail list logo
