andygrove commented on PR #1851: URL: https://github.com/apache/datafusion-comet/pull/1851#issuecomment-2944836969
> oh yeah, here we go! lgtm thanks @andygrove Thanks for the review @comphead. This was partly inspired by our conversation yesterday. We typically use `checkSparkAnswer` when we expect part of the plan to fall back, but we should be adding assertions to check that the expected operators fall back. I guess we can continue improving the tests over time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
