blaginin commented on code in PR #16258:
URL: https://github.com/apache/datafusion/pull/16258#discussion_r2129123740
##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########
@@ -5030,6 +5030,20 @@ select count(distinct column1), count(distinct column2)
from dict_test group by
statement ok
drop table dict_test;
+## count distinct dictionary with null values
+statement ok
+create table dict_null_test as
+ select arrow_cast(NULL, 'Dictionary(Int32, Utf8)') as d
+ from (values (1), (2), (3), (4), (5));
+
+query I
+select count(distinct d) from dict_null_test;
+----
+0
Review Comment:
I think this passes on main currently
```sql
DataFusion CLI v48.0.0
> create table dict_null_test as
select arrow_cast(NULL, 'Dictionary(Int32, Utf8)') as d
from (values (1), (2), (3), (4), (5));
0 row(s) fetched.
Elapsed 0.024 seconds.
> select count(distinct d) from dict_null_test;
+----------------------------------+
| count(DISTINCT dict_null_test.d) |
+----------------------------------+
| 0 |
+----------------------------------+
1 row(s) fetched.
Elapsed 0.016 seconds.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
