andygrove commented on code in PR #1851: URL: https://github.com/apache/datafusion-comet/pull/1851#discussion_r2129233751
########## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ########## @@ -1394,10 +1394,10 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper { checkSparkAnswerAndOperator( s"select round(cast(${n} as decimal(20, 0)), ${s}) FROM tbl") } - // checkSparkAnswer(s"select round(double('infinity'), ${s}) FROM tbl") - // checkSparkAnswer(s"select round(double('-infinity'), ${s}) FROM tbl") - // checkSparkAnswer(s"select round(double('NaN'), ${s}) FROM tbl") - // checkSparkAnswer( + // checkSparkAnswerAndOperator(s"select round(double('infinity'), ${s}) FROM tbl") Review Comment: I didn't look into this since it was commented out. I actually reverted this change now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org