kosiew commented on code in PR #16258: URL: https://github.com/apache/datafusion/pull/16258#discussion_r2131413138
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -5030,6 +5030,20 @@ select count(distinct column1), count(distinct column2) from dict_test group by statement ok drop table dict_test; +## count distinct dictionary with null values +statement ok +create table dict_null_test as + select arrow_cast(NULL, 'Dictionary(Int32, Utf8)') as d + from (values (1), (2), (3), (4), (5)); + +query I +select count(distinct d) from dict_null_test; +---- +0 Review Comment: I was struggling with how to create the slt test. Thanks @jonathanc-n for letting me know that it's not possible. I added [regular tests](https://github.com/apache/datafusion/pull/16258/commits/3de7526a5afa980d3b37755815f8cf27d84b255d) instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
