jonathanc-n commented on code in PR #16258: URL: https://github.com/apache/datafusion/pull/16258#discussion_r2130695219
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -5030,6 +5030,20 @@ select count(distinct column1), count(distinct column2) from dict_test group by statement ok drop table dict_test; +## count distinct dictionary with null values +statement ok +create table dict_null_test as + select arrow_cast(NULL, 'Dictionary(Int32, Utf8)') as d + from (values (1), (2), (3), (4), (5)); + +query I +select count(distinct d) from dict_null_test; +---- +0 Review Comment: I don't think we can generate a slt test that would match this behaviour; I believe sql can't express the case where indices + values are separated the way they are as outlined in the issue. I think we should just have a regular non-slt test for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
