hendrikmakait commented on issue #16244:
URL: https://github.com/apache/datafusion/issues/16244#issuecomment-2938796964
I'd be interested in working on this, but I might need a little guidance
since I'm new to the project.
--
This is an automated message from the Apache Git Service.
To re
LucaCappelletti94 closed issue #1825: Library fails to parse function
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
suibianwanwank commented on code in PR #16234:
URL: https://github.com/apache/datafusion/pull/16234#discussion_r2125728466
##
datafusion/physical-expr/src/window/window_expr.rs:
##
@@ -186,6 +186,10 @@ pub trait AggregateWindowExpr: WindowExpr {
accumulator: &mut Box,
ding-young commented on code in PR #16182:
URL: https://github.com/apache/datafusion/pull/16182#discussion_r2125694455
##
benchmarks/src/util/run.rs:
##
@@ -138,6 +144,28 @@ impl BenchmarkRun {
}
}
+/// Print the names of failed queries, if any
+pub fn ma
chenkovsky commented on issue #16240:
URL: https://github.com/apache/datafusion/issues/16240#issuecomment-2938605350
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
niebayes commented on issue #16245:
URL: https://github.com/apache/datafusion/issues/16245#issuecomment-2938545089
@jonathanc-n Feel free to take this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jonathanc-n commented on issue #16245:
URL: https://github.com/apache/datafusion/issues/16245#issuecomment-2938425178
@niebayes Oh i see, do you want to take this up? if not i'd be interested in
doing it, i've been looking a lot into the join implementations recently.
--
This is an automa
2010YOUY01 commented on code in PR #16183:
URL: https://github.com/apache/datafusion/pull/16183#discussion_r2125481070
##
datafusion/sqllogictest/bin/sqllogictests.rs:
##
@@ -102,6 +103,11 @@ async fn run_tests() -> Result<()> {
// to stdout and return OK so they can co
xudong963 commented on issue #15771:
URL: https://github.com/apache/datafusion/issues/15771#issuecomment-2938210171
48.0.0 rc1 is ready: https://github.com/apache/datafusion/tree/48.0.0-rc1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
xudong963 merged PR #16214:
URL: https://github.com/apache/datafusion/pull/16214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
xudong963 merged PR #16238:
URL: https://github.com/apache/datafusion/pull/16238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
niebayes commented on issue #16245:
URL: https://github.com/apache/datafusion/issues/16245#issuecomment-2938190140
@jonathanc-n See:
https://datafusion.apache.org/user-guide/sql/select.html#join-clause
--
This is an automated message from the Apache Git Service.
To respond to the message,
zhuqi-lucas commented on PR #16243:
URL: https://github.com/apache/datafusion/pull/16243#issuecomment-2938172961
It looks like no performance improvement for h2o_window benchmark result...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
zhuqi-lucas commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2938168285
Thank you @pepijnve , since we have both POC for two ways:
1. Current PR unified solution, but one more exec (YieldStreamExec) exposed
to customers.
2. Original PR, insert
2010YOUY01 commented on code in PR #16234:
URL: https://github.com/apache/datafusion/pull/16234#discussion_r2125366399
##
datafusion/physical-expr/src/window/aggregate.rs:
##
@@ -85,6 +88,25 @@ impl PlainAggregateWindowExpr {
);
}
}
+
+// Returns t
comphead closed issue #1789: Support `map_values`
URL: https://github.com/apache/datafusion-comet/issues/1789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
github-actions[bot] closed pull request #14333: chore(deps): update rand
requirement from 0.8 to 0.9
URL: https://github.com/apache/datafusion/pull/14333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
codecov-commenter commented on PR #1841:
URL:
https://github.com/apache/datafusion-comet/pull/1841#issuecomment-2937902307
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1841?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
dependabot[bot] commented on PR #14333:
URL: https://github.com/apache/datafusion/pull/14333#issuecomment-2938080710
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version
xudong963 closed issue #16202: Consolidate schema adapter tests in
schema_adapter_integration_tests.rs
URL: https://github.com/apache/datafusion/issues/16202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
2010YOUY01 commented on PR #16192:
URL: https://github.com/apache/datafusion/pull/16192#issuecomment-2938019298
@ding-young I also think the code to manage `reservation` +
`merge_reservation` is tricky. I'll try to answer your questions by adding more
doc about memory reservation management
2010YOUY01 commented on issue #16244:
URL: https://github.com/apache/datafusion/issues/16244#issuecomment-2938068143
It's a good idea.
A quick reminder for someone who is willing to implement it: It's possible
that multiple `Array`s share the same underlying buffer -- those `Array`s c
2010YOUY01 commented on code in PR #16182:
URL: https://github.com/apache/datafusion/pull/16182#discussion_r2125283941
##
benchmarks/src/util/run.rs:
##
@@ -138,6 +144,28 @@ impl BenchmarkRun {
}
}
+/// Print the names of failed queries, if any
+pub fn ma
adamreeve commented on code in PR #16237:
URL: https://github.com/apache/datafusion/pull/16237#discussion_r2125251156
##
datafusion-examples/examples/parquet_encryption_with_kms.rs:
##
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more c
comphead commented on code in PR #16210:
URL: https://github.com/apache/datafusion/pull/16210#discussion_r2125246086
##
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##
@@ -1129,6 +1316,95 @@ pub(crate) mod tests {
)
}
+fn build_left_table_equijoin(
comphead commented on code in PR #16210:
URL: https://github.com/apache/datafusion/pull/16210#discussion_r2125235875
##
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##
@@ -810,6 +871,123 @@ fn build_join_indices(
}
}
+// Find matching indices based on join `on
corwinjoy commented on code in PR #16237:
URL: https://github.com/apache/datafusion/pull/16237#discussion_r2125241447
##
datafusion-examples/examples/parquet_encryption_with_kms.rs:
##
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more c
corwinjoy commented on code in PR #16237:
URL: https://github.com/apache/datafusion/pull/16237#discussion_r2125241447
##
datafusion-examples/examples/parquet_encryption_with_kms.rs:
##
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more c
andygrove closed pull request #1841: fix: Fix incorrect logic in CometExecRule
aggregate handling
URL: https://github.com/apache/datafusion-comet/pull/1841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
comphead merged PR #16246:
URL: https://github.com/apache/datafusion/pull/16246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
jonathanc-n opened a new pull request, #16246:
URL: https://github.com/apache/datafusion/pull/16246
## Which issue does this PR close?
- Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tes
jonathanc-n commented on issue #16245:
URL: https://github.com/apache/datafusion/issues/16245#issuecomment-2937909505
Are there any documented joins in the documentation? I might be missing it
but I dont seem to be able to find any.
--
This is an automated message from the Apache Git Serv
codecov-commenter commented on PR #1838:
URL:
https://github.com/apache/datafusion-comet/pull/1838#issuecomment-2937504058
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1838?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
niebayes opened a new issue, #16245:
URL: https://github.com/apache/datafusion/issues/16245
We support more join types, but only some are mentioned in the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
andygrove opened a new pull request, #1841:
URL: https://github.com/apache/datafusion-comet/pull/1841
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes
codecov-commenter commented on PR #1840:
URL:
https://github.com/apache/datafusion-comet/pull/1840#issuecomment-2937774481
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1840?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove opened a new pull request, #1840:
URL: https://github.com/apache/datafusion-comet/pull/1840
## Which issue does this PR close?
Part of https://github.com/apache/datafusion-comet/issues/1251
## Rationale for this change
Add test to Comet to reprod
comphead commented on issue #13433:
URL: https://github.com/apache/datafusion/issues/13433#issuecomment-2937667067
Crosslinking original `raw` feature deprecation from `hashbrown`
https://github.com/rust-lang/hashbrown/pull/546
--
This is an automated message from the Apache Git Service.
comphead merged PR #1835:
URL: https://github.com/apache/datafusion-comet/pull/1835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
comphead commented on issue #13433:
URL: https://github.com/apache/datafusion/issues/13433#issuecomment-2937672599
reg to PRs above I think it is agreed to replace `RawTable` with `HashTable`
across DataFusion?
--
This is an automated message from the Apache Git Service.
To respond to th
andygrove merged PR #1837:
URL: https://github.com/apache/datafusion-comet/pull/1837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
crystalxyz opened a new pull request, #1139:
URL: https://github.com/apache/datafusion-python/pull/1139
# Which issue does this PR close?
Closes #1138.
# Rationale for this change
CI should fail early if documentation generation fails.
# What changes are included in t
andygrove opened a new issue, #1839:
URL: https://github.com/apache/datafusion-comet/issues/1839
### Describe the bug
The test `SPARK-34637: DPP side broadcast query stage is created firstly`
passes when using native shuffle, but fails when using columnar shuffle.
### Steps to
rishvin commented on issue #1739:
URL:
https://github.com/apache/datafusion-comet/issues/1739#issuecomment-2937335355
Opened PR https://github.com/apache/datafusion-comet/pull/1838 to address
renaming tests in RemoveRedundantProjectsSuite.scala
--
This is an automated message from the Ap
MohamedAbdeen21 opened a new pull request, #1872:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1872
The `ONLY` keyword was previously applied to the entire stmt, the correct
psql behaviour is to apply the keyword per table.
--
This is an automated message from the Apache Gi
crystalxyz commented on issue #1138:
URL:
https://github.com/apache/datafusion-python/issues/1138#issuecomment-2937321444
I'll take it :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
krishvishal commented on code in PR #16203:
URL: https://github.com/apache/datafusion/pull/16203#discussion_r2124983624
##
datafusion/functions-nested/src/extract.rs:
##
@@ -225,44 +252,37 @@ where
return Ok(Arc::new(NullArray::new(array.len(;
}
+// Check
krishvishal commented on code in PR #16203:
URL: https://github.com/apache/datafusion/pull/16203#discussion_r2124983434
##
datafusion/functions-nested/src/extract.rs:
##
@@ -213,6 +213,33 @@ fn array_element_inner(args: &[ArrayRef]) ->
Result {
}
}
+/// Adjusts a 1-base
krishvishal commented on code in PR #16203:
URL: https://github.com/apache/datafusion/pull/16203#discussion_r2124973342
##
datafusion/functions-nested/src/extract.rs:
##
@@ -225,44 +252,37 @@ where
return Ok(Arc::new(NullArray::new(array.len(;
}
+// Check
krishvishal commented on code in PR #16203:
URL: https://github.com/apache/datafusion/pull/16203#discussion_r2124973342
##
datafusion/functions-nested/src/extract.rs:
##
@@ -225,44 +252,37 @@ where
return Ok(Arc::new(NullArray::new(array.len(;
}
+// Check
comphead commented on code in PR #16203:
URL: https://github.com/apache/datafusion/pull/16203#discussion_r2124970073
##
datafusion/functions-nested/src/extract.rs:
##
@@ -225,44 +252,37 @@ where
return Ok(Arc::new(NullArray::new(array.len(;
}
+// Check if
krishvishal commented on code in PR #16203:
URL: https://github.com/apache/datafusion/pull/16203#discussion_r2124965299
##
datafusion/functions-nested/src/extract.rs:
##
@@ -225,44 +252,37 @@ where
return Ok(Arc::new(NullArray::new(array.len(;
}
+// Check
rishvin opened a new pull request, #1838:
URL: https://github.com/apache/datafusion-comet/pull/1838
## Which issue does this PR close?
Addresses #1739
## Rationale for this change
Enables tests in `RemoveRedundantProjectsSuite.scala` related to #242. The
Com
comphead commented on code in PR #16203:
URL: https://github.com/apache/datafusion/pull/16203#discussion_r2124930746
##
datafusion/functions-nested/src/extract.rs:
##
@@ -213,6 +213,33 @@ fn array_element_inner(args: &[ArrayRef]) ->
Result {
}
}
+/// Adjusts a 1-based a
comphead commented on code in PR #16203:
URL: https://github.com/apache/datafusion/pull/16203#discussion_r212493
##
datafusion/functions-nested/src/extract.rs:
##
@@ -225,44 +252,37 @@ where
return Ok(Arc::new(NullArray::new(array.len(;
}
+// Check if
krishvishal commented on PR #16203:
URL: https://github.com/apache/datafusion/pull/16203#issuecomment-2937158972
@comphead I've had to add the handler because the previous fix caused wrong
behavior.
For example the following query currently returns:
```sql
> select [named_st
mbutrovich opened a new pull request, #1837:
URL: https://github.com/apache/datafusion-comet/pull/1837
## Which issue does this PR close?
Partially addresses #1542.
## Rationale for this change
## What changes are included in this PR?
Update
MohamedAbdeen21 opened a new pull request, #1870:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1870
Add support for MySQL's `[[NOT] ENFORCED]` option for CHECK constraints.
docs: https://dev.mysql.com/doc/refman/8.4/en/create-table.html
--
This is an automated message
comphead commented on PR #16203:
URL: https://github.com/apache/datafusion/pull/16203#issuecomment-2936960243
Thanks @krishvishal the latest version becomes much more complicated
compared to prev one. This can be a subject to check the performance.
What is the reason for adding the sp
codecov-commenter commented on PR #1837:
URL:
https://github.com/apache/datafusion-comet/pull/1837#issuecomment-2936987610
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1837?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
timsaucer closed pull request #16053: feat: add metadata to physical literal
expressions
URL: https://github.com/apache/datafusion/pull/16053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
milenkovicm commented on issue #1268:
URL:
https://github.com/apache/datafusion-ballista/issues/1268#issuecomment-2936939066
Let me know if you need more help @janbraunsdorff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
MohamedAbdeen21 opened a new pull request, #1871:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1871
Add support for `index_name` field in FK constraints in both CREATE and
ALTER TABLE statements
docs: https://dev.mysql.com/doc/refman/8.4/en/create-table-foreign-keys.htm
andygrove commented on issue #1254:
URL:
https://github.com/apache/datafusion-comet/issues/1254#issuecomment-2936747407
> Barring AQE and DPP tets ( addressed in a different PR
[#1811](https://github.com/apache/datafusion-comet/pull/1811) ) , I am able to
run these tests successfully . Not
milenkovicm commented on issue #1268:
URL:
https://github.com/apache/datafusion-ballista/issues/1268#issuecomment-2936706643
As noted in #1241 there is no out of the built in support for `deltalake`
file format, it's up to users to integrate it if needed.
I have updated https://githu
milenkovicm closed issue #1268: Access Data from S3 in DeltaLake format using
Ballista on Kubernetes
URL: https://github.com/apache/datafusion-ballista/issues/1268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alamb commented on PR #16243:
URL: https://github.com/apache/datafusion/pull/16243#issuecomment-2936699578
🤖: Benchmark completed
Details
```
Comparing HEAD and default_utf8_for_unkown_type
Benchmark h2o_window.json
alamb commented on PR #16243:
URL: https://github.com/apache/datafusion/pull/16243#issuecomment-2936634009
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun
andygrove merged PR #1826:
URL: https://github.com/apache/datafusion-comet/pull/1826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
kazantsev-maksim commented on PR #1826:
URL:
https://github.com/apache/datafusion-comet/pull/1826#issuecomment-2936605214
Thanks @andygrove!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
ding-young commented on PR #16192:
URL: https://github.com/apache/datafusion/pull/16192#issuecomment-2936483760
@2010YOUY01
Hi, I’ve been struggling a bit with tracking peak memory in SPM step, and I
was wondering if I could ask for some help.
### 1. Can we add the memory for conv
parthchandra merged PR #1832:
URL: https://github.com/apache/datafusion-comet/pull/1832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
huaxingao commented on code in PR #1830:
URL: https://github.com/apache/datafusion-comet/pull/1830#discussion_r2124462679
##
spark/src/main/spark-3.5/org/apache/spark/sql/comet/shims/ShimCometTPCDSMicroBenchmark.scala:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software
mbutrovich commented on PR #1837:
URL:
https://github.com/apache/datafusion-comet/pull/1837#issuecomment-2936363015
Draft while I do 3.4.3, 3.5.4, and 4.0.0-preview1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
viirya commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2124440817
##
datafusion/physical-expr-common/src/sort_expr.rs:
##
@@ -516,162 +460,240 @@ impl Display for LexOrdering {
}
}
-impl FromIterator for LexOrdering {
-
viirya commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2124418429
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -845,7 +840,7 @@ pub struct SortExec {
/// Fetch highest/lowest n results
fetch: Option,
/// Nor
timsaucer commented on PR #16053:
URL: https://github.com/apache/datafusion/pull/16053#issuecomment-2936285535
Closing in favor of https://github.com/apache/datafusion/pull/16170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
viirya commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2124399512
##
datafusion/sqllogictest/test_files/topk.slt:
##
@@ -370,7 +370,7 @@ query TT
explain select number, letter, age, number as column4, letter as column5 from
part
viirya commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2124375915
##
datafusion/physical-expr/src/equivalence/properties/mod.rs:
##
@@ -190,382 +241,363 @@ impl EquivalenceProperties {
&self.oeq_class
}
-/// Re
alamb commented on PR #15980:
URL: https://github.com/apache/datafusion/pull/15980#issuecomment-2936183106
Marking as draft as I think this PR is no longer waiting on feedback and I
am trying to make it easier to find PRs in need of review. Please mark it as
ready for review when it is read
andygrove merged PR #1821:
URL: https://github.com/apache/datafusion-comet/pull/1821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
pepijnve commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2936193853
@zhuqi-lucas great work. I've continued playing around with alternative
structures in the meantime, but I keep coming back to your `YieldStream` as the
most elegant solution. It's s
viirya commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2124345816
##
datafusion/catalog/src/listing_schema.rs:
##
@@ -143,7 +141,7 @@ impl ListingSchemaProvider {
order_exprs: vec![],
viirya commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2124345816
##
datafusion/catalog/src/listing_schema.rs:
##
@@ -143,7 +141,7 @@ impl ListingSchemaProvider {
order_exprs: vec![],
alamb commented on PR #16234:
URL: https://github.com/apache/datafusion/pull/16234#issuecomment-2936100737
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun
jonathanc-n commented on PR #16234:
URL: https://github.com/apache/datafusion/pull/16234#issuecomment-2936099509
Those benchmarks look nice, seems to have been skewed on my computer for the
other queries.
--
This is an automated message from the Apache Git Service.
To respond to the messa
alamb commented on PR #16234:
URL: https://github.com/apache/datafusion/pull/16234#issuecomment-2936099164
> │ QQuery 1 │ 1873.46ms │335.27ms │ +5.59x faster │
Quite nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
PokIsemaine opened a new issue, #16244:
URL: https://github.com/apache/datafusion/issues/16244
### Is your feature request related to a problem or challenge?
Currently, using `Explain Analyze` seems to only provide the metric for
`output_rows`. Is it possible to add a metric for the n
zhuqi-lucas commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2936001738
Finally, the CI greens again, i think i fixed all testing cases. Next steps
is:
1. Update the solution for the corner cases.
2. Adding performance benchmark result.
--
Th
andygrove opened a new issue, #1836:
URL: https://github.com/apache/datafusion-comet/issues/1836
### What is the problem the feature request solves?
As pointed out in
https://github.com/apache/datafusion-comet/pull/1793#issuecomment-2916690342,
we currently always wrap ScanExec in a
alamb commented on PR #16234:
URL: https://github.com/apache/datafusion/pull/16234#issuecomment-2935960865
🤖: Benchmark completed
Details
```
Comparing HEAD and constant_agg_window
Benchmark h2o_window.json
┏━━
andygrove commented on code in PR #1747:
URL: https://github.com/apache/datafusion-comet/pull/1747#discussion_r2124216384
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -93,21 +93,63 @@ case class CometScanRule(session: SparkSession) extends
Rule[Spar
andygrove commented on code in PR #1747:
URL: https://github.com/apache/datafusion-comet/pull/1747#discussion_r2124215025
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -93,21 +93,63 @@ case class CometScanRule(session: SparkSession) extends
Rule[Spar
andygrove commented on PR #1747:
URL:
https://github.com/apache/datafusion-comet/pull/1747#issuecomment-2935920067
@parthchandra @mbutrovich Could I get a review? I changed the scope to
adding the "auto" option without changing the default. There is a manual
workflow where we can run the S
andygrove closed issue #1831: Enabling Test "Runtime bloom filter join: do not
add bloom filter if dpp filter exists on the same column" fails with
IllegalStateException in AdaptiveSparkPlanExec.newQueryStage
URL: https://github.com/apache/datafusion-comet/issues/1831
--
This is an automated
andygrove merged PR #1834:
URL: https://github.com/apache/datafusion-comet/pull/1834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
codecov-commenter commented on PR #1835:
URL:
https://github.com/apache/datafusion-comet/pull/1835#issuecomment-2935878217
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1835?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
alamb commented on PR #16234:
URL: https://github.com/apache/datafusion/pull/16234#issuecomment-2935875381
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun
alamb commented on PR #14837:
URL: https://github.com/apache/datafusion/pull/14837#issuecomment-2935875166
🤖: Benchmark completed
Details
```
group epic_async-udf
main
-
snmvaughan commented on issue #1833:
URL:
https://github.com/apache/datafusion-comet/issues/1833#issuecomment-2935873947
If it isn't going to be relocated, I'd suggest we shadow those dependencies
and allow Maven's dependency management handle the things
--
This is an automated message f
1 - 100 of 166 matches
Mail list logo
