2010YOUY01 commented on code in PR #16183:
URL: https://github.com/apache/datafusion/pull/16183#discussion_r2125481070
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -102,6 +103,11 @@ async fn run_tests() -> Result<()> {
// to stdout and return OK so they can continue listing other tests.
return Ok(());
}
+ if options.substrait_round_trip && (options.postgres_runner ||
options.complete) {
Review Comment:
This might be helpful. We can perform those compatibility tests within
option declarations.
https://docs.rs/clap/latest/clap/struct.ArgGroup.html#method.conflicts_with
##########
datafusion/sqllogictest/README.md:
##########
@@ -291,6 +291,27 @@ Tests that need to write temporary files should write
(only) to this
directory to ensure they do not interfere with others concurrently
running tests.
+## Running tests: Substrait round-trip mode
+
+This mode will run all the .slt test files in validation mode, adding a
Substrait conversion round-trip for each
+generated DataFusion logical plan (SQL statement → DF logical → Substrait → DF
logical → DF physical → execute).
+
+Not all statements will be round-tripped, some statements like CREATE, INSERT,
SET or EXPLAIN statements will be
+issued as is, but any other statement will be round-tripped to/from Substrait.
+
+_WARNING_: as there are still a lot of failures in this mode, it is not
enforced in the CI, instead, it needs
Review Comment:
I recommend to open a tracking issue, and add the link here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
