viirya commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2124418429
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -845,7 +840,7 @@ pub struct SortExec {
/// Fetch highest/lowest n results
fetch: Option<usize>,
/// Normalized common sort prefix between the input and the sort
expressions (only used with fetch)
- common_sort_prefix: LexOrdering,
+ common_sort_prefix: Vec<PhysicalSortExpr>,
Review Comment:
`ExternalSorter`'s `expr` is changed from `PhysicalSortExpr`s to
`LexOrdering`, but this changes from `LexOrdering`s to `PhysicalSortExpr`s. Can
you clarify the reason? Why not having a consistent representation for sort
expressions?
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -845,7 +840,7 @@ pub struct SortExec {
/// Fetch highest/lowest n results
fetch: Option<usize>,
/// Normalized common sort prefix between the input and the sort
expressions (only used with fetch)
- common_sort_prefix: LexOrdering,
+ common_sort_prefix: Vec<PhysicalSortExpr>,
Review Comment:
`ExternalSorter`'s `expr` is changed from `PhysicalSortExpr`s to
`LexOrdering`, but this changes from `LexOrdering` to `PhysicalSortExpr`s. Can
you clarify the reason? Why not having a consistent representation for sort
expressions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
