suibianwanwank commented on code in PR #16234: URL: https://github.com/apache/datafusion/pull/16234#discussion_r2125728466
########## datafusion/physical-expr/src/window/window_expr.rs: ########## @@ -186,6 +186,10 @@ pub trait AggregateWindowExpr: WindowExpr { accumulator: &mut Box<dyn Accumulator>, ) -> Result<ScalarValue>; + /// Indicates whether this window function always produces the same result + /// for all rows in the partition. + fn is_constant(&self) -> bool; Review Comment: Good point, I'll address it a bit later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org