viirya commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2124399512


##########
datafusion/sqllogictest/test_files/topk.slt:
##########
@@ -370,7 +370,7 @@ query TT
 explain select number, letter, age, number as column4, letter as column5 from 
partial_sorted order by number desc, column4 desc, letter asc, column5 asc, age 
desc limit 3;
 ----
 physical_plan
-01)SortExec: TopK(fetch=3), expr=[number@0 DESC, column4@3 DESC, letter@1 ASC 
NULLS LAST, column5@4 ASC NULLS LAST, age@2 DESC], 
preserve_partitioning=[false], sort_prefix=[number@0 DESC, letter@1 ASC NULLS 
LAST]
+01)SortExec: TopK(fetch=3), expr=[number@0 DESC, letter@1 ASC NULLS LAST, 
age@2 DESC], preserve_partitioning=[false], sort_prefix=[number@0 DESC, 
letter@1 ASC NULLS LAST]

Review Comment:
   So wondering why the previous one doesn't do what the comment said.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to