Re: [PR] Improve performance of constant aggregate window expression [datafusion]

Tue, 03 Jun 2025 08:25:50 -0700 


alamb commented on PR #16234:
URL: https://github.com/apache/datafusion/pull/16234#issuecomment-2935960865

   ๐Ÿค–: Benchmark completed
   
   <details><summary>Details</summary>
   <p>
   
   
   ```
   Comparing HEAD and constant_agg_window
   --------------------
   Benchmark h2o_window.json
   --------------------
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Query        โ”ƒ       HEAD โ”ƒ constant_agg_window โ”ƒ        Change โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ QQuery 1     โ”‚  1873.46ms โ”‚            335.27ms โ”‚ +5.59x faster โ”‚
   โ”‚ QQuery 2     โ”‚  3470.24ms โ”‚           3437.67ms โ”‚     no change โ”‚
   โ”‚ QQuery 3     โ”‚  3803.69ms โ”‚           3677.12ms โ”‚     no change โ”‚
   โ”‚ QQuery 4     โ”‚   997.60ms โ”‚            958.41ms โ”‚     no change โ”‚
   โ”‚ QQuery 5     โ”‚  2284.09ms โ”‚           2326.52ms โ”‚     no change โ”‚
   โ”‚ QQuery 6     โ”‚  3003.38ms โ”‚           3024.87ms โ”‚     no change โ”‚
   โ”‚ QQuery 7     โ”‚  2920.74ms โ”‚           2988.71ms โ”‚     no change โ”‚
   โ”‚ QQuery 8     โ”‚ 11458.37ms โ”‚          11838.48ms โ”‚     no change โ”‚
   โ”‚ QQuery 9     โ”‚   863.68ms โ”‚            852.94ms โ”‚     no change โ”‚
   โ”‚ QQuery 10    โ”‚   914.87ms โ”‚            922.66ms โ”‚     no change โ”‚
   โ”‚ QQuery 11    โ”‚   942.20ms โ”‚            926.73ms โ”‚     no change โ”‚
   โ”‚ QQuery 12    โ”‚  1790.66ms โ”‚           1804.70ms โ”‚     no change โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Benchmark Summary                  โ”ƒ            โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Total Time (HEAD)                  โ”‚ 34322.98ms โ”‚
   โ”‚ Total Time (constant_agg_window)   โ”‚ 33094.07ms โ”‚
   โ”‚ Average Time (HEAD)                โ”‚  2860.25ms โ”‚
   โ”‚ Average Time (constant_agg_window) โ”‚  2757.84ms โ”‚
   โ”‚ Queries Faster                     โ”‚          1 โ”‚
   โ”‚ Queries Slower                     โ”‚          0 โ”‚
   โ”‚ Queries with No Change             โ”‚         11 โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   ```
   
   
   </p>
   </details>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to