2010YOUY01 commented on code in PR #16182:
URL: https://github.com/apache/datafusion/pull/16182#discussion_r2125283941
##########
benchmarks/src/util/run.rs:
##########
@@ -138,6 +144,28 @@ impl BenchmarkRun {
}
}
+ /// Print the names of failed queries, if any
+ pub fn maybe_print_failures(&self) {
+ let failed_queries: Vec<&str> = self
+ .queries
+ .iter()
+ .filter_map(|q| (!q.success).then_some(q.query.as_str()))
+ .collect();
+
+ if !failed_queries.is_empty() {
+ println!("Failed Queries: {}", failed_queries.join(", "));
+ }
+ }
+
+ /// Mark current query
+ pub fn mark_failed(&mut self) {
+ if let Some(idx) = self.current_case {
+ self.queries[idx].success = false;
+ } else {
+ panic!("Cannot mark failure: no current case");
Review Comment:
```suggestion
unreachable!("Cannot mark failure: no current case");
```
`panic` usually is used for errors that are possible but unrecoverable.
`unreachable` is better for this case (just an assertion, logically impossible
to happen)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
