Re: [PATCH, FT32] initial support

2015-04-28 Thread Jeff Law
On 03/19/2015 09:28 AM, James Bowman wrote: Second ping. Also, have attached updated patchset for the current gcc. Thanks. Thanks. I don't see anything particularly worrisome from a correctness standpoint. You may need to make minor updates to your .h file to cope with some of Trevor's work a

Re: Refactor gcc/tree-vectorize.c:vectorize_loops

2015-04-28 Thread Jeff Law
On 04/28/2015 08:20 PM, Aditya K wrote: Hi, This is a small patch where I moved a portion of code from the function vectorize_loops outside to improve readability. Please see the patch attached and give comments for improvements. You need to add a comment for the new function. These function co

Re: [PATCH] Remove some restrictions on loop shape in tree-if-conv.c

2015-04-28 Thread Jeff Law
On 04/28/2015 07:55 AM, Alan Lawrence wrote: Tree if-conversion currently bails out for loops that (a) contain nested loops; (b) have more than one exit; (c) where the exit block (source of the exit edge) does not dominate the loop latch; (d) where the exit block is the loop header, or there are

Re: [Patch/rtl-expand] Take tree range info into account to improve LSHIFT_EXP expanding

2015-04-28 Thread Jeff Law
On 04/27/2015 02:21 PM, Jiong Wang wrote: Funny, I find myself wanting this transformation in both places :-) Expansion time so that we generate efficient code from the start and combine to catch those cases which are too complex to see at expansion, but due to other optimizations become visible

Re: [PR64164] drop copyrename, integrate into expand

2015-04-28 Thread Jeff Law
On 04/23/2015 07:56 PM, Alexandre Oliva wrote: The other tricky bit was to fix all expander bits that required SSA_NAMEs to have a associated decl. I've removed all such cases, so we can now expand anonymous SSA decls directly, without having to create an ignored decl. Doing that, we can coale

Re: C PATCH to reject va_arg (ap, void) (PR c/65901)

2015-04-28 Thread Martin Sebor
On 04/27/2015 11:30 AM, Marek Polacek wrote: As reported in the PR, va_arg (ap, void) probably doesn't make any sense and should be rejected thus. cc1plus and clang reject va_arg with an incomplete type. This patch makes cc1 reject it as well. Bootstrapped/regtested on x86_64-linux, ok for tru

Re: Fix librayr name of __builtin_allocal_with_align

2015-04-28 Thread Jan Hubicka
> On 04/27/2015 02:31 AM, Jan Hubicka wrote: > >Hi, > >build_common_builtin_nodes declares both __builtin_alloca and > >__builtin_alloca_with_align to have library name "alloca". This actually > >triggers warning in an updated ODR violation detector on "alloca" being > >declared twice. > > > >__bui

Refactor gcc/tree-vectorize.c:vectorize_loops

2015-04-28 Thread Aditya K
Hi, This is a small patch where I moved a portion of code from the function vectorize_loops outside to improve readability. Please see the patch attached and give comments for improvements. Thanks -Aditya refactor-vect Description: Binary data

Re: Bare bones of type verifier

2015-04-28 Thread Jan Hubicka
> >though. > > + if (((TREE_CODE (t) == ENUMERAL_TYPE && COMPLETE_TYPE_P (t)) > + || TREE_CODE (t) == INTEGER_TYPE > + || TREE_CODE (t) == BOOLEAN_TYPE > + || TREE_CODE (t) == REAL_TYPE > + || TREE_CODE (t) == FIXED_POINT_TYPE) > + && (TYPE_MAX_VALUE (t) != TYPE_MAX_VALUE (tv) > +

Re: [PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2015-04-28 Thread Josh Triplett
On Tue, Apr 28, 2015 at 06:10:33PM -0600, Jeff Law wrote: > On 04/26/2015 07:09 PM, Josh Triplett wrote: > >handle_section_attribute contains many levels of nested conditionals and > >branching code flow paths, with the error cases sometimes in the else > >case and sometimes in the if case. Simpli

[debug-early] gut out check_die

2015-04-28 Thread Aldy Hernandez
Remove the bits of the checking code that have never found anything useful in the last few months of work. Plus, they're timing out on big test cases. I'm removing them, as they were never meant to go into production. Committed to branch. Aldy commit e6b1a0f8433ad2d72bd23d4d5def127431e22452

[patch] Rewrite check_global_declarations() generically

2015-04-28 Thread Aldy Hernandez
[This is actually for the debug-early branch, but I figured I'd avoid the [debug-early] subject line to alert others of the upcoming change. Actually, I should've adapted this and submitted it to mainline, but considering I should be submitting the debug-early work "Real Soon Now" (tm), I don't

Re: [PATCH][AARCH64]Add ACLE 2.0 predefined macros: __ARM_ALIGN_MAX_PWR and __ARM_ALIGN_MAX_STACK_PWR

2015-04-28 Thread Andrew Pinski
On Tue, Dec 16, 2014 at 2:19 AM, Renlin Li wrote: > Hi all, > > This is a simple patch to add another two ACLE 2.0 predefined macros into > aarch64 backend. > They are __ARM_ALIGN_MAX_PWR and __ARM_ALIGN_MAX_STACK_PWR. Currently, those > two values are hard-wired to 16. > > The following clauses f

Re: [PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2015-04-28 Thread Jeff Law
On 04/26/2015 07:09 PM, Josh Triplett wrote: handle_section_attribute contains many levels of nested conditionals and branching code flow paths, with the error cases sometimes in the else case and sometimes in the if case. Simplify the code flow into a series of potential failure cases ending wi

Re: [PATCH 3/3] Fix indentation issues seen by -Wmisleading-indentation

2015-04-28 Thread Jeff Law
On 04/28/2015 06:02 PM, David Malcolm wrote: This patch fixes the places in our tree where -Wmisleading-indentation correctly identifies code that's misleadingly indented. In particular, a couple of places in gcc/cp/parser.c:cp_parser_asm_definition appeared to be missing braces, both of the

Re: [PATCH 2/3] Fix spurious semicolons

2015-04-28 Thread Jeff Law
On 04/28/2015 06:02 PM, David Malcolm wrote: An earlier version of the -Wmisleading-indentation patch issued warnings for spurious trailing semicolons guarded by a conditional. Although the latest version of -Wmisleading-indentation no longer warns about these, I fixed the ones that were reporte

Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-04-28 Thread Jeff Law
On 04/27/2015 02:09 PM, Mikhail Maltsev wrote: I'm sending an updated patch (rebased to recent trunk, bootstrapped and regtested on x86_64-unknown-linux-gnu). [ ... ] -- Regards, Mikhail Maltsev as_insn2.patch Needs a ChangeLog. I know it's a bit tedious... But please include it. It ma

[PATCH 3/3] Fix indentation issues seen by -Wmisleading-indentation

2015-04-28 Thread David Malcolm
This patch fixes the places in our tree where -Wmisleading-indentation correctly identifies code that's misleadingly indented. In particular, a couple of places in gcc/cp/parser.c:cp_parser_asm_definition appeared to be missing braces, both of the form: if (complicated_multiline_condition ())

[PATCH 2/3] Fix spurious semicolons

2015-04-28 Thread David Malcolm
An earlier version of the -Wmisleading-indentation patch issued warnings for spurious trailing semicolons guarded by a conditional. Although the latest version of -Wmisleading-indentation no longer warns about these, I fixed the ones that were reported, thusly. gcc/ChangeLog: * builtins.c

[PATCH 1/3] Implement -Wmisleading-indentation (v4)

2015-04-28 Thread David Malcolm
This is an updated implementation of the proposed -Wmisleading-indentation warning. Changes since last patch: * I've rewritten it to use Manuel's approach from https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01225.html I took Manuel's proposed patch for the C frontend and generalized it to

Re: [PATCH 2/13] musl libc config

2015-04-28 Thread Joseph Myers
On Mon, 20 Apr 2015, Szabolcs Nagy wrote: > * config/linux.opt (mmusl): New option. New -m options need documenting in invoke.texi. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH 0/13] Add musl support to GCC

2015-04-28 Thread Joseph Myers
On Mon, 20 Apr 2015, Szabolcs Nagy wrote: > * On powerpc it seems the only configure option to choose the default > long-double abi is --with-long-double-128, but that's the default with > sufficiently new glibc. (musl gets 64bit long-double because the glibc > version check fails, this is ok, bec

Re: PR65217.c, improve canonicalization of implied copy from equality comparison

2015-04-28 Thread Jeff Law
On 04/28/2015 01:15 AM, Marek Polacek wrote: On Mon, Apr 27, 2015 at 10:07:46PM -0600, Jeff Law wrote: Thanks for the nice summary in the first part of the mail. Two typos: + /* Most of the time tree_swap_operands_p does what we want. But there's Shouldn't that be "there are"? + cas

Re: [PATCH][AArch64] Fix libstdc++ ABI baseline for aarch64-linux-gnu

2015-04-28 Thread Joseph Myers
On Mon, 20 Apr 2015, Jakub Jelinek wrote: > If you want to do anything about it, instead hack up the ABI list checker, > so that for configurations with disabled TLS it ignores TLS symbols in the > ABI list, then they can be added on all architectures. Is anyone actually using current GCC for non

Re: Mostly rewrite genrecog

2015-04-28 Thread Jeff Law
On 04/27/2015 04:20 AM, Richard Sandiford wrote: I think it's been the case for a while that parallel builds of GCC tend to serialise around the compilation of insn-recog.c, especially with higher --enable-checking settings. This patch tries to speed that up by replacing most of genrecog with a

Re: Fix librayr name of __builtin_allocal_with_align

2015-04-28 Thread Jeff Law
On 04/27/2015 02:31 AM, Jan Hubicka wrote: Hi, build_common_builtin_nodes declares both __builtin_alloca and __builtin_alloca_with_align to have library name "alloca". This actually triggers warning in an updated ODR violation detector on "alloca" being declared twice. __builtin_alloca_with_alig

Re: [C++ Patch] PR 59729

2015-04-28 Thread Paolo Carlini
.. nope, sorry, what I have doesn't work for eg: for (class C {};;) Paolo.

Re: [RFC stage 1] Proposed new warning: -Wmisleading-indentation

2015-04-28 Thread Joseph Myers
On Fri, 17 Apr 2015, Manuel López-Ibáñez wrote: > On 17/04/15 16:42, Tom Tromey wrote: > > > > > > > "Dave" == David Malcolm writes: > > > > Dave> However within libcpp and gcc, in linemap's expanded_location and in > > Dave> diagnostic messages, the "column" numbers are actually 1-based counts

Re: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2

2015-04-28 Thread Jeff Law
On 04/28/2015 12:38 PM, rohitarul...@freescale.com wrote: -Original Message- From: Jeff Law [mailto:l...@redhat.com] Sent: Tuesday, April 28, 2015 11:48 PM To: Dharmakan Rohit-B30502; gcc-patches@gcc.gnu.org; rguent...@suse.de; Jakub Jelinek Cc: Alan Modra; David Edelsohn; Wienskoski

[C++ Patch] PR 59729

2015-04-28 Thread Paolo Carlini
Hi, apparently we aren't implementing the bits of DR 1732 [C++14] about range-based for declarations. Tested x86_64-linux. Thanks, Paolo. /// /cp 2015-04-28 Paolo Carlini PR c++/59729, DR 1732 * parser.c (cp_parser_for_init_statement): Do not allow type

[PATCH/libiberty] fix build of gdb/binutils with clang.

2015-04-28 Thread Yunlian Jiang
I believe this is the same problem as https://gcc.gnu.org/ml/gcc-patches/2008-07/msg00292.html The asprinf declaration is messed up when using clang to build gdb. diff --git a/include/libiberty.h b/include/libiberty.h index b33dd65..a294903 100644 --- a/include/libiberty.h +++ b/include/libibert

Re: C PATCH for c/65345 (file-scope _Atomic expansion, this time with floats)

2015-04-28 Thread Joseph Myers
On Tue, 14 Apr 2015, Marek Polacek wrote: > You were right: my earlier fix for c/65345 only handled non-float types. > This patch thus handles even the float types. The fix is analogical to the > previous: use create_tmp_var_raw and TARGET_EXPR to avoid ICE. > > This only fixes x86 though, other

Re: [PATCH][PR65818][bootstrap,hppa] Return side-effect free result in gimplify_va_arg_internal

2015-04-28 Thread Tom de Vries
On 28-04-15 12:34, Richard Biener wrote: On Mon, Apr 27, 2015 at 5:04 PM, Tom de Vries wrote: On 27-04-15 15:40, Richard Biener wrote: On Mon, Apr 27, 2015 at 3:06 PM, Tom de Vries wrote: On 27-04-15 10:17, Richard Biener wrote: This patch fixes that by gimplifying the address expressio

C++ PATCH for c++/65896 (constexpr and empty bases)

2015-04-28 Thread Jason Merrill
In this testcase we were getting confused when trying to initialize an empty base with a CONSTRUCTOR: the initialization target was *(base*)this, which constexpr evaluation resolves to the object argument, which isn't actually of the base type. So we end up storing a base constructor as the va

Re: [patch] Only configure libstdc++-v3/python dir for hosted builds

2015-04-28 Thread Jonathan Wakely
On 27/08/14 18:50 +0100, Jonathan Wakely wrote: Currently a freestanding build installs the Python GDB hooks as ${libdir}/libstdc*-gdb.py (with a literal * character in the filename) because there is no libstdc++.so library file and the wildcard doesn't get expanded (see the install-data-local ta

Re: [PATCH] Support -rdynamic on darwin12 and later

2015-04-28 Thread Mike Stump
On Apr 28, 2015, at 6:39 AM, Jack Howarth wrote: > The attached patch adds support for the -rdynamic compiler flag > on darwin12 and later. > Okay for gcc trunk? Jack was able to confirm that this doesn’t change darwin11. Ok.

Re: [commited, Patch, Fortran] Prevent segfault with dump-*-original for implicit class expressions.

2015-04-28 Thread Andre Vehreschild
Hi Mikael, hi all, Mikael, thanks for the review. Commited as r222539 including the improved regexp. Regards, Andre On Tue, 28 Apr 2015 14:05:57 +0200 Mikael Morin wrote: > Hello, > > Le 28/04/2015 12:43, Andre Vehreschild a écrit : > > To get the testsuite accepting a dump-fortran-or

Fix OpenMP's target update directive in templated code

2015-04-28 Thread Thomas Schwinge
Hi Jakub! When adding support for C++ templates usage with OpenACC directives (gcc/cp/pt.c:tsubst_expr), we found: On Mon, 27 Apr 2015 10:57:14 -0700, Cesar Philippidis wrote: > On 04/27/2015 10:40 AM, Thomas Schwinge wrote: > > Cesar wrote: > >> case OMP_TARGET_UPDATE: > >>tmp = t

Re: Bare bones of type verifier

2015-04-28 Thread Bernhard Reutner-Fischer
On April 28, 2015 6:01:24 PM GMT+02:00, Bernhard Reutner-Fischer wrote: >On April 28, 2015 11:05:44 AM GMT+02:00, Jan Hubicka >wrote: >>Hi, >>I will fix the free count issue - my internet access in China was bit >>sporadic >>and I hoped you will know why the count seem to disagree between PPC64

RE: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2

2015-04-28 Thread rohitarul...@freescale.com
>-Original Message- >From: Jeff Law [mailto:l...@redhat.com] >Sent: Tuesday, April 28, 2015 11:48 PM >To: Dharmakan Rohit-B30502; gcc-patches@gcc.gnu.org; rguent...@suse.de; Jakub >Jelinek >Cc: Alan Modra; David Edelsohn; Wienskoski Edmar-RA8797 >Subject: Re: [RFC: Patch, PR 60158] gcc/

RE: [Patch, MIPS] Change mips4 default processor to r10K

2015-04-28 Thread Matthew Fortune
Steve Ellcey writes: > This patch changes the default processor for mips4 from the r8000 to > the > r1. There are several reasons for this change, the main one > being the difference in the r8000 madd instruction and the rest of the > mips4 > family. The r8000 has a fused madd instruction (

[PATCH, testsuite, committed] Remove spurious comment line from gcc.dg/vect/vect-33.c

2015-04-28 Thread Bill Schmidt
Hi, As pointed out by Bin Cheng in https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01575.html, an extra comment line slipped into one of the test cases when I was updating tests for the POWER8 unaligned memory access patch. This comment had the unfortunate side effect of disabling the test for AArc

Re: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2

2015-04-28 Thread Jeff Law
On 04/28/2015 03:44 AM, rohitarul...@freescale.com wrote: Ping. -Original Message- From: Dharmakan Rohit-B30502 Sent: Friday, March 27, 2015 7:57 PM To: gcc-patches@gcc.gnu.org; rguent...@suse.de; Jakub Jelinek Cc: Alan Modra; David Edelsohn; Wienskoski Edmar-RA8797; Dharmakan Rohit-B305

Re: [PATCH] missing return in debug/vector _Safe_vector::operator=

2015-04-28 Thread Jonathan Wakely
On 28/04/15 13:47 +0100, Jonathan Wakely wrote: On 28/04/15 14:43 +0200, Stephan Bergmann wrote: On 04/28/2015 02:38 PM, Jonathan Wakely wrote: [CCing gcc-patches] On 28/04/15 14:32 +0200, Stephan Bergmann wrote: broken on GCC 5 and trunk Ouch. OK for trunk and the branch, do you have comm

Re: [C++ RFC/Patch] PR 39813

2015-04-28 Thread Paolo Carlini
Hi, On 04/28/2015 02:59 PM, Jason Merrill wrote: On 04/28/2015 08:54 AM, Paolo Carlini wrote: Hi, On 04/28/2015 02:45 PM, Jason Merrill wrote: On 04/28/2015 06:59 AM, Paolo Carlini wrote: && !DECL_FRIEND_PSEUDO_TEMPLATE_INSTANTIATION (t) the name of the macro seems weird to me: it men

[Patch, MIPS] Change mips4 default processor to r10K

2015-04-28 Thread Steve Ellcey
This patch changes the default processor for mips4 from the r8000 to the r1. There are several reasons for this change, the main one being the difference in the r8000 madd instruction and the rest of the mips4 family. The r8000 has a fused madd instruction (no truncation between the multiply

[committed] Remove stray line in c_parser_binary_expression

2015-04-28 Thread Marek Polacek
Bootstrapped/regtested on x86_64-linux, applying to trunk. 2015-04-28 Marek Polacek * c-parser.c (c_parser_binary_expression): Remove duplicate line. diff --git gcc/c/c-parser.c gcc/c/c-parser.c index f5e2ac2c..cc8a4e3 100644 --- gcc/c/c-parser.c +++ gcc/c/c-parser.c @@ -6370,11 +6370

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-28 Thread Caroline Tice
Thank you! -- Caroline Tice cmt...@google.com On Tue, Apr 28, 2015 at 10:16 AM, David Edelsohn wrote: > I just committed the patch for Dominique. > > - David > > > On Tue, Apr 28, 2015 at 1:12 PM, Caroline Tice wrote: >> Yes, this is already mentioned in PR 65910 >> (https://gcc.gnu.org/bugzil

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-28 Thread David Edelsohn
I just committed the patch for Dominique. - David On Tue, Apr 28, 2015 at 1:12 PM, Caroline Tice wrote: > Yes, this is already mentioned in PR 65910 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65910). > > There is a patch mentioned in that PR that both appears to fix the > problem and appea

Re: c-family PATCH to improve -Wbool-compare (PR c/64610)

2015-04-28 Thread Jeff Law
On 04/28/2015 04:49 AM, Marek Polacek wrote: This improves -Wbool-compare a bit: boolean >= 0 is always true, on the other hand boolean < 0 is always false, and similar. One feature/bug is that in C++ we don't warn for e.g. bool >= false, since the warning cares about CMP or CMP . I can fix

Re: gcc/c-family/c-pragma.h:pragma_omp_clause (was: Pragma parsing)

2015-04-28 Thread Jakub Jelinek
On Tue, Apr 28, 2015 at 06:59:12PM +0200, Thomas Schwinge wrote: > We're getting ready to submit patches extending the C/C++ front ends for > the remaining OpenACC clauses, and given the current layout of > gcc/c-family/c-pragma.h:pragma_omp_clause, we're then at 69 unique > clauses, which is more

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-28 Thread Gerald Pfeifer
On Tue, 28 Apr 2015, Caroline Tice wrote: > Yes, this is already mentioned in PR 65910 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65910). > > There is a patch mentioned in that PR that both appears to fix the > problem and appears to have been approved. I thought the author of > the patch wo

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-28 Thread Jeff Law
On 04/28/2015 11:12 AM, Caroline Tice wrote: Yes, this is already mentioned in PR 65910 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65910). There is a patch mentioned in that PR that both appears to fix the problem and appears to have been approved. I thought the author of the patch would com

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-28 Thread Caroline Tice
Yes, this is already mentioned in PR 65910 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65910). There is a patch mentioned in that PR that both appears to fix the problem and appears to have been approved. I thought the author of the patch would commit it, but that does not appear to have happen

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-28 Thread David Edelsohn
Caroline, Your patch has broken bootstrap on AIX and probably other platforms. /nasfarm/edelsohn/src/src/gcc/varasm.c: In function 'void assemble_end_function(tree, const char*)': /nasfarm/edelsohn/src/src/gcc/varasm.c:1870:12: error: 'ASM_DECLARE_FUNCTION_SIZE' was not declared in this scope

Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-04-28 Thread Jeff Law
On 04/28/2015 07:46 AM, Richard Sandiford wrote: I still think we should rename label_rtx too, because I think it's confusing for label_rtx to return something other than a label. That's probably a separate, follow-up patch though. Seems fine as a follow-up. I added the member functions. The

Re: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-04-28 Thread Martin Galvan
Thanks a lot. I don't have write access to the repository, could you commit this for me? On Tue, Apr 28, 2015 at 1:21 PM, Ramana Radhakrishnan wrote: > On Tue, Apr 28, 2015 at 4:19 PM, Martin Galvan > wrote: >> This patch adds CFI directives to the soft floating point support code for >> ARM. >

Re: gcc make clean fixes

2015-04-28 Thread Mike Stump
On Apr 27, 2015, at 4:03 PM, Jim Wilson wrote: > On Mon, Apr 27, 2015 at 12:30 PM, Jeff Law wrote: >> Looks good to me. Please install if you haven't already done so. > > Thanks, I checked in the patch. I'm not maintainer of anything > currently, Actually, you are still listed: ia64 port

Re: gcc make clean fixes

2015-04-28 Thread Jeff Law
On 04/27/2015 05:03 PM, Jim Wilson wrote: On Mon, Apr 27, 2015 at 12:30 PM, Jeff Law wrote: Looks good to me. Please install if you haven't already done so. Thanks, I checked in the patch. I'm not maintainer of anything currently, so I'm assuming all of my patches need to be approved before

Re: Use wi:: in canon_condition

2015-04-28 Thread Jeff Law
On 04/28/2015 07:49 AM, Richard Sandiford wrote: Fix a simple case where we can generalise the CONST_INT handling to all integer constants (CONST_DOUBLE or CONST_WIDE_INT). Tested on x86_64-linux-gnu. OK to install? Thanks, Richard gcc/ * loop-iv.c (canon_condition): Generalize to al

gcc/c-family/c-pragma.h:pragma_omp_clause (was: Pragma parsing)

2015-04-28 Thread Thomas Schwinge
Hi Jakub! We now have to revisit this discussion about gcc/c-family/c-pragma.h:pragma_omp_clause, : On Thu, 18 Dec 2014 14:48:32 +0100, I wrote: > > > -/* All clauses defined by OpenMP 2.5, 3.0, 3.1 and 4.0. > >

Re: [PATCH][AARCH64]Add ACLE 2.0 predefined macros: __ARM_ALIGN_MAX_PWR and __ARM_ALIGN_MAX_STACK_PWR

2015-04-28 Thread Marcus Shawcroft
On 16 December 2014 at 10:19, Renlin Li wrote: > 2014-12-16 Renlin Li > > * config/aarch64/aarch64.h(TARGET_CPU_CPP_BUILTINS): Define > __ARM_ALIGN_MAX_PWR > and __ARM_ALIGN_MAX_STACK_PWR. OK /Marcus

Re: [PATCH, PR65915] Fix float conversion split.

2015-04-28 Thread H.J. Lu
On Tue, Apr 28, 2015 at 9:20 AM, Ilya Tocar wrote: >> > I've renamed EXT_SSE_REG_P into EXT_REX_SSE_REG_P for consistency. >> > Ok for stage1? >> Patch is OK for stage1. >> >> -- >> Thanks, K >> >> >> > On 19 Mar 12:24, Ilya Tocar wrote: >> > > Hi, >> > > >> > > There were some discussion about "x

Re: [PATCH,PING][ARM]Remove vec_shr and vec_shr optabs

2015-04-28 Thread Ramana Radhakrishnan
On Tue, Apr 28, 2015 at 4:15 PM, Alan Lawrence wrote: >> No new code here ;). There is a slight change of execution path, i.e. some >> VEC_PERM_EXPRs (e.g. those for reductions via shifts) will be expanded >> using >> arm_expand_vec_perm_const rather than the vec_shr pattern. This generates >> EXT

Re: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-04-28 Thread Ramana Radhakrishnan
On Tue, Apr 28, 2015 at 4:19 PM, Martin Galvan wrote: > This patch adds CFI directives to the soft floating point support code for > ARM. > > Previously, if we tried to do a backtrace from that code in a debug session > we'd > get something like this: > > (gdb) bt > #0 __nedf2 () at > ../../..

[PATCH, PR65915] Fix float conversion split.

2015-04-28 Thread Ilya Tocar
> > I've renamed EXT_SSE_REG_P into EXT_REX_SSE_REG_P for consistency. > > Ok for stage1? > Patch is OK for stage1. > > -- > Thanks, K > > > > On 19 Mar 12:24, Ilya Tocar wrote: > > > Hi, > > > > > > There were some discussion about "x" constraints being too conservative > > > for some patterns

Re: Re: [PING][PATCH][4.9]Backport "Fix register corruption bug in ree"

2015-04-28 Thread Renlin Li
Ping~ Regards, Renlin Li On 16/04/15 10:32, Renlin Li wrote: Ping~ Regards, Renlin Li On 16/04/15 10:09, wrote: Ping~ Anybody has time to review it? Regards, Renlin Li On 06/02/15 17:48, Renlin Li wrote: Hi all, This is a backport patch for branch 4.9. You can find the original patch he

Re: Bare bones of type verifier

2015-04-28 Thread Bernhard Reutner-Fischer
On April 28, 2015 11:05:44 AM GMT+02:00, Jan Hubicka wrote: >Hi, >I will fix the free count issue - my internet access in China was bit >sporadic >and I hoped you will know why the count seem to disagree between PPC64 >and Linux >builds. In meantime PPC64 stopped to build for me. >> >> (early) dw

[PING][PATCH][AARCH64]Add ACLE 2.0 predefined macros: __ARM_ALIGN_MAX_PWR and __ARM_ALIGN_MAX_STACK_PWR

2015-04-28 Thread Renlin Li
Ping~ Regards, Renlin Li On 16/12/14 10:19, Renlin Li wrote: Hi all, This is a simple patch to add another two ACLE 2.0 predefined macros into aarch64 backend. They are __ARM_ALIGN_MAX_PWR and __ARM_ALIGN_MAX_STACK_PWR. Currently, those two values are hard-wired to 16. The following clauses f

[PATCH][AARCH64]Use shl for vec_shr_ rtx pattern.

2015-04-28 Thread Renlin Li
Hi all, unsigned shift left dosen't support immediate shift. Previouly, gcc will generate asm instruction like this: "ushl d1, d0, 32", which is not a legal insn and will be rejected by assembler. This patch change the use of ushl in vec_shr_ into shl. A test case is added, and it passes on

[PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-04-28 Thread Martin Galvan
This patch adds CFI directives to the soft floating point support code for ARM. Previously, if we tried to do a backtrace from that code in a debug session we'd get something like this: (gdb) bt #0 __nedf2 () at ../../../../../../gcc-4.9.2/libgcc/config/arm/ieee754-df.S:1082 #1 0x0db6 in _

[PATCH,PING][ARM]Remove vec_shr and vec_shr optabs

2015-04-28 Thread Alan Lawrence
No new code here ;). There is a slight change of execution path, i.e. some VEC_PERM_EXPRs (e.g. those for reductions via shifts) will be expanded using arm_expand_vec_perm_const rather than the vec_shr pattern. This generates EXT instructions equivalent to the original, but using the mode of the s

Re: [PATCH] Improve PR44563

2015-04-28 Thread Jan Hubicka
Hi, the g++.dg/tree-ssa/pr61034.C has turned out to be sensitive to PUSH_ARGS settings so fixing it on PPC64 caused x86_64 to regress. This patch introduce temporary so the code is consistent between PPC64 and x86_64. Comitted after ICR dicussion with Richard. Honza Index: ChangeLog

C++ PATCH for c++/65656 (constexpr and __builtin_constant_p)

2015-04-28 Thread Jason Merrill
We have two desires for interaction of __builtin_constant_p with constexpr: 1) it should be a constant-expression even if its operands are not, and 2) we shouldn't fold it to false prematurely when parsing a constexpr function (c++/54021). We were having trouble with both of these, and this p

Re: C++ PATCH for c++/50800 (ICE with may_alias and templates)

2015-04-28 Thread Jason Merrill
On 04/23/2015 01:45 PM, H.J. Lu wrote: On Thu, Apr 23, 2015 at 8:52 AM, Jason Merrill wrote: We try to strip attributes that aren't reflected in mangling from template arguments, but were failing to do that in this case. Fixed by making strip_typedefs strip such attributes as well. Tested x86

Re: [PATCH, ARM] Alternatives and type attributes fixes.

2015-04-28 Thread Kyrill Tkachov
On 28/04/15 09:32, Yvan Roux wrote: Hi, On 27 April 2015 at 15:58, Yvan Roux wrote: On 27 April 2015 at 15:20, Kyrill Tkachov wrote: Hi Yvan, On 27/04/15 13:25, Yvan Roux wrote: Hi, This is a follow-up of PR64208 where an LRA loop was due to redundancy in insn's alternatives. I've chec

Re: Improve LTO type checking during symtab merging

2015-04-28 Thread Jan Hubicka
> > Only emitting the warnings with -Wodr looks good to me. I can't see > how we can decide what cases lead to wrong code surprises and what not OK, I will go with -Wodr for all the warnings then, that seems fine to me. > (other than using types_compatible_p ...). Wrong-code can only(?) happen

Re: [PATCH] PR 62173, re-shuffle insns for RTL loop invariant hoisting

2015-04-28 Thread Jiong Wang
2015-04-28 14:56 GMT+01:00 Matthew Fortune : >> Hi Matthew, >> >> 2015-04-21 15:24 GMT+01:00 Jiong Wang : >> >> > >> > 2015-04-21 Jiong Wang >> > >> > gcc/ >> > * loop-invariant.c (find_defs): Enable DF_DU_CHAIN build. >> > (vfp_const_iv): New hash table. >> > (expensive_addr_check_p): New

Re: [PATCH] Remove some restrictions on loop shape in tree-if-conv.c

2015-04-28 Thread Alan Lawrence
Alan Lawrence wrote: Tree if-conversion currently bails out for loops that (a) contain nested loops; (b) have more than one exit; (c) where the exit block (source of the exit edge) does not dominate the loop latch; (d) where the exit block is the loop header, or there are statements after the e

RE: [PATCH] PR 62173, re-shuffle insns for RTL loop invariant hoisting

2015-04-28 Thread Matthew Fortune
> Hi Matthew, > > 2015-04-21 15:24 GMT+01:00 Jiong Wang : > > > > > 2015-04-21 Jiong Wang > > > > gcc/ > > * loop-invariant.c (find_defs): Enable DF_DU_CHAIN build. > > (vfp_const_iv): New hash table. > > (expensive_addr_check_p): New boolean. > > (init_inv_motion_data): Initialize new

[PATCH] Remove some restrictions on loop shape in tree-if-conv.c

2015-04-28 Thread Alan Lawrence
Tree if-conversion currently bails out for loops that (a) contain nested loops; (b) have more than one exit; (c) where the exit block (source of the exit edge) does not dominate the loop latch; (d) where the exit block is the loop header, or there are statements after the exit. This patch remo

Re: C++ delayed folding branch review

2015-04-28 Thread Jason Merrill
On 04/28/2015 08:06 AM, Kai Tietz wrote: 2015-04-24 20:25 GMT+02:00 Jason Merrill : So for warning folding, I think the caching approach we were talking about in the call today is the way to go. Ok. Just a question about where to hook up the hash-variable. What would be a good place to creat

Use wi:: in canon_condition

2015-04-28 Thread Richard Sandiford
Fix a simple case where we can generalise the CONST_INT handling to all integer constants (CONST_DOUBLE or CONST_WIDE_INT). Tested on x86_64-linux-gnu. OK to install? Thanks, Richard gcc/ * loop-iv.c (canon_condition): Generalize to all types of integer constant. Index: gcc/lo

Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-04-28 Thread Richard Sandiford
Mikhail Maltsev writes: > I'm sending an updated patch (rebased to recent trunk, bootstrapped and > regtested on x86_64-unknown-linux-gnu). > > On 04/25/2015 02:49 PM, Richard Sandiford wrote: >> FWIW I think the split between label_rtx and live_label_rtx is good, >> but I think we should give the

[PATCH] Support -rdynamic on darwin12 and later

2015-04-28 Thread Jack Howarth
The attached patch adds support for the -rdynamic compiler flag on darwin12 and later. The darwin linker, starting with Xcode 5 on darwin12, added support for the associated new -export_dynamic linker flag. -export_dynamic Preserves all global symbols in main executables

[patch] libstdc++/60333 fix make_signed and make_unsigned for long long enumerations

2015-04-28 Thread Jonathan Wakely
We were assuming that no enumeration would ever be bigger than long and were also failing to preserve cv qualifiers on enums. I fixed make_unsigned and then changed make_signed to reuse that instead of duplicating all the logic. Tested x86_64-linux (with -m32) and ppc64le-linux. Committed to tr

Re: [PATCH 6/n] OpenMP 4.0 offloading infrastructure: option handling

2015-04-28 Thread Bernd Schmidt
On 04/27/2015 06:08 PM, Thomas Schwinge wrote: OK to do the following instead? (Coding style/code copied from gcc/config/i386/intelmic-mkoffload.c for consistency.) Err, was this a question for me? I'm fine with that too. Bernd

Re: PR libstdc++/65883 missing unsigned in numeric_limits

2015-04-28 Thread Jonathan Wakely
On 28/04/15 14:47 +0200, Marc Glisse wrote: Hello, this patch fixes an obvious typo. Regtested without problem, and I manually checked that the new return value of max() makes more sense. OK, thanks.

[patch] libstdc++/61645 add noexcept to forward_list::splice_after

2015-04-28 Thread Jonathan Wakely
This isn't required, but we might as well add it for consistency with std::list:splice and for extra noexceptiness. Tested ppc64le-linux, committed to trunk. commit 24308d6f00c2235fcc87ce0ab05e219696714699 Author: Jonathan Wakely Date: Wed Apr 8 17:35:13 2015 +0100 PR libstdc++/61645

Re: [C++ RFC/Patch] PR 39813

2015-04-28 Thread Jason Merrill
On 04/28/2015 08:54 AM, Paolo Carlini wrote: Hi, On 04/28/2015 02:45 PM, Jason Merrill wrote: On 04/28/2015 06:59 AM, Paolo Carlini wrote: && !DECL_FRIEND_PSEUDO_TEMPLATE_INSTANTIATION (t) the name of the macro seems weird to me: it mentions friends (and friends are mentioned in its com

Re: [C++ RFC/Patch] PR 39813

2015-04-28 Thread Paolo Carlini
Hi, On 04/28/2015 02:45 PM, Jason Merrill wrote: On 04/28/2015 06:59 AM, Paolo Carlini wrote: && !DECL_FRIEND_PSEUDO_TEMPLATE_INSTANTIATION (t) the name of the macro seems weird to me: it mentions friends (and friends are mentioned in its comment too) but isn't used only for DECL_FRIEND_

Re: [PATCH] missing return in debug/vector _Safe_vector::operator=

2015-04-28 Thread Jonathan Wakely
On 28/04/15 14:43 +0200, Stephan Bergmann wrote: On 04/28/2015 02:38 PM, Jonathan Wakely wrote: [CCing gcc-patches] On 28/04/15 14:32 +0200, Stephan Bergmann wrote: broken on GCC 5 and trunk Ouch. OK for trunk and the branch, do you have commit privs? No, I don't; would be great if you ca

PR libstdc++/65883 missing unsigned in numeric_limits

2015-04-28 Thread Marc Glisse
Hello, this patch fixes an obvious typo. Regtested without problem, and I manually checked that the new return value of max() makes more sense. 2015-04-28 Marc Glisse PR libstdc++/65883 * include/std/limits (numeric_limits): Add missing unsigned. -- Marc GlisseIndex: inclu

Re: [C++ RFC/Patch] PR 39813

2015-04-28 Thread Jason Merrill
On 04/28/2015 06:59 AM, Paolo Carlini wrote: && !DECL_FRIEND_PSEUDO_TEMPLATE_INSTANTIATION (t) the name of the macro seems weird to me: it mentions friends (and friends are mentioned in its comment too) but isn't used only for DECL_FRIEND_P true and indeed it is true for the non-friend 'fn

Re: [PATCH] missing return in debug/vector _Safe_vector::operator=

2015-04-28 Thread Stephan Bergmann
On 04/28/2015 02:38 PM, Jonathan Wakely wrote: [CCing gcc-patches] On 28/04/15 14:32 +0200, Stephan Bergmann wrote: broken on GCC 5 and trunk Ouch. OK for trunk and the branch, do you have commit privs? No, I don't; would be great if you can push that.

Re: [PATCH] missing return in debug/vector _Safe_vector::operator=

2015-04-28 Thread Jonathan Wakely
[CCing gcc-patches] On 28/04/15 14:32 +0200, Stephan Bergmann wrote: broken on GCC 5 and trunk Ouch. OK for trunk and the branch, do you have commit privs? Index: libstdc++-v3/ChangeLog === --- libstdc++-v3/ChangeLog (rev

[patch] libstdc++/65631 make std::seed_seq noncopyable

2015-04-28 Thread Jonathan Wakely
Tested ppc64le-linux, committed to trunk. commit 8009da43b7be1a10335240b7b2f4e27250d5376f Author: Jonathan Wakely Date: Mon Mar 30 19:22:52 2015 +0100 PR libstdc++/65631 * include/bits/random.h (seed_seq) Define copy constructor and copy assignment as deleted. * testsuite/

Re: [PATCH] [libstdc++/65839] whatis support for xmethods

2015-04-28 Thread Jonathan Wakely
On 27/04/15 15:44 -0700, Doug Evans wrote: PR libstdc++/65839 * python/libstdcxx/v6/xmethods.py (get_bool_type): New function. Replace all lookups of "bool" with this. (get_std_size_type): New function. Replace all lookups of std::size_t with this.

Re: [libstdc++ PATCH] Add support for std::uncaught_exceptions

2015-04-28 Thread Jonathan Wakely
On 27/04/15 21:53 +0100, Jonathan Wakely wrote: On 27/04/15 21:40 +0100, Jonathan Wakely wrote: Tested x86_64-linux and powerpc64le-linux. Committed to trunk. The baseline_symbols changes aren't needed now and I tweaked the gnu.ver file slightly. Ville noticed a typo in a comment I added, fix

[patch] Add std::void_t

2015-04-28 Thread Jonathan Wakely
Define std::void_t for -std=c++17 and -std=gnu++11 (like Ville's uncaught_exceptions() patch I think this is useful to define as an extension pre-C++17, and the feature-test macro makes it easy for users to test for the presence/absence of it in different modes). Tested ppc64le-linux, committed t

  1   2   >