On 04/28/2015 07:46 AM, Richard Sandiford wrote:
I still think we should rename label_rtx too, because I think it's
confusing for label_rtx to return something other than a label.
That's probably a separate, follow-up patch though.
Seems fine as a follow-up.
I added the member functions. The problem is that JUMP_LABEL does not
always satisfy the current invariant of rtx_insn: it can also be an RTL
expression of type RETURN or SIMPLE_RETURN.
Yeah, that's probably something that needs to change at some point.
Agreed. These corner cases are precisely the kinds of things we want to
be identifying and cleaning up as we go. I haven't looked at the
updated patch yet, but if there isn't a comment about this case, then
there should be.
Jeff
