On Tue, 14 Apr 2015, Marek Polacek wrote: > You were right: my earlier fix for c/65345 only handled non-float types. > This patch thus handles even the float types. The fix is analogical to the > previous: use create_tmp_var_raw and TARGET_EXPR to avoid ICE. > > This only fixes x86 though, other arches will need something similar. You'll > notice that the tests are XFAILed on arches other than i?86/x86_64, hope that > is fine.
I don't think default XFAILing is appropriate; like c11-atomic-exec-5.c, I think the failures should be visible to show that there is something target-specific to be done (and then target maintainers can choose to XFAIL with reference to a bug filed in Bugzilla if they so wish, but the default should be non-XFAILed). I also think you should identify the targets that look like they would be affected (based on source code inspection) and inform the relevant target maintainers of the issue and of the appropriate approach for a fix. Apart from the XFAILing, the patch is OK in the absence of x86 back-end maintainer objections within 48 hours. -- Joseph S. Myers jos...@codesourcery.com
