I just committed the patch for Dominique. - David
On Tue, Apr 28, 2015 at 1:12 PM, Caroline Tice <cmt...@google.com> wrote: > Yes, this is already mentioned in PR 65910 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65910). > > There is a patch mentioned in that PR that both appears to fix the > problem and appears to have been approved. I thought the author of > the patch would commit it, but that does not appear to have happened > yet. Should I go ahead and commit that patch, or should I wait for > the author to do that? > > -- Caroline Tice > cmt...@google.clom > > > On Tue, Apr 28, 2015 at 10:10 AM, David Edelsohn <dje....@gmail.com> wrote: >> Caroline, >> >> Your patch has broken bootstrap on AIX and probably other platforms. >> >> /nasfarm/edelsohn/src/src/gcc/varasm.c: In function 'void >> assemble_end_function(tree, const char*)': >> /nasfarm/edelsohn/src/src/gcc/varasm.c:1870:12: error: >> 'ASM_DECLARE_FUNCTION_SIZE' was not declared in this scope >> decl); >> ^ >> >> You added a reference to ASM_DECLARE_FUNCTION_SIZE without guarding >> it, as was done only 10 lines higher in the same function. The macro >> is not declared for all targets. >> >> Also, the ChangeLog entry has numerous typos. >> >> Please fix ASAP. >> >> Thanks, David
