Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix AVPacket lifetime in seek_frame_generic

2016-01-02 Thread Hendrik Leppkes
On Sat, Jan 2, 2016 at 2:04 AM, Michael Niedermayer wrote: > On Sat, Jan 02, 2016 at 01:21:04AM +0100, Hendrik Leppkes wrote: >> Fixes ticket #5117 >> --- >> libavformat/utils.c | 7 +-- >> 1 file changed, 5 insertions(+), 2 deletions(-) > > LGTM > > thx > Applied. __

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in certain cases

2016-01-02 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: > Also, QuickTime in Windows or Mac ignores the > greyscale bit if the video sample description > contains a palette, regardless of bit depth. How did you test this? If what you write is true (I didn't test yet) don't you agree that this is not reflected in t

Re: [FFmpeg-devel] [PATCH] oggparsedaala: reject too large gpshift

2016-01-02 Thread Andreas Cadhalpun
On 02.01.2016 02:11, Michael Niedermayer wrote: > On Wed, Dec 30, 2015 at 01:00:43AM +0100, Andreas Cadhalpun wrote: >> From 4380123388f38eb9bbd11db34b0ac82a9ec18d5a Mon Sep 17 00:00:00 2001 >> From: Andreas Cadhalpun >> Date: Tue, 29 Dec 2015 18:32:01 +0100 >> Subject: [PATCH] oggparsedaala: reje

Re: [FFmpeg-devel] [PATCH] doc: make apidoc output independent of SRC_PATH

2016-01-02 Thread Andreas Cadhalpun
On 02.01.2016 03:28, Michael Niedermayer wrote: > On Sun, Dec 20, 2015 at 11:31:29PM +0100, Andreas Cadhalpun wrote: >> Previously it included the SRC_PATH in every title. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> doc/Makefile| 7 --- >> doc/doxy-wrapper.sh | 11 ++- >>

Re: [FFmpeg-devel] 2.9/3.0, 2.8.5, ...

2016-01-02 Thread Andreas Cadhalpun
On 01.01.2016 15:19, Michael Niedermayer wrote: > Its a while since 2.8 so unless there are objections i will make a > 2.9 or if people prefer a 3.0 within the next month or so I think using 3.0 would better due to the backwards incompatible API changes. We should do this always to give the major

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-02 Thread Andreas Cadhalpun
On 01.01.2016 21:16, Rostislav Pehlivanov wrote: > Thanks for the feedback. > Fixed all the issues you reported. The new revision is in this email. Thanks. Unfortunately you introduced a much more serious crash problem. Also, there is now a typo "libbavcodec" (two 'b') in the subject. > --- /dev

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Michael Niedermayer
On Wed, Dec 30, 2015 at 11:34:02AM +0100, Mats Peterson wrote: > On 12/30/2015 08:35 AM, Mats Peterson wrote: > >On 12/30/2015 08:17 AM, Mats Peterson wrote: > > > >> > >>When comparing the output in QuickTime and FFmpeg, I noticed that the > >>background is blue in FFmpeg, while it is white (or tr

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > I will thus apply this patch unless there are > some objections Please remove the Google Drive links from the commit message. (File names would be useful but as said, two different samples with the same name exist.) A remaining issue that may not

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-02 Thread Andreas Cadhalpun
On 02.01.2016 01:52, Rostislav Pehlivanov wrote: >> To the very best of my knowledge you are allowed >> to relicense code that was published under a two- >> (or three-) clause BSD license under the GPL (and >> the LGPL) as long as you keep the copyright >> notice. The BSD license is a very liberal

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in certain cases

2016-01-02 Thread Mats Peterson
On 01/02/2016 11:51 AM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: Also, QuickTime in Windows or Mac ignores the greyscale bit if the video sample description contains a palette, regardless of bit depth. How did you test this? If what you write is true (I didn't test yet) don'

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 01:33 PM, Michael Niedermayer wrote: One of the major peculiarities in my book is that the two blue colors in the video sample description and the white background are THREE colors together. Not exactly what I would call 1-bit video. I have absolutely no idea what they are doing in

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Michael Niedermayer
On Sat, Jan 02, 2016 at 02:09:36PM +0100, Mats Peterson wrote: > On 01/02/2016 01:33 PM, Michael Niedermayer wrote: > >> > >>One of the major peculiarities in my book is that the two blue > >>colors in the video sample description and the white background are > >>THREE colors together. Not exactly

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 02:09 PM, Mats Peterson wrote: On 01/02/2016 01:33 PM, Michael Niedermayer wrote: One of the major peculiarities in my book is that the two blue colors in the video sample description and the white background are THREE colors together. Not exactly what I would call 1-bit video. I

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 02:15 PM, Michael Niedermayer wrote: no, there is no white background with quicktime player 10.4 on a macbook air with the file i have Most interesting. I run Windows XP and MacOS 7.5 here for testing, so they are relatively old references. I suspect something has changed in the

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Michael Niedermayer
On Sat, Jan 02, 2016 at 02:20:12PM +0100, Mats Peterson wrote: > On 01/02/2016 02:15 PM, Michael Niedermayer wrote: > >no, there is no white background with quicktime player 10.4 on a > >macbook air with the file i have > > Most interesting. I run Windows XP and MacOS 7.5 here for testing, > so th

[FFmpeg-devel] [PATCH] dca: adjust decoding of the XBR extension for integer core decoding

2016-01-02 Thread Hendrik Leppkes
--- libavcodec/dcadec.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c index 187e172..0817018 100644 --- a/libavcodec/dcadec.c +++ b/libavcodec/dcadec.c @@ -1345,11 +1345,11 @@ int ff_dca_xbr_parse_frame(DCAContext *s)

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Michael Niedermayer
On Sat, Jan 02, 2016 at 02:16:12PM +0100, Mats Peterson wrote: [...] > Furthermore, as I have written before, the 1-bit mode is not fully > implemented/partly broken (the jagginess on the right edge shouldn't > be there), but many files play OK in spite of this. has this been reported on trac.ffmp

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 03:03 PM, Michael Niedermayer wrote: Most interesting. I run Windows XP and MacOS 7.5 here for testing, so they are relatively old references. I suspect something has changed in the QuickTime Animation decoder in QuickTime since then. please run md5sum on your file and tell me the

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 03:05 PM, Michael Niedermayer wrote: On Sat, Jan 02, 2016 at 02:16:12PM +0100, Mats Peterson wrote: [...] Furthermore, as I have written before, the 1-bit mode is not fully implemented/partly broken (the jagginess on the right edge shouldn't be there), but many files play OK in spi

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 03:13 PM, Mats Peterson wrote: please run md5sum on your file and tell me the value so we can be sure this is the same video file Yes, it's the same one. And once again, without applying the latest lavf/qtpalette patch the following (original from the QuickTime Beta CD) file w

Re: [FFmpeg-devel] [PATCH] ffmpeg: replace log2 by faster variant

2016-01-02 Thread Michael Niedermayer
On Fri, Jan 01, 2016 at 05:55:31PM -0800, Ganesh Ajjanagadde wrote: > On Wed, Dec 30, 2015 at 1:01 AM, Hendrik Leppkes wrote: > > On Wed, Dec 30, 2015 at 4:39 AM, Ganesh Ajjanagadde > > wrote: > >> The log is anyway rounded to an integer, so one may use an frexp > >> based approach. Note that thi

[FFmpeg-devel] [PATCH 1/3] ffmdec: reset packet_end in case of failure

2016-01-02 Thread Andreas Cadhalpun
This fixes segmentation faults caused by passing a packet_ptr of NULL to memcpy. Signed-off-by: Andreas Cadhalpun --- libavformat/ffmdec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.c index 9fe4155..7b2d0d7 100644 --- a/l

[FFmpeg-devel] [PATCH 2/3] ffmdec: cast state to unsigned for left shift

2016-01-02 Thread Andreas Cadhalpun
This fixes ubsan runtime error: left shift by 8 places cannot be represented in type 'int' Signed-off-by: Andreas Cadhalpun --- libavformat/ffmdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.c index 7b2d0d7..3162354 100644 --- a

[FFmpeg-devel] [PATCH 3/3] ffmdec: change type of len to ptrdiff_t

2016-01-02 Thread Andreas Cadhalpun
It is used to store the difference between pointers, so ptrdiff_t is the correct type. This prevents potential overflows. Signed-off-by: Andreas Cadhalpun --- libavformat/ffmdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.

Re: [FFmpeg-devel] [PATCH 2/3] ffmdec: cast state to unsigned for left shift

2016-01-02 Thread Nicolas George
Le tridi 13 nivôse, an CCXXIV, Andreas Cadhalpun a écrit : > This fixes ubsan runtime error: left shift by 8 places cannot be > represented in type 'int' > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/ffmdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/li

Re: [FFmpeg-devel] [PATCH 3/3] ffmdec: change type of len to ptrdiff_t

2016-01-02 Thread Nicolas George
Le tridi 13 nivôse, an CCXXIV, Andreas Cadhalpun a écrit : > It is used to store the difference between pointers, so ptrdiff_t is the > correct type. > > This prevents potential overflows. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/ffmdec.c | 5 +++-- > 1 file changed, 3 insertion

Re: [FFmpeg-devel] [PATCH] ffmpeg: replace log2 by faster variant

2016-01-02 Thread Ganesh Ajjanagadde
On Sat, Jan 2, 2016 at 6:24 AM, Michael Niedermayer wrote: > On Fri, Jan 01, 2016 at 05:55:31PM -0800, Ganesh Ajjanagadde wrote: >> On Wed, Dec 30, 2015 at 1:01 AM, Hendrik Leppkes wrote: >> > On Wed, Dec 30, 2015 at 4:39 AM, Ganesh Ajjanagadde >> > wrote: >> >> The log is anyway rounded to an i

Re: [FFmpeg-devel] [PATCH 1/2] lavc/pcm_tablegen: slight speedup of table generation

2016-01-02 Thread Ganesh Ajjanagadde
On Wed, Dec 30, 2015 at 8:34 PM, Ganesh Ajjanagadde wrote: > This gets rid of some branches to speed up table generation slightly > (impact higher on mulaw than alaw). Tables are identical to before, > tested with FATE. > > Sample benchmark (Haswell, GNU/Linux+gcc): > old: > 313494 decicycles in

Re: [FFmpeg-devel] [PATCH 2/3] ffmdec: cast state to unsigned for left shift

2016-01-02 Thread Andreas Cadhalpun
On 02.01.2016 16:56, Nicolas George wrote: > Le tridi 13 nivôse, an CCXXIV, Andreas Cadhalpun a écrit : >> This fixes ubsan runtime error: left shift by 8 places cannot be >> represented in type 'int' >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/ffmdec.c | 2 +- >> 1 file changed,

Re: [FFmpeg-devel] 2.9/3.0, 2.8.5, ...

2016-01-02 Thread James Almer
On 1/2/2016 8:42 AM, Andreas Cadhalpun wrote: > On 01.01.2016 15:19, Michael Niedermayer wrote: >> Its a while since 2.8 so unless there are objections i will make a >> 2.9 or if people prefer a 3.0 within the next month or so > > I think using 3.0 would better due to the backwards incompatible >

Re: [FFmpeg-devel] [PATCH 3/3] ffmdec: change type of len to ptrdiff_t

2016-01-02 Thread Andreas Cadhalpun
On 02.01.2016 16:59, Nicolas George wrote: > Le tridi 13 nivôse, an CCXXIV, Andreas Cadhalpun a écrit : >> It is used to store the difference between pointers, so ptrdiff_t is the >> correct type. >> >> This prevents potential overflows. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavforma

Re: [FFmpeg-devel] 2.9/3.0, 2.8.5, ...

2016-01-02 Thread Andreas Cadhalpun
On 02.01.2016 17:12, James Almer wrote: > On 1/2/2016 8:42 AM, Andreas Cadhalpun wrote: >> On 01.01.2016 15:19, Michael Niedermayer wrote: >>> Its a while since 2.8 so unless there are objections i will make a >>> 2.9 or if people prefer a 3.0 within the next month or so >> >> I think using 3.0 wou

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 03:21 PM, Mats Peterson wrote: On 01/02/2016 03:13 PM, Mats Peterson wrote: please run md5sum on your file and tell me the value so we can be sure this is the same video file Yes, it's the same one. And once again, without applying the latest lavf/qtpalette patch the following

Re: [FFmpeg-devel] [PATCH] dca: adjust decoding of the XBR extension for integer core decoding

2016-01-02 Thread Michael Niedermayer
On Sat, Jan 02, 2016 at 03:05:41PM +0100, Hendrik Leppkes wrote: > --- > libavcodec/dcadec.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c > index 187e172..0817018 100644 > --- a/libavcodec/dcadec.c > +++ b/libavcode

Re: [FFmpeg-devel] [PATCH] Revert "Merge commit '741b494fa8cd28a7d096349bac183893c236e3f9'"

2016-01-02 Thread Hendrik Leppkes
On Sat, Dec 19, 2015 at 10:35 AM, Michael Niedermayer wrote: > On Thu, Dec 17, 2015 at 02:46:40PM +0100, Hendrik Leppkes wrote: >> On Thu, Dec 17, 2015 at 2:06 PM, Michael Niedermayer >> wrote: >> > From: Michael Niedermayer >> > >> > This fixes a regression of the sample from Ticket 2371 >> >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/avf_showspectrum: add 4th and 5th root scaler

2016-01-02 Thread Ganesh Ajjanagadde
On Sat, Jan 2, 2016 at 9:53 AM, Paul B Mahol wrote: > ffmpeg | branch: master | Paul B Mahol | Sat Jan 2 > 18:10:03 2016 +0100| [af018d802d5f16ead8ce86b56e2316f0979e0105] | committer: > Paul B Mahol > > avfilter/avf_showspectrum: add 4th and 5th root scaler > > Signed-off-by: Paul B Mahol [..

Re: [FFmpeg-devel] [PATCH 2/3] ffmdec: cast state to unsigned for left shift

2016-01-02 Thread Michael Niedermayer
On Sat, Jan 02, 2016 at 05:12:13PM +0100, Andreas Cadhalpun wrote: > On 02.01.2016 16:56, Nicolas George wrote: > > Le tridi 13 nivôse, an CCXXIV, Andreas Cadhalpun a écrit : > >> This fixes ubsan runtime error: left shift by 8 places cannot be > >> represented in type 'int' > >> > >> Signed-off-by

Re: [FFmpeg-devel] [PATCH] dca: adjust decoding of the XBR extension for integer core decoding

2016-01-02 Thread Hendrik Leppkes
On Sat, Jan 2, 2016 at 6:17 PM, Michael Niedermayer wrote: > On Sat, Jan 02, 2016 at 03:05:41PM +0100, Hendrik Leppkes wrote: >> --- >> libavcodec/dcadec.c | 11 ++- >> 1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c >> index 18

Re: [FFmpeg-devel] [PATCH 1/3] ffmdec: reset packet_end in case of failure

2016-01-02 Thread Michael Niedermayer
On Sat, Jan 02, 2016 at 04:51:17PM +0100, Andreas Cadhalpun wrote: > This fixes segmentation faults caused by passing a packet_ptr of NULL to > memcpy. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/ffmdec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --gi

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: Always check buffer end before writing

2016-01-02 Thread Michael Niedermayer
On Fri, Jan 01, 2016 at 04:10:29PM +0100, Michael Niedermayer wrote: > From: Michael Niedermayer > > This causes a overall slowdown of 0.1 % (tested with mpeg4 single thread > encoding of matrixbench at QP=3) > > Signed-off-by: Michael Niedermayer > --- > libavcodec/put_bits.h | 20

Re: [FFmpeg-devel] [PATCH 1/3] ffmdec: reset packet_end in case of failure

2016-01-02 Thread Andreas Cadhalpun
On 02.01.2016 19:14, Michael Niedermayer wrote: > On Sat, Jan 02, 2016 at 04:51:17PM +0100, Andreas Cadhalpun wrote: >> This fixes segmentation faults caused by passing a packet_ptr of NULL to >> memcpy. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/ffmdec.c | 8 ++-- >> 1 file

[FFmpeg-devel] [PATCH] vorbisdec: avoid calling get_bits to read 0 bits

2016-01-02 Thread Andreas Cadhalpun
It's documented to only support reading 1-25 bits. Signed-off-by: Andreas Cadhalpun --- libavcodec/vorbisdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c index f773afa..1db8bd8 100644 --- a/libavcodec/vorbisdec.c +++ b/

Re: [FFmpeg-devel] [PATCH 2/3] ffmdec: cast state to unsigned for left shift

2016-01-02 Thread Andreas Cadhalpun
On 02.01.2016 18:59, Michael Niedermayer wrote: > On Sat, Jan 02, 2016 at 05:12:13PM +0100, Andreas Cadhalpun wrote: >> ffmdec.c |5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> 6c3ca0f947737208725d30a735deaea2a95531ba >> 0002-ffmdec-change-type-of-state-and-id-to-unsigned.pat

Re: [FFmpeg-devel] 2.9/3.0, 2.8.5, ...

2016-01-02 Thread James Almer
On 1/2/2016 1:16 PM, Andreas Cadhalpun wrote: > On 02.01.2016 17:12, James Almer wrote: >> On 1/2/2016 8:42 AM, Andreas Cadhalpun wrote: >>> On 01.01.2016 15:19, Michael Niedermayer wrote: Its a while since 2.8 so unless there are objections i will make a 2.9 or if people prefer a 3.0 wit

[FFmpeg-devel] [PATCH] avfilter/formats: fix leak of channel_layouts on error

2016-01-02 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/formats.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index a2b19e7..37d202f 100644 --- a/libavfilter/formats.c +++ b/libavfilter/formats.c @@ -507,7 +507,16 @@

Re: [FFmpeg-devel] [RFC] Disable compile-time tablegen for cbrt if total cycle count < 200000

2016-01-02 Thread Ganesh Ajjanagadde
On Fri, Jan 1, 2016 at 8:07 AM, Ganesh Ajjanagadde wrote: > Hi all, > > Motivated by a remark by Ronald: > https://ffmpeg.org/pipermail/ffmpeg-devel/2016-January/186200.html, > this is a request for comment on disabling compile time tablegen for > cbrt if the total cycle count < 20. Note that

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix leak of channel_layouts on error

2016-01-02 Thread Ganesh Ajjanagadde
On Sat, Jan 2, 2016 at 12:06 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/formats.c | 21 + > 1 file changed, 17 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/formats.c b/libavfilter/formats.c > index a2b19e7..37d202f 100644 > --- a/l

Re: [FFmpeg-devel] [RFC] Disable compile-time tablegen for cbrt if total cycle count < 200000

2016-01-02 Thread Ronald S. Bultje
Hi, On Sat, Jan 2, 2016 at 3:23 PM, Ganesh Ajjanagadde wrote: > On Fri, Jan 1, 2016 at 8:07 AM, Ganesh Ajjanagadde > wrote: > > Hi all, > > > > Motivated by a remark by Ronald: > > https://ffmpeg.org/pipermail/ffmpeg-devel/2016-January/186200.html, > > this is a request for comment on disabling

Re: [FFmpeg-devel] [RFC] Disable compile-time tablegen for cbrt if total cycle count < 200000

2016-01-02 Thread Ganesh Ajjanagadde
On Sat, Jan 2, 2016 at 1:02 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Jan 2, 2016 at 3:23 PM, Ganesh Ajjanagadde wrote: >> >> On Fri, Jan 1, 2016 at 8:07 AM, Ganesh Ajjanagadde >> wrote: >> > Hi all, >> > >> > Motivated by a remark by Ronald: >> > https://ffmpeg.org/pipermail/ffmpeg-devel/20

Re: [FFmpeg-devel] [RFC] Disable compile-time tablegen for cbrt if total cycle count < 200000

2016-01-02 Thread Ronald S. Bultje
Hi, On Sat, Jan 2, 2016 at 4:08 PM, Ganesh Ajjanagadde wrote: > On Sat, Jan 2, 2016 at 1:02 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Sat, Jan 2, 2016 at 3:23 PM, Ganesh Ajjanagadde > wrote: > >> > >> On Fri, Jan 1, 2016 at 8:07 AM, Ganesh Ajjanagadde > >> wrote: > >> > Hi all, > >> >

Re: [FFmpeg-devel] 2.9/3.0, 2.8.5, ...

2016-01-02 Thread Andreas Cadhalpun
On 02.01.2016 21:03, James Almer wrote: > On 1/2/2016 1:16 PM, Andreas Cadhalpun wrote: >> On 02.01.2016 17:12, James Almer wrote: >>> Some time ago it was argued that the ffmpeg version should for example >>> get a major bump when some considerable changes were made to the CLI >>> tools. Users tha

Re: [FFmpeg-devel] [RFC] Disable compile-time tablegen for cbrt if total cycle count < 200000

2016-01-02 Thread Ganesh Ajjanagadde
On Sat, Jan 2, 2016 at 1:10 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Jan 2, 2016 at 4:08 PM, Ganesh Ajjanagadde wrote: >> >> On Sat, Jan 2, 2016 at 1:02 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Sat, Jan 2, 2016 at 3:23 PM, Ganesh Ajjanagadde >> > wrote: >> >> >> >> On Fri, Jan

Re: [FFmpeg-devel] [libav-devel] [PATCH] vorbisdec: avoid calling get_bits to read 0 bits

2016-01-02 Thread Andreas Cadhalpun
On 02.01.2016 23:03, Luca Barbato wrote: > On 02/01/16 20:01, Andreas Cadhalpun wrote: >> It's documented to only support reading 1-25 bits. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/vorbisdec.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> > > When do we ge

[FFmpeg-devel] [WIP] SDL2 in ffplay

2016-01-02 Thread Marton Balint
Hi, To anybody who is interested, I have pushed my experimental SDL2 branch of ffplay to github. (https://github.com/cus/ffplay.git) SDL2 completely replaced SDL_Overlay with 3D textures, so with SDL2 it is possible to: - Use textures with odd width/height - Use RGB textures, not only YUV -

Re: [FFmpeg-devel] [libav-devel] [PATCH] vorbisdec: avoid calling get_bits to read 0 bits

2016-01-02 Thread Andreas Cadhalpun
On 02.01.2016 23:36, Luca Barbato wrote: > On 02/01/16 23:26, Andreas Cadhalpun wrote: >> On 02.01.2016 23:03, Luca Barbato wrote: >>> On 02/01/16 20:01, Andreas Cadhalpun wrote: It's documented to only support reading 1-25 bits. Signed-off-by: Andreas Cadhalpun --- lib

Re: [FFmpeg-devel] [WIP] SDL2 in ffplay

2016-01-02 Thread Andreas Cadhalpun
On 02.01.2016 23:27, Marton Balint wrote: > To anybody who is interested, I have pushed my experimental SDL2 branch of > ffplay > to github. (https://github.com/cus/ffplay.git) > > SDL2 completely replaced SDL_Overlay with 3D textures, so with SDL2 it is > possible to: > - Use textures with odd

[FFmpeg-devel] [PATCH 1/3] get_bits: add get_bitsz for reading 0-25 bits

2016-01-02 Thread Andreas Cadhalpun
This can be used to simplify code in a couple of places. Signed-off-by: Andreas Cadhalpun --- libavcodec/get_bits.h | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h index 0a61c80..f984d3e 100644 --- a/libavcodec/get_bits.h +++ b/libavcodec

[FFmpeg-devel] [PATCH 2/3] vorbisdec: replace get_bits with get_bitsz where n can be 0

2016-01-02 Thread Andreas Cadhalpun
get_bits is documented to only support reading 1-25 bits. get_bitsz was added for this purpose. Signed-off-by: Andreas Cadhalpun --- libavcodec/vorbisdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c index f773afa..9ba0b

[FFmpeg-devel] [PATCH 3/3] lavc: use get_bitsz to simplify the code

2016-01-02 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavcodec/atrac3plus.c| 13 + libavcodec/escape124.c | 2 +- libavcodec/hevc.c | 2 +- libavcodec/hevc_parser.c | 2 +- libavcodec/mpegaudiodec_template.c | 7 --- libavcodec/wavpack.c

Re: [FFmpeg-devel] [libav-devel] [PATCH] vorbisdec: avoid calling get_bits to read 0 bits

2016-01-02 Thread Andreas Cadhalpun
On 03.01.2016 00:16, Luca Barbato wrote: > On 02/01/16 23:46, Andreas Cadhalpun wrote: >> Maybe, but on the other hand there are only about a dozen or so places in >> the complete code base that would benefit from that. >> >> Do you think that's enough to justify adding another helper function? >

Re: [FFmpeg-devel] [WIP] SDL2 in ffplay

2016-01-02 Thread Ganesh Ajjanagadde
On Sat, Jan 2, 2016 at 2:50 PM, Andreas Cadhalpun wrote: > On 02.01.2016 23:27, Marton Balint wrote: [...] >> >> Because of the relatively huge differences between SDL and SDL2, it seems >> unreasonable >> to work toward an ffplay wich supports both at the same time, so if we do >> want to switc

Re: [FFmpeg-devel] [PATCH 1/3] get_bits: add get_bitsz for reading 0-25 bits

2016-01-02 Thread Michael Niedermayer
On Sun, Jan 03, 2016 at 01:35:39AM +0100, Andreas Cadhalpun wrote: > This can be used to simplify code in a couple of places. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/get_bits.h | 8 > 1 file changed, 8 insertions(+) ok thx [...] -- Michael GnuPG fingerprint: 9FF2

Re: [FFmpeg-devel] [PATCH 1/3] get_bits: add get_bitsz for reading 0-25 bits

2016-01-02 Thread Michael Niedermayer
On Sun, Jan 03, 2016 at 01:35:39AM +0100, Andreas Cadhalpun wrote: > This can be used to simplify code in a couple of places. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/get_bits.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libavcodec/get_bits.h b/libavcodec/ge

Re: [FFmpeg-devel] [PATCH 3/3] lavc: use get_bitsz to simplify the code

2016-01-02 Thread Michael Niedermayer
On Sun, Jan 03, 2016 at 01:36:49AM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/atrac3plus.c| 13 + > libavcodec/escape124.c | 2 +- > libavcodec/hevc.c | 2 +- > libavcodec/hevc_parser.c |

Re: [FFmpeg-devel] [PATCH 2/3] vorbisdec: replace get_bits with get_bitsz where n can be 0

2016-01-02 Thread Michael Niedermayer
On Sun, Jan 03, 2016 at 01:36:13AM +0100, Andreas Cadhalpun wrote: > get_bits is documented to only support reading 1-25 bits. > get_bitsz was added for this purpose. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/vorbisdec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [FFmpeg-devel] [RFC v5] libavcodec: add a native Daala decoder

2016-01-02 Thread James Almer
On 1/2/2016 2:56 PM, Rostislav Pehlivanov wrote: > diff --git a/libavcodec/daala_pvq.h b/libavcodec/daala_pvq.h > new file mode 100644 > index 000..23c833e > --- /dev/null > +++ b/libavcodec/daala_pvq.h [...] > +/* q: quantizer, qm = bitstream_header->pvq_qm[p] */ > +static void daalapvq_deco