On 1/2/2016 2:56 PM, Rostislav Pehlivanov wrote: > diff --git a/libavcodec/daala_pvq.h b/libavcodec/daala_pvq.h > new file mode 100644 > index 0000000..23c833e > --- /dev/null > +++ b/libavcodec/daala_pvq.h
[...] > +/* q: quantizer, qm = bitstream_header->pvq_qm[p] */ > +static void daalapvq_decode(DaalaEntropy *e, DaalaPVQ *pvq, > + DaalaBitstreamHeader *b, dctcoef *ref, > + dctcoef *out, int q, uint8_t *pvq_qm, uint8_t p, > + enum DaalaBsize bsize, const double *beta, > + int qm_off, int bskip) I'd say move every function from this header to a new daala_pvq.c file, then rename the above function to ff_daalapvq_decode() and make it non static, since it's the only one used directly from daaladec.c. Keep only the defines, the DaalaPVQ struct definition and a prototype for the above function here. And no need to resend the patch just for this. it's cosmetic, so wait until you get other (and real) reviews. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
