Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-06 Thread Nicolas George
Le decadi 20 fructidor, an CCXXIII, Ronald S. Bultje a écrit : > I want you to imagine for a second that a user downloads one of these UIs > that is essentially ffmpeg.exe or avconv.exe with some extras, and tries to > use it, and sees a user-equivalent of the above. Media files don't load, > color

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-06 Thread Carl Eugen Hoyos
Ronald S. Bultje gmail.com> writes: > On Sun, Sep 6, 2015 at 8:46 AM, Carl Eugen Hoyos wrote: > > > Ronald S. Bultje gmail.com> writes: > > > > > Are there users that care about this feature? > > > > > Why didn't they complain that it didn't work? > > > > Why do you think it doesn't work? > >

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-06 Thread Ronald S. Bultje
Hi, On Sun, Sep 6, 2015 at 8:46 AM, Carl Eugen Hoyos wrote: > Ronald S. Bultje gmail.com> writes: > > > Are there users that care about this feature? > > > Why didn't they complain that it didn't work? > > Why do you think it doesn't work? "(Just for reference, I tested running avconv's FATE

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-06 Thread Carl Eugen Hoyos
Ronald S. Bultje gmail.com> writes: > Are there users that care about this feature? > Why didn't they complain that it didn't work? Why do you think it doesn't work? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-06 Thread Ronald S. Bultje
Hi Nicolas, On Sun, Sep 6, 2015 at 3:55 AM, Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, Ronald S. Bultje a écrit : > > Ah, ok, so we did test it, and it didn't work. That sounds like an > amazing > > reason to remove it. Do we really want people to think corresponds to > > "FFmpe

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-06 Thread Nicolas George
Le decadi 20 fructidor, an CCXXIII, Clement Boesch a écrit : > To me, losing the ABI compatibility should not be an issue, because so far > it seems no downstream trusted it. To my understanding, it was introduced > as a way to simplify distribution work into integrating both FFmpeg and > Libav. Th

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-06 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, Ronald S. Bultje a écrit : > Ah, ok, so we did test it, and it didn't work. That sounds like an amazing > reason to remove it. Do we really want people to think corresponds to > "FFmpeg quality"? I would be embarrassed if people pointed this out to me. > > When

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Clément Bœsch
On Sat, Sep 05, 2015 at 11:55:17PM +0200, Nicolas George wrote: [...] > I have no strong opinion on the choice itself, actually. Same here. Though, I tend to agree with the removal as long as it is properly explained. To me, losing the ABI compatibility should not be an issue, because so far it

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Ronald S. Bultje
Hi, On Sat, Sep 5, 2015 at 5:55 PM, Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, Ronald S. Bultje a écrit : > > > If they go, we will NEVER have compat, period. > > > Is that what you want? > > Yes. > > If that is what the majority decides, after understanding the issue and > pond

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Carl Eugen Hoyos
Nicolas George nsup.org> writes: > Just for reference, I tested running avconv's FATE with > FFmpeg's libraries: a lot of tests fail, without surprise > (the libraries do not behave the same, that is the whole > point; and apparently avconv thinks that EOF is a filtering > error), but quite a

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, Ronald S. Bultje a écrit : > > If they go, we will NEVER have compat, period. > > Is that what you want? > Yes. If that is what the majority decides, after understanding the issue and pondering the question, then fine. The change of policy caused by this patch

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Carl Eugen Hoyos
Ronald S. Bultje gmail.com> writes: > I don't know what "it" is, but I don't believe we have ABI > compat until I see a fate station continuously testing it. fate (current fate) cannot test it: There are no reference values that could be used. Carl Eugen _

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Paul B Mahol
On 9/5/15, Ronald S. Bultje wrote: > Hi, > > On Sat, Sep 5, 2015 at 4:02 PM, Nicolas George wrote: > >> Le nonidi 19 fructidor, an CCXXIII, Ronald S. Bultje a ecrit : >> > I don't know what "it" is, but I don't believe we have ABI compat until >> > I >> > see a fate station continuously testing i

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Ronald S. Bultje
Hi, On Sat, Sep 5, 2015 at 4:02 PM, Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, Ronald S. Bultje a écrit : > > I don't know what "it" is, but I don't believe we have ABI compat until I > > see a fate station continuously testing it. > > You are answering the wrong question again.

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, Ronald S. Bultje a écrit : > I don't know what "it" is, but I don't believe we have ABI compat until I > see a fate station continuously testing it. You are answering the wrong question again. We are at a major bump, we can do whatever we want. The question is

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Ronald S. Bultje
Hi, On Sat, Sep 5, 2015 at 2:58 PM, Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, James Almer a écrit : > > Without this option, the AVPixelFormat enum values in libavutil/pixfmt.h > > don't match between projects. It's absolutely needed for abi > > compatibility, so knowing if any

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, James Almer a écrit : > Without this option, the AVPixelFormat enum values in libavutil/pixfmt.h > don't match between projects. It's absolutely needed for abi > compatibility, so knowing if anyone used it is important because it will > show if said compatibility

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Paul B Mahol
On 9/5/15, Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, Paul B Mahol a ecrit : >> I'm all for this > > All for WHAT, please? Stop ABI compatibility? If it is very big mess to support 10% ABI compatibility I'm all for removing such incomplete messy support. _

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread wm4
On Sat, 5 Sep 2015 20:12:03 +0200 Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, James Almer a écrit : > > Is there a distro shipping both that uses the > > --enable-incompatible-libav-abi > > option to compile ffmpeg? Or did unofficial repositories for distros that > > used > > to

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread James Almer
On 9/5/2015 3:12 PM, Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, James Almer a écrit : >> Is there a distro shipping both that uses the --enable-incompatible-libav-abi >> option to compile ffmpeg? Or did unofficial repositories for distros that >> used >> to ship libav only use it

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Ronald S. Bultje
Hi Nicolas, On Sat, Sep 5, 2015 at 1:48 PM, Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, Ronald S. Bultje a écrit : > > For something important like this, we'd better have continuous (not > > one-off, or "it worked for me on this one file 6 months ago") tests that > > ensure it wo

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, wm4 a écrit : > You don't see all the madness this causes for ffmpeg development? I see it very well, but it was the project's policy. You never liked it, but it was the policy nonetheless. YOU ARE NOT ALLOWED TO SNEAKILY CHANGE THE PROJECT'S POLICY. If you wa

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread wm4
On Sat, 5 Sep 2015 20:06:23 +0200 Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, Paul B Mahol a écrit : > > I'm all for this > > All for WHAT, please? Stop ABI compatibility? > > Regards, > You don't see all the madness this causes for ffmpeg development?

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, wm4 a écrit : > Possibly if you enable this configure option. But even then, it was > never tested thoroughly, and only tested by 1 person. Without this > option enabled, no we aren't. For the most part, yes, we are ABI compatible, even without the option. Your

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, James Almer a écrit : > Is there a distro shipping both that uses the --enable-incompatible-libav-abi > option to compile ffmpeg? Or did unofficial repositories for distros that used > to ship libav only use it for that matter? This option is not the issue. The

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread wm4
On Sat, 5 Sep 2015 20:04:23 +0200 Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, wm4 a écrit : > > This feature was never used. > > Get the facts straight please. FFmpeg's libraries were ABI-compatible with > the fork's for most of the time. > > Regards, > Possibly if you enable

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread James Almer
On 9/5/2015 3:04 PM, Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, wm4 a écrit : >> This feature was never used. > > Get the facts straight please. FFmpeg's libraries were ABI-compatible with > the fork's for most of the time. > > Regards, Is there a distro shipping both that uses

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, Paul B Mahol a écrit : > I'm all for this All for WHAT, please? Stop ABI compatibility? Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.o

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Paul B Mahol
Dana 5. 9. 2015. 19:15 osoba "wm4" napisala je: > > --- > I bet this fixes some bugs, because some code compares codec IDs with > AV_CODEC_ID_FIRST_AUDIO numerically! > --- > libavcodec/avcodec.h | 150 +-- > libavcodec/utils.c | 6 --- > 2 file

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, wm4 a écrit : > This feature was never used. Get the facts straight please. FFmpeg's libraries were ABI-compatible with the fork's for most of the time. Regards, -- Nicolas George signature.asc Description: Digital signature __

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread wm4
On Sat, 5 Sep 2015 19:48:17 +0200 Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, Ronald S. Bultje a écrit : > > For something important like this, we'd better have continuous (not > > one-off, or "it worked for me on this one file 6 months ago") tests that > > ensure it works for rea

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, Ronald S. Bultje a écrit : > For something important like this, we'd better have continuous (not > one-off, or "it worked for me on this one file 6 months ago") tests that > ensure it works for real in practice. Did we ever have such tests? I do not think we eve

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Ronald S. Bultje
Hi, On Sat, Sep 5, 2015 at 1:30 PM, Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, wm4 a écrit : > > Nothing. We don't need to be ABI compatible with Libav. > > There was effort for it, whether it pleased you or not. If you want to stop > them, you must discuss it openly. Sneaking i

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, wm4 a écrit : > I don't know what you want. Honesty: this patch series should have been clearly labelled "drop efforts at ABI compatibility with the fork". > For the record, this ABI compat feature ended up unused. This is not true, ABI compatibility was achie

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread wm4
On Sat, 5 Sep 2015 19:30:46 +0200 Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, wm4 a écrit : > > Nothing. We don't need to be ABI compatible with Libav. > > There was effort for it, whether it pleased you or not. If you want to stop > them, you must discuss it openly. Sneaking it

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, wm4 a écrit : > Nothing. We don't need to be ABI compatible with Libav. There was effort for it, whether it pleased you or not. If you want to stop them, you must discuss it openly. Sneaking it in a seemingly unrelated and technical patch is dishonest. Regards,

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread wm4
On Sat, 5 Sep 2015 19:21:28 +0200 Nicolas George wrote: > Le nonidi 19 fructidor, an CCXXIII, wm4 a écrit : > > --- > > I bet this fixes some bugs, because some code compares codec IDs with > > AV_CODEC_ID_FIRST_AUDIO numerically! > > --- > > libavcodec/avcodec.h | 150 > > +

Re: [FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread Nicolas George
Le nonidi 19 fructidor, an CCXXIII, wm4 a écrit : > --- > I bet this fixes some bugs, because some code compares codec IDs with > AV_CODEC_ID_FIRST_AUDIO numerically! > --- > libavcodec/avcodec.h | 150 > +-- > libavcodec/utils.c | 6 --- > 2 fi

[FFmpeg-devel] [PATCH 3/3] lavc: remove Libav ABI compat hacks

2015-09-05 Thread wm4
--- I bet this fixes some bugs, because some code compares codec IDs with AV_CODEC_ID_FIRST_AUDIO numerically! --- libavcodec/avcodec.h | 150 +-- libavcodec/utils.c | 6 --- 2 files changed, 75 insertions(+), 81 deletions(-) diff --git a/libavc