Re: [edk2-devel] [PATCH v9 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

On Mon, Dec 11, 2023 at 1:12 PM Sunil V L wrote: > > On Sun, Dec 10, 2023 at 07:51:12PM +0530, Dhaval Sharma wrote: [...] > > nit: Can we pick a log style here? Like : > > In this case, "CacheOpCacheRange: Performing ...". It's just prettier > > and more greppable. > > My interpretation of this w

Re: [edk2-devel] [PATCH v9 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

On Mon, Dec 11, 2023 at 3:20 PM Sunil V L wrote: > > On Mon, Dec 11, 2023 at 03:09:19PM +, Pedro Falcato wrote: > > On Mon, Dec 11, 2023 at 1:12 PM Sunil V L wrote: > > > > > > On Sun, Dec 10, 2023 at 07:51:12PM +0530, Dhaval Sharma wrote: > > [...] >

Re: [edk2-devel] [PATCH v9 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

On Mon, Dec 4, 2023 at 8:30 AM Dhaval Sharma wrote: > > Use newly defined cache management operations for RISC-V where possible > It builds up on the support added for RISC-V cache management > instructions in BaseLib. > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Laszlo Erse

Re: [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard functions

On Mon, Dec 11, 2023 at 3:40 PM Jeff Brasen via groups.io wrote: > Jeff, You're missing CC's on this patch. Also, you should probably send the 3 patches in a single series, since they're all related. > Rename the standard functions in the LibFdtSupport to remove conflicts > with other libraries

Re: [edk2-devel] [RFC PATCH] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses

On Thu, Dec 7, 2023 at 1:24 PM Mike Maslenkin wrote: > > URI is generated based on the RedfishLocation containing an ASCII string > representing the IP address. So, in the case of IPv4 the canonical > representation of an IPv4 address was inserted into the resulting Unicode > string i.e: "http{,s}

Re: [edk2-devel] [RFC PATCH] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses

On Thu, Dec 7, 2023 at 1:24 PM Mike Maslenkin wrote: > [...] > +DiscoveredInstance->Information.Location = (CHAR16 *)AllocatePool > (AllocSize); Forgot to mention: don't cast void *! It's completely unneeded in C and may hide real problems (implicit declarations); it also clutters code.

Re: [edk2-devel] [PATCH] BaseTools/GenFw: Change opcode when converting ADR to ADRP

On Wed, Dec 13, 2023 at 5:31 PM Ard Biesheuvel wrote: > > On Wed, 13 Dec 2023 at 15:58, Jake Garver wrote: > > > > Totally understand and agree, Ard. > > > > In the meantime, I've now experienced the issue with Ubuntu22's GCC 12.3. > > Originally, we didn't see the issue on this toolchain, but

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

On Thu, Dec 7, 2023 at 9:08 AM Yuwei Chen wrote: > > Hi Liming, > > > > Is this feature been tested and reviewed these two weeks? 😊 Two questions: 1) What testing strategy do you have to test for regressions in such a huge rewrite? 2) What's the point in shipping this to upstream if you're not a

Re: [edk2-devel] [PATCH 1/1] MdePkg: Updated the definition of FileName on EFI_FILE_INFO

On Fri, Dec 22, 2023 at 6:40 AM SuqiangX Ren wrote: > > Add the description of FileName to align with UEFI spec 2.10. > > REF: UEFI spec 2.10 Table 13.5.16 > > Signed-off-by: RenSuqiang > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Yi Li > --- > MdePkg/Include/Guid/FileInf

Re: [edk2-devel] [PATCH] MdePkg/BaseLib:Fix boot DxeCore hang on riscv platform

On Tue, Dec 26, 2023 at 2:14 PM 王洋 wrote: > > From f15d405067860a8087c5eb4080bc3e08ca5e0e21 Mon Sep 17 00:00:00 2001 > From: wangyang > Date: Wed, 20 Dec 2023 20:27:42 +0800 > Subject: [PATCH] MdePkg/BaseLib:Fix boot DxeCore hang on riscv platform > > For scene of > HandOffToDxeCore()->SwitchStac

Re: [edk2-devel] [PATCH 0/4] RISC-V: Add support for Sstc extension

On Wed, Jan 3, 2024 at 1:59 PM Sunil V L wrote: > > This series adds the support for RISV-V Sstc extension in EDK2 timer nit: RISC-V > implementation. Sstc extension allows S-mode software to program the > timer directly without using SBI calls. > > Currently, PCD variable is used to detect wheth

Re: [edk2-devel] [PATCH v10 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

On Mon, Jan 8, 2024 at 4:23 PM Dhaval Sharma wrote: > > Hi yangcheng/Pedro, +CC a bunch of relevant people Hi, (FYI you did not CC me) Looking at yangcheng's example: Status = PrepareDmaData (gpIdmacDesc, Length, Buffer); <-- We write to the IDMAC desc if (EFI_ERROR (Status)) { goto ou

Re: [edk2-devel] Memory Attribute for depex section

On Wed, Jan 10, 2024 at 1:45 PM Laszlo Ersek wrote: > > (+ Andrew) > > On 1/10/24 14:09, Laszlo Ersek wrote: > > > I think that keeping the depex section read-only is valuable, so I'd > > rule out #2. I'd also not start with option #1 -- copying the depex to > > heap memory, just so this optimizat

Re: [edk2-devel] Memory Attribute for depex section

On Thu, Jan 11, 2024 at 8:46 AM Laszlo Ersek wrote: > > On 1/10/24 22:50, Pedro Falcato wrote: > > On Wed, Jan 10, 2024 at 1:45 PM Laszlo Ersek > > wrote: > >> > >> (+ Andrew) > >> > >> On 1/10/24 14:09, Laszlo Ersek wrote: > >> >

Re: [edk2-devel] Memory Attribute for depex section

On Fri, Jan 12, 2024 at 9:35 AM Laszlo Ersek wrote: > > On 1/12/24 03:10, Pedro Falcato wrote: > > My idea was to make each handle an index - like a file descriptor - > > AFAIK there's no reason why it *needs* to be an actual pointer. > > We'd allocate indices

Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver

On Mon, Jan 15, 2024 at 8:04 AM Ni, Ray wrote: > > This commit only duplicates the OvmfPkg/LocalApicTimerDxe. > Following commits will enhance the driver. Hi, Please describe why you're doing this change. i.e what's your use case for LocalApicTimerDxe, and why are you duplicating this instead of

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap

On Thu, Jan 11, 2024 at 8:56 AM Laszlo Ersek wrote: > > On 1/11/24 03:03, Ni, Ray wrote: > >> This function is incredibly complicated, so reviewing this patch is > >> hard, even after reading the bugzilla ticket. > >> > >> The commit message is useless. It should contain a brief description of > >

Re: [edk2-devel] [PATCH v1 1/1] MdePkg/BaseCacheMaintenanceLib: RV64 replace asserts with logs

On Thu, Jan 18, 2024 at 9:50 AM Dhaval wrote: > > Some platforms do not implement cache management operations. Especially > for DMA drivers have code to manage data cache. The code seem to depend > on the underlying CPU/cache drivers to enact functionality and simply > return if such functionality

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap

On Thu, Jan 18, 2024 at 2:21 AM Liu, Zhiguang wrote: > > Thanks Laszlo for the comment, I will send a new version of patch to fix this. > > Also include Pedro to see if Pedro have more comments. The patch's subject really doesn't describe the fix (describe what you did in the patch/commit, don't

Re: [edk2-devel] [PATCH v1 1/1] MdePkg/BaseCacheMaintenanceLib: RV64 replace asserts with logs

On Tue, Jan 23, 2024 at 6:13 AM Dhaval Sharma wrote: > > Sunil, > I thought "WriteBackDataCacheRange not supported" is more explicit over "CMO > not available". > > @Pedro Falcato For the example you mentioned, is your concern more about > someone not b

Re: [edk2-devel] [PATCH 00/14] Security Patches for EDK II Network Stack

On Wed, Jan 24, 2024 at 5:20 AM Doug Flick via groups.io wrote: > > The security patches contained in this series with the exception of > "MdePkg/Test: Add gRT_GetTime Google Test Mock" and > "NetworkPkg: : Adds a SecurityFix.yaml file" have been reviewed > during GHSA-hc6x-cw6p-gj7h infosec revie

Re: [edk2-devel] [PATCH 07/14] NetworkPkg: Ip6Dxe: SECURITY PATCH CVE-2023-45232 Patch

On Wed, Jan 24, 2024 at 5:20 AM Doug Flick via groups.io wrote: > > From: Doug Flick > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4537 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4538 > > SECURITY PATCH - Patch > > TCBZ4537 > CVE-2023-45232 > CVSS 7.5 : CVSS:3.1/AV:N/AC:L/PR:N/

Re: [edk2-devel] [PATCH v2 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process.

On Thu, Jan 25, 2024 at 8:23 AM Gerd Hoffmann wrote: > > Specifically before running lzma uncompress of the main firmware volume. > This is needed to make sure caching is enabled, otherwise the uncompress > can be extremely slow. > > Adapt the ASSERTs and MTRR setup in PlatformInitLib to the chang

Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

On Wed, Oct 18, 2023 at 12:16 PM Marcin Juszkiewicz wrote: > > W dniu 18.10.2023 o 12:32, Nhi Pham pisze: > > Acked-by: Nhi Pham > > > > Nit: I think you want to run uncrustify for Patch 3 as well :) > > Done, will check other changes too. > > I have a strong feeling that Qemu part of EDK2 needs

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

On Wed, Oct 18, 2023 at 12:20 PM Laszlo Ersek wrote: > > On 10/18/23 12:33, Gerd Hoffmann wrote: > > VirtiofsDxe throws an error in case the caller tries to open a file or > > directory using an handle with is not a directory, claiming that opening > > something relative to a file does not make se

Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

On Wed, Oct 18, 2023 at 12:28 PM Marcin Juszkiewicz wrote: > > W dniu 18.10.2023 o 13:23, Pedro Falcato pisze: > > On Wed, Oct 18, 2023 at 12:16 PM Marcin Juszkiewicz > > wrote: > >> > >> W dniu 18.10.2023 o 12:32, Nhi Pham pisze: > >>> Acked-by

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

On Wed, Oct 18, 2023 at 1:20 PM Laszlo Ersek wrote: > > On 10/18/23 13:33, Pedro Falcato wrote: > > On Wed, Oct 18, 2023 at 12:20 PM Laszlo Ersek wrote: > >> > >> On 10/18/23 12:33, Gerd Hoffmann wrote: > >>> VirtiofsDxe throws an error in case the call

Re: [edk2-devel] [PATCH] OvmfPkg/VirtioFsDxe: tolerate opening an abs. pathname rel. to a reg. file

__func__, >VirtioFs->Label, >VirtioFsFile->CanonicalPathname, >FileName >)); > -return EFI_INVALID_PARAMETER; > +if (!BugCompat) { > + return EFI_INVALID_PARAMETER; > +} >} > >// >// All

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Enhance StdLib for supporting Aarch64 and ARM

On Fri, Oct 20, 2023 at 3:04 PM Jayaprakash, N wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4570 > > This commit is for processing the below PR on edk2-libc repo > https://github.com/tianocore/edk2-libc/pull/3 > These are the changes introduced to StdLib to build > an application

Re: [edk2-devel] [PATCH] OvmfPkg/VirtioFsDxe: tolerate opening an abs. pathname rel. to a reg. file

On Thu, Oct 19, 2023 at 3:16 PM Laszlo Ersek wrote: > > On 10/19/23 15:50, Pedro Falcato wrote: > > On Wed, Oct 18, 2023 at 6:24 PM Laszlo Ersek wrote: > >> > >> Referring to a file relative to a regular file makes no sense (or at least > >> it cannot be i

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions.

On Mon, Oct 23, 2023 at 3:18 PM Nickle Wang via groups.io wrote: > > There are two definitions for below functions in RedfishCrtLib.h. Create > this change to remote duplicated functions. > Function list: strcmp(), strncmp(), strncpy(), strcat(), strchr(), > strcasecmp(), strstr(), memcmp(), memse

Re: [edk2-devel] [PATCH v6 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

On Sat, Oct 21, 2023 at 6:33 PM Dhaval Sharma wrote: > > Use newly defined cache management operations for RISC-V where possible > It builds up on the support added for RISC-V cache management > instructions in BaseLib. > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Laszlo Ers

Re: [edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove Isaac Oram's email address

On Wed, Oct 25, 2023 at 9:35 AM Laszlo Ersek wrote: > > Email to Isaac's address bounces ("5.1.0 Address > rejected"); remove that address. FWIW, there's a patch in the ML list (by Nate IIRC?) that never got merged that addresses this very issue, with proposed replacements. -- Pedro -=-=-=-=

Re: [edk2-devel] [PATCH] BaseTools/GenFw: Change opcode when converting ADR to ADRP

On Thu, Oct 26, 2023 at 4:32 PM Jake Garver via groups.io wrote: > > In the R_AARCH64_ADR_GOT_PAGE case on AARCH64, be sure to change the > opcode to ADRP. Prior to this change, we updated the address, but not > the opcode. > > This resolves an issue experienced when building a StandaloneMm image

Re: [edk2-devel] [PATCH] BaseTools/GenFw: Change opcode when converting ADR to ADRP

t;. "PC-relative addressing" only applies to _ADR_PREL_PG_HI21...) Maybe it's just not a documented relaxation? Or does it relax as _ADR_GOT_PAGE -> _ADR_PREL_PG_HI21 -> _ADR_PREL_LO21 without updating internal relocation info? > > There are other relaxations that also confuse

Re: [edk2-devel] [PATCH] BaseTools/GenFw: Change opcode when converting ADR to ADRP

On Fri, Oct 27, 2023 at 3:09 PM Jake Garver via groups.io wrote: > > Hi Ard: > > > Can you double check the object file? I suspect this is a linker relaxation > > not a compiler issue. > > With LTO in play, is there a way to check the object file? It's not in > aarch64 assembly. Unless you pas

Re: [edk2-devel] [PATCH] BaseTools/GenFw: Change opcode when converting ADR to ADRP

On Fri, Oct 27, 2023 at 3:13 PM Ard Biesheuvel wrote: > > On Fri, 27 Oct 2023 at 16:09, Jake Garver via groups.io > wrote: > > > > Hi Ard: > > > > > Can you double check the object file? I suspect this is a linker > > > relaxation not a compiler issue. > > > > With LTO in play, is there a way to

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On Sat, Oct 28, 2023 at 8:23 PM Michael D Kinney wrote: > > Over the past few months, all the of the Maintainers and > Reviewers listed in Maintainers.txt have been contacted to make > sure Maintainers.txt accurately represents the TianoCore > community members that are actively participating in t

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On Sun, Oct 29, 2023 at 4:25 PM Yao, Jiewen wrote: > > OK. Maintainer should do code review. I have no doubt on that. > > My confusion is about "reviewer" role. What is criteria and what is > responsibility? > > Are you saying that "reviewer" just means that someone raised the hand and > said: "

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On Sun, Oct 29, 2023 at 1:30 PM Laszlo Ersek wrote: > > On 10/29/23 03:16, Pedro Falcato wrote: > >> diff --git a/Maintainers.txt b/Maintainers.txt > >> index 3f40cdeb5554..2b03ccbe54aa 100644 > >> --- a/Maintainers.txt > >> +++ b/Maintainers.

Re: [edk2-devel] [PATCH v7 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

On Sun, Oct 29, 2023 at 2:46 PM Dhaval Sharma wrote: > > Use newly defined cache management operations for RISC-V where possible > It builds up on the support added for RISC-V cache management > instructions in BaseLib. > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Laszlo Ers

Re: [edk2-devel] [PATCH v7 3/5] MdePkg: Implement RISC-V Cache Management Operations

On Sun, Oct 29, 2023 at 2:46 PM Dhaval Sharma wrote: > > Implement Cache Management Operations (CMO) defined by > RISC-V spec https://github.com/riscv/riscv-CMOs. > > Notes: > 1. CMO only supports block based Operations. Meaning cache >flush/invd/clean Operations are not available for the enti

Re: [edk2-devel] [PATCH v7 0/5] Cache Management Operations Support For RISC-V

are added. > 3. Add the new cache maintenance operations to BaseLib, including the > new assembly instruction encodings. > 4. Update BaseCacheMaintenanceLib (utilizing the new BaseLib primitives) > 5. Add platform level PCD to allow overriding of RISC-V features. > With or

Re: [edk2-devel] [PATCH v7 3/5] MdePkg: Implement RISC-V Cache Management Operations

On Mon, Oct 30, 2023 at 9:38 AM Laszlo Ersek wrote: > > On 10/29/23 20:12, Pedro Falcato wrote: > > On Sun, Oct 29, 2023 at 2:46 PM Dhaval Sharma wrote: > >> > >> Implement Cache Management Operations (CMO) defined by > >> RISC-V spec https://github.com/ri

Re: [edk2-devel] [PATCH v7 3/5] MdePkg: Implement RISC-V Cache Management Operations

On Tue, Oct 31, 2023 at 9:55 AM Dhaval Sharma wrote: > > I am posting an update on behalf of Jingyu as he had trouble with posting. > CC'ing him here: > In summary what we have verified so far: > > I have verified that instructions/op codes are okay. I have also verified on > Qemu that functiona

Re: [edk2-devel] CodeQL and Apache Licensed Files

On Sat, Oct 28, 2023 at 12:51 PM Laszlo Ersek wrote: > > On 10/27/23 23:11, Michael Kubacki wrote: > > I'd like to bring attention to Apache License 2.0 code in the CodeQL > > series I sent to the mailing list for steward review. > > > > In particular, the files in the BaseTools/Plugin/CodeQL/anal

Re: [edk2-devel] CodeQL and Apache Licensed Files

On Tue, Oct 31, 2023 at 7:43 PM Kinney, Michael D wrote: > > Hi Pedro, > > SPDX is only for licenses, not copyrights. IANAL, but several FOSS projects (including Linux) have generally replaced the "Copyright (c) ..." verbiage with SPDX. I assume there has to be some legal basis for this, although

Re: [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations

+CC ARM maintainers On Wed, Nov 1, 2023 at 12:40 AM Joe L wrote: > > Hello, > > During experimentation on an AARCH64 platform with a PCIe endpoint that > supports option ROM, it was found that the ordering of transactions between > ECAM (Cfg-Write) and MMIO (Mem-Read) is not preserved by the CH

Re: [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations

On Wed, Nov 1, 2023 at 9:51 PM Michael Brown wrote: > > On 01/11/2023 20:17, Joe L wrote: > > Thanks for the discussion, > > > > Are we saying that DataSynchronizationBarrier () before the return > > from RootBridgeIoPciAccess() is not strong enough to determine that > > the final ECAM write would

Re: [edk2-devel] [PATCH] BaseTools/GenFw: Change opcode when converting ADR to ADRP

On Thu, Nov 2, 2023 at 11:47 AM Jake Garver wrote: > > Ard, Pedro, > > How would you like to proceed here? > > Do nothing. Treat it as a toolchain bug and not attempt a work-around. > Practically speaking, this means the Ubuntu20 container at > https://github.com/tianocore/containers cannot be

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Non-zero start/stop values in XhcGetElapsedTicks

On Thu, Nov 2, 2023 at 11:28 AM Laszlo Ersek wrote: > > On 11/1/23 02:12, Mike Maslenkin wrote: > > On Tue, Oct 31, 2023 at 7:52 PM Henz, Patrick wrote: > >> > >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4578 > >> > >> The implementation of XhcGetElapsedTicks did not account for > >> no

Re: [edk2-devel] [PATCH v1 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list

> Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Pedro Falcato > Cc: Sean Brogan > Signed-off-by: Michael Kubacki > --- > ReadMe.rst | 18 +++--- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/ReadMe.rst b/ReadMe.

Re: [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list

c: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Pedro Falcato > Cc: Sean Brogan > Signed-off-by: Michael Kubacki > Reviewed-by: Laszlo Ersek > Acked-by: Pedro Falcato > --- > > Notes: > v2 changes: > > - Add R-b and A-b tags

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

On Mon, Nov 13, 2023 at 11:58 AM Laszlo Ersek wrote: > > Hi Michael, > > recently I encountered an uncrustify failure on github. > > The reason was that my local uncrustify was *more recent* (73.0.8) than > the one we use in edk2 CI (which is 73.0.3, per the edk2 file > ".pytool/Plugin/UncrustifyC

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

On Mon, Nov 13, 2023 at 7:07 PM Pedro Falcato via groups.io wrote: > > On Mon, Nov 13, 2023 at 11:58 AM Laszlo Ersek wrote: > > > > Hi Michael, > > > > recently I encountered an uncrustify failure on github. > > > > The reason was that my local uncrusti

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote: > > On 11/13/2023 1:08 PM, Michael Kubacki wrote: > > Yes. I just did it. It is relatively minor and impacts expected code > > areas. > > > > https://github.com/tianocore/edk2/pull/5043/files > > > Could you update .git-blame-ignore-revs please?

Re: [edk2-devel] [PATCH v2 15/30] EmbeddedPkg: Add PcdPrePiCpuIoSize width for LOONGARCH64

On Wed, Nov 15, 2023 at 6:55 PM Leif Lindholm wrote: > > On 2023-11-06 03:29, Chao Li wrote: > > Added LoongArch64 architecture CPU IO width. > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=4584 > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Abner Chang > > Cc: Daniel Schaefer

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

On Tue, Nov 14, 2023 at 3:01 PM Laszlo Ersek wrote: > > On 11/13/23 22:33, Pedro Falcato wrote: > > On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote: > >> > >> On 11/13/2023 1:08 PM, Michael Kubacki wrote: > >>> Yes. I just did it. It is relatively m

Re: [edk2-discuss] [edk2-devel] Soft Feature Freeze starts now for edk2-stable202311

On Wed, Nov 22, 2023 at 1:49 PM Leif Lindholm wrote: > > On 2023-11-22 13:21, Marcin Juszkiewicz wrote: > > W dniu 22.11.2023 o 13:26, Leif Lindholm pisze: > >> On 2023-11-22 11:11, Sami Mujawar wrote: > > > >>> [SAMI] The proposal above looks good to me. This may be slightly off > >>> topic, but

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

On Fri, Nov 17, 2023 at 9:08 AM Laszlo Ersek wrote: > > On 11/16/23 09:29, Pedro Falcato wrote: > > On Tue, Nov 14, 2023 at 3:01 PM Laszlo Ersek wrote: > >> > >> On 11/13/23 22:33, Pedro Falcato wrote: > >>> On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran

Re: [edk2-devel] edk2 uncrustify update (73.0.8)?

On Thu, Nov 16, 2023 at 5:36 PM Michael Kubacki wrote: > This is the first time Uncrustify has been updated in edk2 since Dec 7, > 2021. > > https://github.com/tianocore/edk2/commits/master/.pytool/Plugin/UncrustifyCheck/uncrustify_ext_dep.yaml > > Its configuration has also not changed during tha

Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id

argument("--ignore-change-id", > + action="store_true", > + help="Ignore the presence of 'Change-id:' tags in > commit message") > self.args = parser.parse_args() > if self.args.one

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

On Tue, Nov 21, 2023 at 2:17 AM Chiu, Chasel wrote: > > > Hi Laszlo, > > I think you have to clone all the required repos. > edk2 repository > git clone https://github.com/tianocore/edk2.git > > edk2-platforms repository > git clone https://github.com/tianocore/edk2-platforms.git > > edk2-non-osi

Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id

On Wed, Nov 29, 2023 at 12:56 AM Ni, Ray wrote: > > It's good. But I am curious why --ignore-change-id is needed? I didn't ask, but presumably, if you have an internal gerrit instance that runs CI before pushing, PatchCheck.py may be part of the CI workflow; in those cases, we don't want it to er

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Fix issue with ACPI table creation

On Mon, Nov 20, 2023 at 4:24 AM Dhaval Sharma wrote: > > As per ACPI Spec 6.5+ Table 5-9 if xDSDT is avaialble, nit: available > it should be used first. Handle required flow when xDSDT > is abscent or present. nit: absent Separate nit: Please update the patch's subject to something more descr

[edk2-devel] [PATCH 1/1] Platform/Intel/Readme.md: Link to the OSS FSP repo

Link to github.com/intel/FSP, which is the canonical OSS place for all your FSP needs. The old link is not accessible publicly. Signed-off-by: Pedro Falcato Cc: Nate DeSimone Cc: Sai Chaganty --- Platform/Intel/Readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[edk2-devel] [PATCH 0/2] MdePkg: Fix CRC16-ANSI calculation

.com/heatd/6adaae8288e270897975d9321c5e8f41 Pedro Falcato (2): MdePkg/BaseLib: Fix CRC16-ANSI calculation MdePkg/Test: Add google tests for BaseLib MdePkg/Include/Library/BaseLib.h | 5 ++ MdePkg/Library/BaseLib/CheckSum.c | 4 +- .../Library/BaseLib/GoogleTestBaseLib.in

[edk2-devel] [PATCH 1/2] MdePkg/BaseLib: Fix CRC16-ANSI calculation

roblem was found out-of-list when older ext4 filesystems (that use crc16 checksums) failed to mount with "corruption". BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4609 Signed-off-by: Pedro Falcato Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu --- MdePkg/Include/Li

[edk2-devel] [PATCH 2/2] MdePkg/Test: Add google tests for BaseLib

Add GoogleTestBaseLib, which contains gtest unit tests for BaseLib. For now, only add checksum tests for CRC32C and CRC16; these tests check for correctness on various inputs using precomputed hashes. Signed-off-by: Pedro Falcato Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu

Re: [edk2-devel] [PATCH 0/2] MdePkg: Fix CRC16-ANSI calculation

On Thu, Nov 30, 2023 at 2:46 AM Pedro Falcato via groups.io wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4609 > > CalculateCrc16Ansi is currently miscalculating all checksums and causing > ext4 mount failures on older (~13 year old) filesystems. > > This

Re: [edk2-devel] [PATCH 2/2] MdePkg/Test: Add google tests for BaseLib

On Thu, Nov 30, 2023 at 7:32 PM Michael D Kinney wrote: > > With one comment below addressed > > Reviewed-by: Michael D Kinney > > > -Original Message- > > From: Pedro Falcato > > Sent: Wednesday, November 29, 2023 6:46 PM > > To: devel@edk2.gro

[edk2-devel] [PATCH 0/2] UnitTestFrameworkPkg: Fix Google Test components with multiple files

including previously-unreferenced constructors and making sure multi-file gtest EDK2 components work. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4610 Cc: Michael D Kinney Cc: Michael Kubacki Cc: Sean Brogan Pedro Falcato (2): UnitTestFrameworkPkg: Fix Google Test components

[edk2-devel] [PATCH 1/2] UnitTestFrameworkPkg: Fix Google Test components with multiple files

including previously-unreferenced constructors and making sure multi-file gtest EDK2 components work. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4610 Signed-off-by: Pedro Falcato Cc: Michael D Kinney Cc: Michael Kubacki Cc: Sean Brogan --- Note: /WHOLEARCHIVE should work for VS2015 and n

[edk2-devel] [PATCH 2/2] UnitTestFrameworkPkg/Readme.md: Remove the mention of the gtest main() limitation

As of the previous commit, this limitation is no longer a thing. You can now write gtest unit tests with multiple files and no need for any hack such as #include. Signed-off-by: Pedro Falcato Cc: Michael D Kinney Cc: Michael Kubacki Cc: Sean Brogan --- UnitTestFrameworkPkg/ReadMe.md | 16

Re: [edk2-devel] [PATCH 2/2] MdePkg/Test: Add google tests for BaseLib

On Thu, Nov 30, 2023 at 9:31 PM Kinney, Michael D wrote: > > Hi Pedro, > > I agree that silent failures are terrible. > > The issue is documented with the requirement to use #include here: > > https://github.com/tianocore/edk2/tree/master/UnitTestFrameworkPkg#googletest-configuration > > Unit test

Re: [edk2-devel] [PATCH 1/2] UnitTestFrameworkPkg: Fix Google Test components with multiple files

On Fri, Dec 1, 2023 at 5:07 PM Michael Kubacki wrote: > > Hi Pedro, > > Visual Studio NOOPT builds result in linker errors. I combined your > patch series with the test instruction change in this PR - > https://github.com/tianocore/edk2/pull/5096. > > You can use a PR to test the VS build. Thanks

Re: [edk2-devel] [PATCH 1/2] UnitTestFrameworkPkg: Fix Google Test components with multiple files

On Fri, Dec 1, 2023 at 8:50 PM Pedro Falcato via groups.io wrote: > > On Fri, Dec 1, 2023 at 5:07 PM Michael Kubacki > wrote: > > > > Hi Pedro, > > > > Visual Studio NOOPT builds result in linker errors. I combined your > > patch series with the test in

[edk2-devel] Question regarding the PI timer architectural protocols

Hi, I'm trying to write an EFI application[1] to sample the program counter, using a timer. I want to grab the EFI_SYSTEM_CONTEXT (for sampling) on timer interrupts. However: 1) Regular event-based SetTimer does not pass me this information 2) EFI timer architectural protocols also do not seem to

Re: [edk2-devel] [PATCH 1/2] UnitTestFrameworkPkg: Fix Google Test components with multiple files

On Sun, Dec 3, 2023 at 2:37 AM Michael D Kinney wrote: > > Merged: https://github.com/tianocore/edk2/pull/5098 I was going to submit a v2, but thanks for cleaning things up and pushing! -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply O

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/Win/Host: Remove /NODEFAULTLIB in WinHost.inf

ied on the link command line. > > DLINK_FLAGS and CC_FLAGS reorganized to consolidate options > common to IA32/X64. > > -Wno-microsoft-static-assert added to CLANGPDB CC_FLAGS to > address warnings. > > Cc: Andrew Fish > Cc: Ray Ni > Cc: Pedro Falcato > Signed-of

[edk2-devel] [PATCH] Ext4Pkg: Fix CRC16 checksumming on block groups

r the bg_checksum, and does not checksum it. This problem was found out-of-list when older ext4 filesystems (that use crc16 checksums) failed to mount with "corruption". BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4609 Signed-off-by: Pedro Falcato Cc: Savva Mitrofanov Cc

Re: [edk2-devel] [PATCH] Ext4Pkg: Fix CRC16 checksumming on block groups

On Sun, Dec 3, 2023 at 10:56 PM Marvin Häuser wrote: > > Reviewed-by: Marvin Häuser Thank you! Pushed as b95395b. -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111999): https://edk2.groups.io/g/devel/message/111999 Mute Th

Re: [edk2-devel] [PATCH v2] PcAtChipsetPkg: Fix AcpiTimerLib incompatibility with XhciDxe

On Mon, Dec 4, 2023 at 6:48 PM Nate DeSimone wrote: > > The DXE & MM standalone variant of AcpiTimerLib defines a global > named mPerformanceCounterFrequency. A global with an identical > name is also present in MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > > Since XhciDxe has a dependency on TimerLib, th

Re: [edk2-devel] Using ekd2-libc with C++20

On Fri, Feb 16, 2024 at 5:26 PM Michael D Kinney wrote: > > I think adding a #define to define register to nothings makes sense. No, the correct fix is to remove 'register' from the parameters. It does not change the ABI, nor the API, nor are the parameters "register"-ified in the C or C++ standa

Re: [edk2-devel] Using ekd2-libc with C++20

On Fri, Feb 16, 2024 at 2:46 PM pawel.karczewski via groups.io wrote: > > Hi, > > I'm successfully building C++20 project with edk2 under the GCC compiler. > Currently I'm trying to add edk2-libc to this project, but encountered issue > with header. > > ``` > edk2/StdLib/Include/string.h:487:19:

[edk2-devel] [PATCH edk2-libc 1/1] StdLib: Remove the 'register' keyword from public interfaces

Kinney Cc: Jayaprakash N Cc: pawel.karczew...@solidigm.com Signed-off-by: Pedro Falcato --- This should fix your problem. Pawel, can you check? StdLib/Include/stdlib.h | 8 StdLib/Include/string.h | 6 +++--- StdLib/LibC/StdLib/Environs.c | 4 ++-- StdLib/LibC/String/strse

Re: [edk2-devel] Using ekd2-libc with C++20

On Fri, Feb 16, 2024 at 8:06 PM Pedro Falcato wrote: > > On Fri, Feb 16, 2024 at 2:46 PM pawel.karczewski via groups.io > wrote: > > > > Hi, > > > > I'm successfully building C++20 project with edk2 under the GCC compiler. > > Currently I&#x

Re: [edk2-devel] [PATCH V2] Pkg-Module: OptionRomPkg

On Tue, Feb 20, 2024 at 10:39 AM Gahan wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689 > > Bug 4689 - GetInfo() of Adapter Information Protocol > should have a provision for IHV to return no data for > UEFI Spec compliance 2.9 [mantis #1866] Hi Gahan, FYI, your commit subject

Re: [edk2-devel] [PATCH] UefiCpuPkg: add volatile qualifier to page table related variable

On Wed, Feb 21, 2024 at 8:36 PM Laszlo Ersek wrote: > > On 2/21/24 02:25, Zhou Jianfeng wrote: > > Add volatile qualifier to page table related variable to prevent > > compiler from optimizing away the variables which may lead to > > unexpected result. > > > > Signed-off-by: Zhou Jianfeng > > Cc:

Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

On Tue, Feb 27, 2024 at 11:46 PM Michael D Kinney wrote: > > Hi Pedro, > > Looks like this series got set aside waiting for some additional feedback. Hi, This is odd, I did reply back in June (https://edk2.groups.io/g/devel/message/105817). You probably missed the email or maybe for some unknown

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

On Fri, Mar 8, 2024 at 9:14 AM Laszlo Ersek wrote: > > On 3/6/24 23:22, Michael D Kinney wrote: > > Reviewed-by: Michael D Kinney > > Merged as commit ccf91b518f22, via > . > > Thank you all for everything, Thank you for your great (and often thankles

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

On Mon, Mar 11, 2024 at 3:04 AM Ni, Ray wrote: > > This is a good idea to have a CREDITS file in edk2 repo. > > Pedro, would you mind initiating one? Laszlo told me (in private) that he doesn't want a CREDITS entry for him, git log is enough. So unless you have other people in mind, let's drop t

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

On Wed, Apr 3, 2024 at 8:48 AM Yoshinoya wrote: > > Maybe ref to ramdisk sample, create a memory type block io device, then mount > file system on it. > UEFI supports fat file system, some 3rd drivers could be added to support > ext4 filesystem. > Search them on github website EDK2 already supp

Re: [edk2-devel] Call or topics for April TianoCore Community Meeting

On Wed, Apr 3, 2024 at 11:02 PM Oliver Smith-Denny wrote: > > On 4/3/2024 1:38 PM, Michael D Kinney wrote: > > Hi Oliver, > > > > I missed this response. Did not show up in thread for some reason. > > No worries. > > > > > But we can continue these topics on email. > > > > The TianoCore roles and

Re: [edk2-devel] [Question] using Flexible Array Member in Structure.

On Fri, Apr 5, 2024 at 7:43 AM levi.yun wrote: > > Hi Michael! Thanks for answer. > > > Converting these to a flexible array member would not be > a backwards compatible change. > > That's the point. But at least when I see the compiler used in tool_def.txt, > there's no compiler which doesn't sup

Re: [edk2-devel] [Question] using Flexible Array Member in Structure.

On Wed, Apr 3, 2024 at 10:27 AM levi.yun wrote: > > Hello all! > > while I see the code. I have one question related using Flexible Array > Member. > > For example) > > /// > /// Socket Type Data. > /// > typedef struct { >EFI_ACPI_6_4_PMTT_COMMON_MEMORY_DEVICE CommonMemoryDeviceHeader; >U

Re: [edk2-devel] [PATCH 1/3] OptionRomPkg: Update the comments of GetInformation function

etInfo's docs to UEFI spec 2.10" > > Cc: Pedro Falcato Why was I CC'd on this? /me is confused > Cc: Ray Ni > Signed-off-by: Qingyu > Signed-off-by: Gahan Saraiya > --- > Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h | 5 - > Drivers/OptionRomPk

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: OVMF supports USB mouses

On Tue, Apr 9, 2024 at 12:56 PM Gerd Hoffmann wrote: > > On Mon, Apr 08, 2024 at 08:53:10AM +0100, Phillip Tennen wrote: > > Hi, thank you for taking a look at the patch! > > > > This patch can be verified to be working with this app (which was the > > motivation for submitting this): > > https://

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

On Wed, May 1, 2024 at 6:44 PM Michael D Kinney via groups.io wrote: > > Hello, > > I would like to propose that TianoCore move all code review from email > based code reviews to GitHub Pull Requests based code reviews. > > The proposed date to switch would be immediately after the next stable > t

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

On Thu, May 2, 2024 at 7:17 PM Kinney, Michael D wrote: > > > > > -Original Message- > > From: r...@edk2.groups.io On Behalf Of Pedro Falcato > > Sent: Thursday, May 2, 2024 10:51 AM > > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: r...@edk2

  1   2   3   4   5   6   >