On Thu, Jan 18, 2024 at 9:50 AM Dhaval <dha...@rivosinc.com> wrote: > > Some platforms do not implement cache management operations. Especially > for DMA drivers have code to manage data cache. The code seem to depend > on the underlying CPU/cache drivers to enact functionality and simply > return if such functionality is not implemented. However this causes > issue with CMO implementation which has an assert causing flow to > hang within debug environment. While it is not an issue in production > environment there is a recommendation to conver this assert in to
I don't agree with this patch. As I see it, the library has a simple contract: Do cache operation X and return. We cannot safely return if we don't know how to do cache operation X. Say, with a Thead core and Xtheadcmo. Any other concerns wrt DMA are, in my view, somewhat separate. One can easily theorize a way this change can come to bite us, say, a storage controller writes bogus data to storage (because the platform needs explicit cache coherency, and we don't know how to do that) and causes data corruption. > a harmless logger message. Eventually platform/drivers need to have > better guard for such functionality. Like an ASSERT? :) -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113997): https://edk2.groups.io/g/devel/message/113997 Mute This Topic: https://groups.io/mt/103805230/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
