Re: [edk2-devel] [edk2-platforms][PATCH V2 13/47] Features/Intel/IpmiFeaturePkg: Add initial package

Reviewed-by: Sai Chaganty -Original Message- From: Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-platforms][PATCH V2 13/47] Features/Intel/IpmiFeaturePkg: Add initial package Adds a new fea

Re: [edk2-devel] [PATCH] BaseTools:Enhance the way to handling included dsc file

Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, December 3, 2019 5:04 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:Enhance the way to handling included dsc file BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2400 In

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token every time.

Hi Philippe, > -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Thursday, November 28, 2019 9:16 PM > To: devel@edk2.groups.io; Dong, Eric > Cc: Ni, Ray ; Laszlo Ersek > Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid > allocate T

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token every time.

Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, November 29, 2019 3:39 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Liming > Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid > allocate Token every time

Re: [edk2-devel] Public-Service-Announcement: send-email issues with Git 2.22.0+

Nate: Thanks for your sharing. I apply this command in my development machine. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Nate DeSimone >Sent: Wednesday, December 04, 2019 12:31 PM >To: devel@edk2.groups.io >Subject: [edk2-d

[edk2-devel] Public-Service-Announcement: send-email issues with Git 2.22.0+

Hi Everyone, I have been dealing with a very frustrating issue recently where all of my "CR LF" line endings get erroneously converted into "LF LF" once I send my patch to the mailing list. I have discovered the root cause for this problem. The issue is the following commit to git itself: http

Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen: Fix various typos

Le 04/12/2019 à 00:56, Anthony PERARD a écrit : There's seems to be missing SoB from Antoine. Could that be added? Hi, no need to worry about my attribution: it's really just spellchecking. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply On

Re: [edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos

Reviewed-by: Star Zeng -Original Message- From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] Sent: Wednesday, December 4, 2019 12:15 AM To: devel@edk2.groups.io Cc: Antoine Coeur ; Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star ; Philippe Mathieu-Daude Subject: [PATCH 10/79] I

Re: [edk2-devel] [Patch 0/4 V4] Enhance Incremental Build

1. No. If user does not update build_rule and tools_def, build will not failed. No impact for clean build. Since there will no COMMON_DEPS variable generated in Makefile, if user change a header file which is in original COMMON_DEPS, build tool will not rebuild the corresponding module for incre

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Improve output formatting in maintain_submodules()

Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- edkrepo/common/common_repo_functions.py | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/edkrepo/common/common_repo_functions.py b/edkrepo/common/common_repo_functions.py index

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve output formatting in maintain_submodules()

Signed-off-by: Ashley E Desimone --- edkrepo/common/common_repo_functions.py | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/edkrepo/common/common_repo_functions.py b/edkrepo/common/common_repo_functions.py index c8713dd..d857d09 100644 --- a/edkrep

Re: [edk2-devel] [PATCH 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions

Series, Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] > Sent: Tuesday, December 3, 2019 1:41 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; > Philippe Mathieu-Daude > Subject: [PATCH 0/2] ShellPkg: D

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V3] EdkRepo: Add list-repos command

list-repos lists the git repos used by all projects and which branches those projects use. Cc: Ashley E Desimone Signed-off-by: Nate DeSimone --- edkrepo/commands/arguments/list_repos_args.py | 16 ++ edkrepo/commands/humble/__init__.py | 8 + edkrepo/commands/humble/list_repos_hum

Re: [edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos

Hi Chasel, If you had authored the changes, then you could update those copyright lines. Since the author of the changes is Antoine Coeur , Antoine gets to make the choice to add a new copyright line or not. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of

Re: [edk2-devel] [PATCH 25/79] MdePkg/IndustryStandard: Fix various typos

Reviewed-by: Michael D Kinney > -Original Message- > From: Philippe Mathieu-Daude > Sent: Tuesday, December 3, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Kinney, Michael D > ; Gao, Liming > ; Philippe Mathieu-Daude > > Subject: [PATCH 25/79] MdePkg/IndustryStandard: F

Re: [edk2-devel] [PATCH 30/79] MdePkg/Register: Fix various typos

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Philippe Mathieu-Daudé > Sent: Tuesday, December 3, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Kinney, Michael D > ; Gao, Liming > ; Philippe Mathieu-Daude > > Subject: [edk

Re: [edk2-devel] [PATCH 29/79] MdePkg/Ppi: Fix various typos

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Philippe Mathieu-Daudé > Sent: Tuesday, December 3, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Kinney, Michael D > ; Gao, Liming > ; Philippe Mathieu-Daude > > Subject: [edk

Re: [edk2-devel] [PATCH 28/79] MdePkg/Library/Smm: Fix various typos

Reviewed-by: Michael D Kinney > -Original Message- > From: Philippe Mathieu-Daude > Sent: Tuesday, December 3, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Kinney, Michael D > ; Gao, Liming > ; Philippe Mathieu-Daude > > Subject: [PATCH 28/79] MdePkg/Library/Smm: Fix va

Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)

You can also mention the fork branch with all changes. Then, the reviewer can see all changes. Thanks Liming >-Original Message- >From: Desimone, Nathaniel L >Sent: Wednesday, December 04, 2019 9:16 AM >To: devel@edk2.groups.io; phi...@redhat.com; Achin Gupta >; Andrew Fish ; Anthony Per

Re: [edk2-devel] [PATCH 27/79] MdePkg/Library/Pci: Fix various typos

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Philippe Mathieu-Daudé > Sent: Tuesday, December 3, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Kinney, Michael D > ; Gao, Liming > ; Philippe Mathieu-Daude > > Subject: [edk

Re: [edk2-devel] [PATCH 26/79] MdePkg/Library/Dxe: Fix various typos

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Philippe Mathieu-Daudé > Sent: Tuesday, December 3, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Kinney, Michael D > ; Gao, Liming > ; Philippe Mathieu-Daude > > Subject: [edk

Re: [edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos

Philippe, thanks for helping on this. Just minor feedbacks - many files having old copyright years that I replied below inline, please help to correct them. With copyright updated, Reviewed-by: Chasel Chiu > -Original Message- > From: Philippe Mathieu-Daude > Sent: Wednesday, Decembe

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Add list-repos command

It looks good for now but in the future I would like to see an error message when the repo name passed with the --repos flag is not found. Reviewed-by: Ashley E DeSimone -Original Message- From: Desimone, Nathaniel L Sent: Tuesday, December 3, 2019 3:06 PM To: devel@edk2.groups.io Cc:

Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)

Hi Philippe and Antoine, Thank you very much for doing this work! Please note that the mailing list currently has the braindead behavior only allowing a user to send 40 emails in a 30 minute window. I believe this is done to prevent spamming. Because of this, only patches 0-39 were actually rec

Re: [edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Philippe Mathieu-Daudé Sent: Tuesday, December 3, 2019 8:15 AM To: devel@edk2.groups.io Cc: Antoine Coeur ; Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star ; Philippe Mathieu-Daude Subject: [edk2-

Re: [edk2-devel] [PATCH 73/79] SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos

> -Original Message- > From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] > Sent: Wednesday, December 04, 2019 12:16 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur; Wu, Hao A; Philippe Mathieu-Daude > Subject: [PATCH 73/79] SourceLevelDebugPkg/DebugCommunicationLib: Fix > various ty

Re: [edk2-devel] [PATCH 72/79] SourceLevelDebugPkg/DebugAgent: Fix various typos

> -Original Message- > From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] > Sent: Wednesday, December 04, 2019 12:16 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur; Wu, Hao A; Philippe Mathieu-Daude > Subject: [PATCH 72/79] SourceLevelDebugPkg/DebugAgent: Fix various typos > > From

Re: [edk2-devel] [PATCH 74/79] SourceLevelDebugPkg: Fix few typos

> -Original Message- > From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] > Sent: Wednesday, December 04, 2019 12:16 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur; Wu, Hao A; Philippe Mathieu-Daude > Subject: [PATCH 74/79] SourceLevelDebugPkg: Fix few typos > > From: Antoine Coeur

Re: [edk2-devel] EDK II Stable Tag release edk2-stable201911 completed

Takuto: Yes. I prepared IA32 and X64 ShellBin binary. Ard will help generate ARM and AARCH64 ShellBin binary. Then, I will upload them. Thanks Liming From: nait...@gmail.com Sent: Tuesday, December 3, 2019 11:10 PM To: Gao; Gao, Liming ; devel@edk2.groups.io Subject: Re: [edk2-devel] EDK II St

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.

Hi Philippe, FYI, this patch from Chasel was merged 8 months ago: https://github.com/tianocore/edk2/commit/00e3e4801467dd73b90a151994fc26ba9b5734d7 Thanks, Nate -Original Message- From: Philippe Mathieu-Daudé Sent: Monday, December 2, 2019 11:20 PM To: devel@edk2.groups.io; Chiu, Chas

Re: [edk2-devel] [edk2-platforms][PATCH V2 22/47] Features/Intel/AdvancedFeaturePkg: Add package

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V2 22/47] Features/Intel/Ad

Re: [edk2-devel] [edk2-platforms][PATCH V2 44/47] DebugFeaturePkg: Remove the ACPI Debug feature

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Wednesday, November 27, 2019 6:19 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V2 44/47] DebugFeaturePkg: Remove the

Re: [edk2-devel] [edk2-platforms][PATCH V2 16/47] Features/Intel/SmbiosFeaturePkg: Add initial package

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V2 16/47] Features/Intel/Sm

Re: [edk2-devel] [edk2-platforms][PATCH V2 38/47] SimicsOpenBoardPkg: Use new advanced feature refactor

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Wei, David Y ; Agyeman, Prince Subject: [edk2-devel] [edk2-platforms][PATCH V2 38/47] SimicsOpenBoardPkg: Us

Re: [edk2-devel] [edk2-platforms][PATCH V2 14/47] Features/Intel/IpmiFeaturePkg: Add libraries

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V2 14/47] Features/Intel/Ip

Re: [edk2-devel] [edk2-platforms][PATCH V2 13/47] Features/Intel/IpmiFeaturePkg: Add initial package

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V2 13/47] Features/Intel/Ip

Re: [edk2-devel] [edk2-platforms][PATCH V2 12/47] Features/Intel/S3FeaturePkg: Add initial package

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V2 12/47] Features/Intel/S3

Re: [edk2-devel] [edk2-platforms][PATCH V2 21/47] Features/Intel/NetworkFeaturePkg: Add initial package

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V2 21/47] Features/Intel/Ne

Re: [edk2-devel] [edk2-platforms][PATCH V2 29/47] MinPlatformPkg: Add FvAdvancedPreMemory

Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-platforms][PATCH V2 29/47] MinPlatformPkg: Add FvAdvancedPreMemory This ch

Re: [edk2-devel] [edk2-platforms][PATCH V2 15/47] Features/Intel/IpmiFeaturePkg: Add modules

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V2 15/47] Features/Intel/Ip

Re: [edk2-devel] [edk2-platforms][PATCH V2 41/47] Platform/Intel/AdvancedFeaturePkg: Remove the IPMI feature

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Wednesday, November 27, 2019 6:19 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V2 41/47] Platform/Intel/Ad

Re: [edk2-devel] [edk2-platforms][PATCH V2 04/47] Features/Intel: Add Readme.md

Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Bi, Dandan ; Chaganty, Rangasai V ; Chiu, Chasel ; Wei, David Y ; Desimone, Nathaniel L ; Dong, Eric ; Gao, Liming ; Agyeman, Prince Subjec

Re: [edk2-devel] [edk2-platforms][PATCH V2 06/47] Features/Intel/OutOfBandManagement: Add Readme.md

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V2 06/47] Features/Intel/Ou

Re: [edk2-devel] [PATCH 57/79] OvmfPkg/Csm: Fix various typos

On Tue, 2019-12-03 at 21:50 +0100, Laszlo Ersek wrote: > On 12/03/19 17:15, Philippe Mathieu-Daude wrote: > > From: Antoine Coeur > > > > Fix various typos in documentation, comments and strings. > > > > Cc: Jordan Justen > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Reviewed-by: Philippe M

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2] EdkRepo: Add list-repos command

list-repos lists the git repos used by all projects and which branches those projects use. Cc: Ashley E Desimone Signed-off-by: Nate DeSimone --- edkrepo/commands/arguments/list_repos_args.py | 16 ++ edkrepo/commands/humble/__init__.py | 8 + edkrepo/commands/humble/list_repos_hum

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add list-repos command

Just a few comments: edkrepo.commands.humble needs to be added to setup.py otherwise the import will not resolve. #length = len(max(branches, key=len)) .ljust(length) on line 101 of list_repos_command.py should either be uncommented or removed. Thanks, Ashley -Original Mes

Re: [edk2-devel] [Patch wiki v2] EDK II CI: Update Phase 1 details and admin settings

Hi Lazlo, One comment below. I have made updates based on the rest of your feedback. Mike > -Original Message- > From: Laszlo Ersek > Sent: Tuesday, December 3, 2019 9:08 AM > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: Sean Brogan ; Bret > Barkelew ; Gao, Liming > ; Andrew Fi

Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen: Fix various typos

On 12/03/19 17:56, Anthony PERARD wrote: > On Tue, Dec 03, 2019 at 05:15:44PM +0100, Philippe Mathieu-Daude wrote: >> From: Antoine Coeur >> >> Fix various typos in comments and documentation. >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Anthony Perard >> Cc: Julien

Re: [edk2-devel] [PATCH 60/79] OvmfPkg/Xen: Fix a typo

On 12/03/19 17:15, Philippe Mathieu-Daude wrote: > Fix a typo in a comment. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Signed-off-by: Philippe Mathieu-Daude > --- > OvmfPkg/XenBusDxe/GrantTable.h | 2 +- > 1 file changed, 1 insert

Re: [edk2-devel] [PATCH 79/79] UefiCpuPkg/Smm: Fix various typos

On 12/03/19 17:16, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix various typos in comments and documentation. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > UefiCpuPkg/Include/Library/Smm

Re: [edk2-devel] [PATCH 78/79] UefiCpuPkg/PiSmm: Fix various typos

On 12/03/19 17:16, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix various typos in comments and documentation. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSm

Re: [edk2-devel] [PATCH 77/79] UefiCpuPkg/CpuDxe: Fix few typos

On 12/03/19 17:16, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix few typos in comments and documentation. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > UefiCpuPkg/CpuDxe/CpuDxe.h |

Re: [edk2-devel] [PATCH 59/79] OvmfPkg/Virtio: Fix few typos

On 12/03/19 17:15, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix few typos in comments and documentation. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > OvmfPkg/Include/Librar

Re: [edk2-devel] [PATCH 58/79] OvmfPkg/Qemu: Fix various typos

On 12/03/19 17:15, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix various typos in comments and documentation. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > OvmfPkg/QemuFlashF

Re: [edk2-devel] [PATCH 57/79] OvmfPkg/Csm: Fix various typos

On 12/03/19 17:15, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix various typos in documentation, comments and strings. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > OvmfPkg/C

Re: [edk2-devel] [PATCH 56/79] OvmfPkg/Acpi: Fix few typos

On 12/03/19 17:15, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix few typos in comments and documentation. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude > --- > OvmfPkg/Csm/Include/Pr

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

On 12/03/19 18:07, Kinney, Michael D wrote: > Hi Laszlo, > > I can think of ways we may be able to get the label > information into the body of the email in a PR comment. > I will have to see if there is anyway to adjust the subject > of the email. The subject appears to always match the title >

Re: [edk2-devel] [PATCH 76/79] StandaloneMmPkg: Fix few typos

Reviewed-by: jiewen@intel.com > -Original Message- > From: Philippe Mathieu-Daude > Sent: Wednesday, December 4, 2019 12:16 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Achin Gupta ; Yao, > Jiewen ; Supreeth Venkatesh > ; Philippe Mathieu-Daude > > Subject: [PATCH 76/79] Stand

Re: [edk2-devel] [PATCH 75/79] StandaloneMmPkg: Fix a typo

Reviewed-by: jiewen@intel.com > -Original Message- > From: Philippe Mathieu-Daude > Sent: Wednesday, December 4, 2019 12:16 AM > To: devel@edk2.groups.io > Cc: Philippe Mathieu-Daude ; Antoine Cœur > ; Achin Gupta ; Yao, Jiewen > ; Supreeth Venkatesh > Subject: [PATCH 75/79] Standalo

Re: [edk2-devel] [PATCH 0/8] .mailmap: Add mailmap file to have a cleaner git history

On 12/3/19 7:51 PM, Laszlo Ersek wrote: Hi Phil, (heavily trimmer CC list) Good idea :) On 11/26/19 16:08, Philippe Mathieu-Daudé via Groups.Io wrote: Hi, The .mailmap git feature helps fixing commit mistakes (in name/email). The easiest way to use it is with the --use-mailmap flag: $

Re: [edk2-devel] [PATCH 0/8] .mailmap: Add mailmap file to have a cleaner git history

Hi Phil, (heavily trimmer CC list) On 11/26/19 16:08, Philippe Mathieu-Daudé via Groups.Io wrote: > Hi, > > The .mailmap git feature helps fixing commit mistakes (in name/email). > > The easiest way to use it is with the --use-mailmap flag: > > $ git log --use-mailmap > > See: > https://git

Re: [EXTERNAL] RE: [edk2-devel] Seeking feedback: example of building OvmfPkg with Pytools

Sorry let me clarify. The plugin is not designed to work for the VS2015 toolchain. The plugin is not part of pytools but part of edk2 repo. If you would like to build with VS2017 or VS2019 the plugin will handle your path management. If you are not setting the tool chain on the command line the

Re: [EXTERNAL] RE: [edk2-devel] Seeking feedback: example of building OvmfPkg with Pytools

Hi Bob, The 5.2 failure is expected as we do not support VS2015 yet. If suggest adding a feature request here : https://github.com/tianocore/

Re: [edk2-devel] [Patch wiki v2] EDK II Dev Process: Change push to GitHub pull request

On 12/02/19 19:01, Michael D Kinney via Groups.Io wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=2315 > > Update wiki pages to remove instructions that directly > push to edk2/master. Update these instructions to create > a GitHub pull request from an EDK II Maintainers fork of I suggest

Re: [edk2-devel] EDK II Stable Tag release edk2-stable201911 completed

Hi Liming, Congrats on releasing edk2-stable201911. Could you add ShellBinPkg.zip to the assets of the release on GitHub? ShellPkg of the new tag includes many improvements. ShellBinPkg.zip is helpful to use it. Regards, Takuto -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages

Re: [edk2-devel] [PATCH 31/79] NetworkPkg: Fix a typo

On 12/3/19 6:18 PM, Leif Lindholm wrote: Hi Phil, On Tue, Dec 03, 2019 at 17:15:14 +0100, Philippe Mathieu-Daude wrote: Correctly write 'malformatted' in documentation, comments and debug strings. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney I would have expect

Re: [edk2-devel] [PATCH 31/79] NetworkPkg: Fix a typo

Hi Phil, On Tue, Dec 03, 2019 at 17:15:14 +0100, Philippe Mathieu-Daude wrote: > Correctly write 'malformatted' in documentation, comments and > debug strings. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney I would have expected: Jiaxin Wu Siyuan Fu

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

Hi Laszlo, I can think of ways we may be able to get the label information into the body of the email in a PR comment. I will have to see if there is anyway to adjust the subject of the email. The subject appears to always match the title of the PR. That title is editable, but may only be edita

Re: [edk2-devel] [Patch wiki v2] EDK II CI: Update Phase 1 details and admin settings

On 12/02/19 18:56, Michael D Kinney via Groups.Io wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=2315 > > Update wiki pages providing details of the Phase 1 > EDK II Continuous Integration features and links to all > supporting documentation. Also provide notes for admins > to configure

Re: [edk2-devel] [PATCH 02/79] EmbeddedPkg/FdtLib: Fix a typo

Hi Phil, Antoine, This file is imported from an external project, and arguably we should be converting the libfdt import to a submodule instead. So I'd prefer not pulling this one in. / Leif On Tue, Dec 03, 2019 at 17:14:45 +0100, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix

Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen: Fix various typos

On Tue, Dec 03, 2019 at 05:15:44PM +0100, Philippe Mathieu-Daude wrote: > From: Antoine Coeur > > Fix various typos in comments and documentation. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Reviewed-by: Philippe Mathieu-Daude > S

Re: [edk2-devel] [PATCH 60/79] OvmfPkg/Xen: Fix a typo

On Tue, Dec 03, 2019 at 05:15:43PM +0100, Philippe Mathieu-Daude wrote: > Fix a typo in a comment. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Signed-off-by: Philippe Mathieu-Daude Acked-by: Anthony PERARD Thanks, -- Anthony PE

Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)

Woah, thank you for the work, Philippe. Tell me if there is anything I can do to help. Antoine Le 04/12/2019 à 00:14, Philippe Mathieu-Daude a écrit : Around February of this year, Antoine posted various patches fixing a huge quantity of typos, over 8000+ lines (such [1]). The community merge

[edk2-devel] [PATCH 35/79] NetworkPkg/DnsDxe: Fix a typo

Fix the same typo in various comments. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/DnsDxe/DnsImpl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c inde

[edk2-devel] [PATCH 36/79] NetworkPkg/DnsDxe: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/DnsDxe/DnsDriver.h | 12 - NetworkPkg/DnsDxe/DnsImpl.h | 28 ++--

[edk2-devel] [PATCH 38/79] NetworkPkg/HttpBootDxe: Fix a typo in variable name

Correctly write 'Initialized'. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/HttpBootDxe/HttpBootConfig.h | 2 +- NetworkPkg/HttpBootDxe/HttpBootConfig.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NetworkPkg/Ht

[edk2-devel] [PATCH 39/79] NetworkPkg/HttpBootDxe: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/HttpBootDxe/HttpBootDhcp4.h | 2 +- NetworkPkg/HttpBootDxe/HttpBootDhcp6.h | 4 +

[edk2-devel] [PATCH 37/79] NetworkPkg/DpcDxe: Fix few typos

From: Antoine Coeur Fix few typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/DpcDxe/Dpc.h | 2 +- NetworkPkg/Include/Protocol/Dpc.h | 2 +- NetworkPkg/DpcDxe

[edk2-devel] [PATCH 34/79] NetworkPkg/Dhcp6Dxe: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h | 4 +-- NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h | 12 - N

[edk2-devel] [PATCH 28/79] MdePkg/Library/Smm: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Michael D Kinney Cc: Liming Gao Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- MdePkg/Include/Library/SmmLib.h | 4 +- MdePkg/Include/Library/SmmMemLib.h

[edk2-devel] [PATCH 23/79] MdeModulePkg/UsbBus: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h | 14 +++--- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h | 2 +- MdeModulePkg/Bus/Usb/U

[edk2-devel] [PATCH 29/79] MdePkg/Ppi: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Michael D Kinney Cc: Liming Gao Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- MdePkg/Include/Ppi/BlockIo.h | 4 ++-- MdePkg/Include/Ppi/BlockIo2.h | 2 +- MdePkg

[edk2-devel] [PATCH 20/79] MdeModulePkg/UsbBusDxe: Fix a typo

Correctly write 'malformatted'. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c b/MdeModulePkg/Bus/Usb/UsbBu

[edk2-devel] [PATCH 19/79] MdeModulePkg/Core/PiSmmCore: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jian J Wang Cc: Hao A Wu Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf| 10 MdeModulePkg/Core/PiSmmCore/HeapGuard.h

[edk2-devel] [PATCH 18/79] MdeModulePkg/Core/Pei: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jian J Wang Cc: Hao A Wu Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Core/Pei/PeiMain.h | 20 +++--- MdeModulePkg/Core/Pei/Dependency/Dependency.c |

[edk2-devel] [PATCH 22/79] MdeModulePkg/UsbMouse: Fix few typos

From: Antoine Coeur Fix few typos in comments and documentation. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h | 2 +- MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h

[edk2-devel] [PATCH 32/79] NetworkPkg/ArpDxe: Fix various typos

From: Antoine Coeur Fix various typos in documentation, comments and debug strings. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/ArpDxe/ArpDriver.h | 10 +- NetworkPkg/ArpDxe/ArpImpl.h | 14

[edk2-devel] [PATCH 25/79] MdePkg/IndustryStandard: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Michael D Kinney Cc: Liming Gao Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- MdePkg/Include/IndustryStandard/Acpi10.h | 4 +- MdePkg/Include/IndustryStandard/Acpi20.h

[edk2-devel] [PATCH 21/79] MdeModulePkg/UsbMass: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h | 4 ++-- MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h | 4 ++-- MdeModulePkg/B

[edk2-devel] [PATCH 31/79] NetworkPkg: Fix a typo

Correctly write 'malformatted' in documentation, comments and debug strings. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/Dhcp4Dxe/Dhcp4Option.h| 6 +++--- NetworkPkg/Ip4Dxe/Ip4Icmp.h | 2 +

[edk2-devel] [PATCH 24/79] MdeModulePkg/Usb: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h | 2 +- MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h | 10 +- MdeModulePkg/Bus/Usb/UsbKbDx

[edk2-devel] [PATCH 27/79] MdePkg/Library/Pci: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Michael D Kinney Cc: Liming Gao Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- MdePkg/Include/Library/PciCf8Lib.h| 4 ++-- MdePkg/Include/Library/PciExpres

[edk2-devel] [PATCH 26/79] MdePkg/Library/Dxe: Fix various typos

From: Antoine Coeur Fix various typos in documentation, comments and strings, and remove the duplicated 'the'. Cc: Michael D Kinney Cc: Liming Gao Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- MdePkg/Library/DxePcdLib/DxePcdLib.inf

[edk2-devel] [PATCH 33/79] NetworkPkg/Dhcp4Dxe: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h | 4 +-- NetworkPkg/Dhcp4Dxe/Dhcp4Io.h | 2 +- NetworkPkg

[edk2-devel] [PATCH 30/79] MdePkg/Register: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Michael D Kinney Cc: Liming Gao Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- MdePkg/Include/Register/Amd/Cpuid.h | 8 MdePkg/Include/Register/Amd/Fam17Msr.h

[edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)

Around February of this year, Antoine posted various patches fixing a huge quantity of typos, over 8000+ lines (such [1]). The community merged the smaller patches, and told him his patches were too big, and he should split them. Around June, Antoine opened a GitHub pull request [2], due to the si

[edk2-devel] [PATCH 16/79] MdeModulePkg/Bus/Scsi: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h | 4 +-- MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 1

[edk2-devel] [PATCH 17/79] MdeModulePkg/Bus/Sd: Fix various typos

From: Antoine Coeur Fix various typos in comments and documentation. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h | 2 +- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h

[edk2-devel] [PATCH 13/79] MdeModulePkg/Bus/Ata: Fix various typos

From: Antoine Coeur Fix various typos in documentation, comments and debug strings. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +- MdeModulePkg/Bus/Ata/A

[edk2-devel] [PATCH 08/79] FatPkg/EnhancedFatDxe: Fix various typos

From: Antoine Coeur Fix various typos in FatPkg/EnhancedFatDxe comments. Cc: Ray Ni Signed-off-by: Coeur Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe Mathieu-Daude --- FatPkg/EnhancedFatDxe/Fat.h | 6 +++--- FatPkg/EnhancedFatDxe/Delete.c | 2 +- FatPkg/E

  1   2   >