Reviewed-by: Sai Chaganty <rangasai.v.chaga...@intel.com> -----Original Message----- From: Kubacki, Michael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Gao, Liming <liming....@intel.com> Subject: [edk2-platforms][PATCH V2 13/47] Features/Intel/IpmiFeaturePkg: Add initial package
Adds a new feature package for the IPMI feature. This change updates the advanced feature package template for IPMI and adds the updated template to the IpmiFeaturePkg. Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> Cc: Liming Gao <liming....@intel.com> Signed-off-by: Michael Kubacki <michael.a.kuba...@intel.com> --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec | 29 +++++++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc | 24 ++++++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf | 8 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf | 8 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md | 89 ++++++++++++++++++++ 5 files changed, 158 insertions(+) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec new file mode 100644 index 0000000000..dfa8888e88 --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d +++ ec @@ -0,0 +1,29 @@ +## @file +# This package provides advanced feature functionality to enable the # +Intelligent Platform Management Interface (IPMI). +# This package should only depend on EDK II Core packages, IntelSiliconPkg, and MinPlatformPkg. +# +# The DEC files are used by the utilities that parse DSC and # INF +files to generate AutoGen.c and AutoGen.h files # for the build +infrastructure. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> # # +SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +[Defines] + DEC_SPECIFICATION = 0x00010017 + PACKAGE_NAME = IpmiFeaturePkg + PACKAGE_GUID = AE091910-F6C9-4AB5-B8B4-995E2F0D5166 + PACKAGE_VERSION = 0.1 + +[Includes] + Include + +[Guids] + gIpmiFeaturePkgTokenSpaceGuid = {0xc05283f6, 0xd6a8, 0x48f3, {0x9b, +0x59, 0xfb, 0xca, 0x71, 0x32, 0x0f, 0x12}} + +[PcdsFeatureFlag] + +gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable|FALSE|BOOLEAN|0xA000 +0001 diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc new file mode 100644 index 0000000000..1952ba185e --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d +++ sc @@ -0,0 +1,24 @@ +## @file +# This package provides advanced feature functionality to enable the # +Intelligent Platform Management Interface (IPMI). +# This package should only depend on EDK II Core packages, IntelSiliconPkg, and MinPlatformPkg. +# +# The DEC files are used by the utilities that parse DSC and # INF +files to generate AutoGen.c and AutoGen.h files # for the build +infrastructure. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> # # +SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +[Defines] + PLATFORM_NAME = IpmiFeaturePkg + PLATFORM_GUID = 7B2E74D7-9538-4818-B51A-492F3D33BD20 + PLATFORM_VERSION = 0.1 + DSC_SPECIFICATION = 0x00010005 + OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME) + SUPPORTED_ARCHITECTURES = IA32|X64 + BUILD_TARGETS = DEBUG|RELEASE|NOOPT + SKUID_IDENTIFIER = DEFAULT diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf new file mode 100644 index 0000000000..c3847c54c7 --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemo +++ ry.fdf @@ -0,0 +1,8 @@ +## @file +# FDF file for post-memory modules that enable Intelligent Platform Management Interface. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> # # +SPDX-License-Identifier: BSD-2-Clause-Patent # ## diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf new file mode 100644 index 0000000000..0c82d7eb02 --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemor +++ y.fdf @@ -0,0 +1,8 @@ +## @file +# FDF file for pre-memory modules that enable Intelligent Platform Management Interface. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> # # +SPDX-License-Identifier: BSD-2-Clause-Patent # ## diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md new file mode 100644 index 0000000000..e70f1e850b --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md @@ -0,0 +1,89 @@ +# Overview +* **Feature Name:** Intelligent Platform Management Interface (IPMI) +* **PI Phase(s) Supported:** PEI, DXE +* **SMM Required?** No + +More Information: +* [IPMI Specification 2nd Generation +v2.0](https://www.intel.com/content/dam/www/public/us/en/documents/prod +uct-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf) + +## Purpose +The IPMI feature provides firmware functionality that implements +behavior described in the IPMI specification. IPMI enables out-of-band and monitoring capabilities independent of the host system's CPU, firmware, and operating system. + +# High-Level Theory of Operation +*_TODO_* +A description of how the device works at a high-level. + +The description should not be constrained to implementation details but +provide a simple mental model of how the feature is supposed to work. + +## Firmware Volumes +*_TODO_* +A bulleted list of the firmware volumes that feature module(s) are placed in. + +## Modules +*_TODO_* +A bulleted list of the modules that make up the feature. + +## <Module Name> +*_TODO_* +Each module in the feature should have a section that describes the +module in a level of detail that is useful to better understand the module source code. + +## <Library Name> +*_TODO_* +Each library in the feature should have a section that describes the +library in a level of detail that is useful to better understand the library source code. + +## Key Functions +*_TODO_* +A bulleted list of key functions for interacting with the feature. + +Not all features need to be listed. Only functions exposed through +external interfaces that are important for feature users to be aware of. + +## Configuration +*_TODO_* +Information that is useful for configuring the feature. + +Not all configuration options need to be listed. This section is used +to provide more background on configuration options than possible elsewhere. + +## Data Flows +*_TODO_* +Architecturally defined data structures and flows for the feature. + +## Control Flows +*_TODO_* +Key control flows for the feature. + +## Build Flows +*_TODO_* +Any special build flows should be described in this section. + +This is particularly useful for features that use custom build tools or +require non-standard tool configuration. If the standard flow in the feature package template is used, this section may be empty. + +## Test Point Results +*_TODO_* +The test(s) that can verify porting is complete for the feature. + +Each feature must describe at least one test point to verify the +feature is successful. If the test point is not implemented, this should be stated. + +## Functional Exit Criteria +*_TODO_* +The testable functionality for the feature. + +This section should provide an ordered list of criteria that a board +integrator can reference to ensure the feature is functional on their board. + +## Feature Enabling Checklist +*_TODO_* +An ordered list of required activities to achieve desired functionality for the feature. + +## Common Optimizations +*_TODO_* +Common size or performance tuning options for this feature. + +This section is recommended but not required. If not used, the contents should be left empty. -- 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51720): https://edk2.groups.io/g/devel/message/51720 Mute This Topic: https://groups.io/mt/63457659/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-