Hi Laszlo, I can think of ways we may be able to get the label information into the body of the email in a PR comment. I will have to see if there is anyway to adjust the subject of the email. The subject appears to always match the title of the PR. That title is editable, but may only be editable using GitHub APIs. Mergify does not support that feature today.
If you look at the following file, you will see the current Mergify rules. https://github.com/tianocore/edk2/blob/master/.mergify/config.yml If I look at the 3rd rule for merge conflicts, I could split that out into 2 rules. One for push label set and one for push label not set and adjust the message generated to state if the conflict is on a personal build or a push request. Would small adjustments like this in the body of the email notifications help? If we make the generated messages consistent email filters on the content of the email body can be used instead of email filters on the email subject. Each developer can enable/disable the 'Watch' feature on the edk2 repo. That is a developer setting, not a team setting. Mike > -----Original Message----- > From: Laszlo Ersek <ler...@redhat.com> > Sent: Tuesday, December 3, 2019 12:56 AM > To: Kinney, Michael D <michael.d.kin...@intel.com>; > devel@edk2.groups.io; Sean Brogan > <sean.bro...@microsoft.com>; Bret Barkelew > <bret.barke...@microsoft.com>; Gao, Liming > <liming....@intel.com> > Subject: Re: [edk2-devel] EDK II Maintainers - EDK II > CI is now active on edk2/master > > On 12/02/19 20:55, Kinney, Michael D wrote: > > > So my question still stands. What notifications > would > > you like to see if we have the use case of a single > PR > > with multiple rounds of reviews and a transition from > > a PR without the 'push' label to a PR with a 'push' > label? > > Thank you for explaining. > > In this case, I think it would be helpful if, whenever > another email > notification were sent out about a PR, the subject of > that email > contained an auto-generated part that advertized the > push label's > presence on the PR, at that time. > > OTOH... It's also possible that I'm approaching this > wrong. After all, > before we adopted github.com for pushing, a maintainer > would just go > ahead and push post-review (with no *automatic* email > notification about > the fact), and then we'd expect that maintainer to > report back under the > patch review thread ("pushed as commit range ..."), > and/or close the BZ > ticket with a similar comment. (And then there would be > an > auto-generated bugzilla email about that.) > > My point being, maybe I shouldn't even *read* these > github.com > notifications at all. I'm not sure if they give me > useful information. > (When the PR is ultimately merged, we *still* require > the above kind of > closing comment in Bugzilla, from the maintainer -- > thus the originally > needed information is still provided, just like > before.) > > It's just that, *if* I attempt to read the github.com > emails, *then* > they confuse me (for example because they don't expose > the push label). > If we consider this specific kind of PR that we have > adopted for edk2 a > (practically) "maintainer-internal", mechanical, > action, then I guess I > might as well want to unsubscribe from those > notifications. After all > I'm still subscribed to BZ emails, and I'll see the > resultant commit > range noted there (through the comment that the > assignee adds manually, > when they close the BZ). > > Is it possible for a tianocore group member to > "unwatch" PRs? > > Thanks! > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51649): https://edk2.groups.io/g/devel/message/51649 Mute This Topic: https://groups.io/mt/53725670/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
