On 12/03/19 18:07, Kinney, Michael D wrote: > Hi Laszlo, > > I can think of ways we may be able to get the label > information into the body of the email in a PR comment. > I will have to see if there is anyway to adjust the subject > of the email. The subject appears to always match the title > of the PR. That title is editable, but may only be editable > using GitHub APIs. Mergify does not support that feature > today. > > If you look at the following file, you will see the current > Mergify rules. > > https://github.com/tianocore/edk2/blob/master/.mergify/config.yml > > If I look at the 3rd rule for merge conflicts, I could split > that out into 2 rules. One for push label set and one for > push label not set and adjust the message generated to state > if the conflict is on a personal build or a push request. > > Would small adjustments like this in the body of the email > notifications help? If we make the generated messages consistent > email filters on the content of the email body can be used > instead of email filters on the email subject.
Sounds great, thank you. I've checked the mail filtering solution that's available to me, and it appears capable of scanning email bodies. I suggest picking a GUID for the message body, in best UEFI style :) , for representing the *absence* of the "push" label. I generally prefer watching all kinds of notifications about the edk2 repo, *except* the personal CI builds. > Each developer can enable/disable the 'Watch' feature on the > edk2 repo. That is a developer setting, not a team setting. Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51661): https://edk2.groups.io/g/devel/message/51661 Mute This Topic: https://groups.io/mt/53725670/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
