Re: A reminder about MOZ_MUST_USE and [must_use]

2017-01-19 Thread Chris Peterson
On 1/19/2017 3:13 PM, Nicholas Nethercote wrote: On Fri, Jan 20, 2017 at 10:01 AM, wrote: > And the next step would be to make must-use the default, and have > MOZ_CAN_IGNORE for the rest. ;-) > I actually tried this with all XPIDL methods. After adding several hundred "Unused <<" annotations

Re: Intent to implement and ship: only allow Flash on HTTP/HTTPS sites

2017-02-07 Thread Chris Peterson
On 2/7/2017 1:15 PM, Benjamin Smedberg wrote: I intend to ship a change which will prevent Flash from loading from file:, ftp:, or any other URL scheme other than http: or https:. The purpose of this change is to increase security and limit Flash to well-tested configuraitons. Do you want to a

Re: Quantum Render builds now on m-c

2017-02-10 Thread Chris Peterson
Awesome news! Building Quantum Render in mozilla-central and running even a subset of our regular tests is a big step towards shipping. chris On 2/10/2017 1:11 PM, Kartikaya Gupta wrote: (cross-posted to dev-platform and dev-tech-gfx) This is just a heads up that earlier today we merged the

Re: All the processes

2017-03-03 Thread Chris Peterson
On 3/3/2017 4:15 PM, Nicholas Nethercote wrote: - plugin process: just for Flash now? On 32-bit Windows, there are multiple plugin processes because Firefox runs Flash in a plugin process and then Flash spawns one (or more?) of its own "Protected Mode" processes. IIUC, the Protected Mode proc

Re: Is there a way to improve partial compilation times?

2017-03-07 Thread Chris Peterson
On 3/7/2017 11:19 AM, Steve Fink wrote: I have at times spun off builds into their own cgroup. It seems to isolate the load pretty well, when I want to bother with remembering how to set it up again. Perhaps it'd be a good thing for mach to do automatically. Then again, if dropping the -j count

Re: Sheriff Highlights and Summary in February 2017

2017-03-07 Thread Chris Peterson
On 3/7/2017 3:38 AM, Joel Maher wrote: One large difference I see between autoland and mozilla-inbound is that on autoland we have many single commits/push whereas mozilla-inbound it is fewer. I see the Futurama data showing pushes and the sheriff report showing total commits. autoland also in

Re: Sheriff Highlights and Summary in February 2017

2017-03-10 Thread Chris Peterson
I think, and this is my next area to investigate, is the 1 bug per push (the autoland model) could be helping with the percentage of backouts being lower. David On 7 March 2017 at 21:29, Chris Peterson wrote: On 3/7/2017 3:38 AM, Joel Maher wrote: One large difference I see between autol

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Chris Peterson
On 3/17/2017 1:45 AM, Honza Bambas wrote: I have a very similar setup, with even way more exceptions added, but none of them has the desired effect. Unfortunately, the only way to make MsMpEng shut up is to disable run-time protection completely for the time of the build. I think it's a bug in De

Re: Quantum Flow Engineering Newsletter #4

2017-04-07 Thread Chris Peterson
On 2017-04-07 9:11 AM, Ehsan Akhgari wrote: - DOM. In the DOM team there are several plans and projects under way which will hopefully bring various performance improvements to the browser. Probably the largest one is the upcoming plans for cooperative scheduling of tasks, which wil

Re: e10s-multi on Aurora

2017-04-11 Thread Chris Peterson
On 2017-04-11 10:31 PM, Salvador de la Puente wrote: How does this relate with Project Down and the end of Aurora channel? Will be multi-e10s enabled when shifting from nightly to beta? There is no connection between Project Dawn and enabling multiple e10s content processes in the Aurora chann

Re: Quantum Flow Engineering Newsletter #5

2017-04-18 Thread Chris Peterson
On 2017-04-18 4:22 PM, Ehsan Akhgari wrote: The last time I checked with the graphics team, at this point it's completely unclear whether Quantum Render is going to make it, and as such, it's not reasonable for us to depend on anything that WebRender provides for Photon, because if QR wouldn't

Re: Quantum Flow Engineering Newsletter #6

2017-04-21 Thread Chris Peterson
btw, Nathan Froyd is working to add Gecko Profiler support for Stylo's Rust code and rayon threads in bug 1322656. On 2017-04-21 8:50 AM, Ehsan Akhgari wrote: On 04/21/2017 03:12 AM, Nicholas Nethercote wrote: Judging from the incoming flow of bug reports, the number of people using the Gecko

Re: CodeCoverage Monthly Update

2017-05-03 Thread Chris Peterson
On 2017-05-03 8:44 PM, Kyle Lahnakoski wrote: * Daily coverage reports on coveralls.io [1] and on codecov.io[2]. Which do you like? Does coveralls.io have a top-down coverage view like codecov.io? That view seems more useful for both people that want a global view and developers that wa

Re: QF bug whiteboard tags

2017-05-10 Thread Chris Peterson
On 2017-05-10 1:05 PM, Jim Mathies wrote: The quantum flow project has been filing a lot of bugs lately. I'm curious about two specific whiteboard tags I've seen - [qf:p1] and [qf], can someone explain the differences between these two tags and how this impact the priority of these bugs? Add

Re: Quantum Flow Engineering Newsletter #9

2017-05-19 Thread Chris Peterson
On 2017-05-12 9:55 AM, Ehsan Akhgari wrote: This reminded me of https://bugzilla.mozilla.org/show_bug.cgi?id=1332680 (and https://bugzilla.mozilla.org/show_bug.cgi?id=1332682 ) Adding -Wsuggest-final-types and -Wsuggest-final-methods and looking at the output seems pretty low-effort to find a lo

Re: Changing our thread APIs for Quantum DOM scheduling

2017-05-19 Thread Chris Peterson
The Quantum DOM doc says only content processes will get cooperative threading. How will cooperative threading work with multiple content processes (e10s-multi)? Will there be inter-process scheduling? For example, if content process #1 has one or more foreground tabs (from multiple windows) an

Re: Improving visibility of compiler warnings

2017-05-25 Thread Chris Peterson
On 2017-05-25 5:31 AM, Ehsan Akhgari wrote: On 05/19/2017 02:44 PM, Gregory Szorc wrote: `mach build` attempts to parse compiler warnings to a persisted "database." You can view a list of compiler warnings post build by running `mach warnings-list`. The intent behind this feature was to make it

Re: Linux builds now default to -O2 instead of -Os

2017-06-06 Thread Chris Peterson
On 6/6/17 10:33 AM, Boris Zbarsky wrote: On 6/1/17 9:04 PM, Mike Hommey wrote: Ah, forgot to mention that. No, it doesn't affect *our* shipped builds (because PGO uses a different set of optimization flags). But it does affect downstream builds that don't PGO. Based on the jump I see on June

Re: JSBC: JavaScript Start-up Bytecode Cache

2017-06-13 Thread Chris Peterson
Nicolas, when JSBC is enabled by default, should we change our test procedure for our various page load tests (Talos and Softvision's manual testing)? Since the first page load will be slower than subsequent page loads (as you noted in the bug [1]), should we throw away the first page load time

Re: Intent to unship: HTML scoped style sheets (

2017-06-20 Thread Chris Peterson
On 6/20/17 2:14 AM, Cameron McCormack wrote: Cameron, what bug should this one block (iiuc chrome support will be removed a bit later, so we have some time, do you already have a bug for that part?) Actually, let me backtrack a little. I might be misremembering our plans for Stylo in chrom

Re: Profiling nightlies on Mac - what tools are used?

2017-06-20 Thread Chris Peterson
On 6/20/17 10:28 AM, Ehsan Akhgari wrote: That seems like the obvious next step to investigate to me. We should *really* only talk about stripping builds as the last resort IMO, since we have way too many developers using OSX every day... Does profiling an unstripped Mac build still produce u

Re: Profiling nightlies on Mac - what tools are used?

2017-06-21 Thread Chris Peterson
On 6/21/17 8:06 AM, Boris Zbarsky wrote: On 6/21/17 10:44 AM, Ehsan Akhgari wrote: It seems like that we have an answer now in the bug! https://bugzilla.mozilla.org/show_bug.cgi?id=1338651#c129 Just for clarity, so people don't have to read the whole bug, changing the _path_ the build is at w

Re: Quantum Flow Engineering Newsletter #14

2017-06-23 Thread Chris Peterson
On 6/23/17 12:17 AM, Ehsan Akhgari wrote: But to speak of a more direct measurement of performance, let's look at our progress on Speedometer V2 . Today, I measured our progress so far on this benchmark by comparing

FYI: Questions about the Gecko Profiler? Drop by the #flow IRC channel.

2017-06-30 Thread Chris Peterson
Just a reminder: if you or engineers on your team have questions about using the Gecko Profiler (https://perf-html.io/), you can ask for help in the #flow IRC channel. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.o

Re: Linting for common causes of oranges in mochitests (need ideas)

2017-07-06 Thread Chris Peterson
On 7/6/17 11:47 AM, Andrew Halberstadt wrote: # Are there additional things not listed on that page that we could lint for? Do we want to discourage tests from using Date (`new Date` or `Date.now()`) for measuring time? Dates are affected by time zones, DST, and clock skew issues jumping fo

Re: More Rust code

2017-07-10 Thread Chris Peterson
On 7/10/17 4:48 PM, Xidorn Quan wrote: The first thing comes to my mind is crash reports. It currently doesn't always include useful panic message from Rust, see for example [1] and [2]. Also for Stylo, we generate lots of code (including using bindgen and mako template system, bindgen is usua

64-bit Firefox progress report: 2017-07-18

2017-07-18 Thread Chris Peterson
We are on track to make 64-bit Firefox the default build for Win64 OS, bringing improved ASLR and fewer OOM crashes to the 70% of Windows Firefox users running Win64. PLANS: * In Firefox 55 (August 8), the Windows stub installer will default to 64-bit Firefox for eligible users (Win64 and 2+

Re: 64-bit Firefox progress report: 2017-07-18

2017-07-19 Thread Chris Peterson
On 2017-07-19 12:01 AM, Mike Hommey wrote: What's the plan for eligible people that still want to keep 32-bit Firefox? Are they going to have to stop auto upgrades, which would get them automatically on 64-bits and upgrade manually? This is especially going to be a problem for users with less th

Re: 64-bit Firefox progress report: 2017-07-18

2017-07-19 Thread Chris Peterson
On 2017-07-19 10:18 AM, Mike Hoye wrote: On 2017-07-19 3:58 AM, Chris Peterson wrote: On 2017-07-19 12:01 AM, Mike Hommey wrote: What's the plan for eligible people that still want to keep 32-bit Firefox? Outside of our QA team (or others orgs, I guess?) do we have a set of use cases

Re: 64-bit Firefox progress report: 2017-07-18

2017-07-20 Thread Chris Peterson
On 2017-07-19 6:58 PM, Mike Hommey wrote: I don't understand why that would be, but if so it should show in crashstats as fewer small OOMs on these devices. Does the data actually show that? I don't know. Can that be filtered? I'm not sure I'm answering the right question, but searching thro

Re: Keyboard APZ has landed on Inbound

2017-07-24 Thread Chris Peterson
On 2017-07-21 11:05 PM, Ryan Hunt wrote: The patch to enable async keyboard scrolling in nightly (for all platforms except Android) has landed on inbound. Once this is merged to central, key scrolling will be done by the compositor instead of on the main thread in most cases. This should bring t

Heads up! Building Stylo in local developer builds

2017-07-28 Thread Chris Peterson
Stylo support (pref'd off) has been built in automation builds for a couple weeks. Ralph Giles just landed bug 1384258 to also build Stylo support (pref'd off) in local developer builds, too. You should rerun `mach bootstrap` to make sure you have the latest versions of the Stylo and Rust depen

Re: Heads up! Building Stylo in local developer builds

2017-07-28 Thread Chris Peterson
i686-pc-windows-msvc' and cannot be re-added You can fix this problem by running: rustup default stable-x86_64-pc-windows-msvc On 2017-07-28 1:04 AM, Chris Peterson wrote: Stylo support (pref'd off) has been built in automation builds for a couple weeks. Ralph Giles just landed bug 1384258 t

Re: Heads up! Building Stylo in local developer builds

2017-07-31 Thread Chris Peterson
t for mach bootstrap to run xcode-select automatically. On 2017-07-28 1:04 AM, Chris Peterson wrote: Stylo support (pref'd off) has been built in automation builds for a couple weeks. Ralph Giles just landed bug 1384258 to also build Stylo support (pref'd off) in local developer bui

Re: sccache as ccache

2017-08-06 Thread Chris Peterson
On 2017-08-05 10:49 AM, ISHIKAWA, Chiaki wrote: However, I am not sure if the cache is working correctly. With ccache, we can specify a log file in the environment variable CCACHE_LOGFILE to specify. We can study the log file to see if the cache is indeed working (hits, etc). Is there an equi

Re: 64-bit Firefox progress report: 2017-07-18

2017-08-07 Thread Chris Peterson
On 2017-08-06 11:26 PM, Henri Sivonen wrote: On Thu, Jul 20, 2017 at 10:42 AM, Chris Peterson wrote: Users with only 2 GB and 5 minute browser sessions would probably have a faster user experience with 32-bit Firefox than with 64-bit, but how do we weigh that experience versus the security

Re: 64-bit Firefox progress report: 2017-07-18

2017-08-07 Thread Chris Peterson
: https://searchfox.org/mozilla-central/source/browser/installer/windows/nsis/stub.nsi#189-195 On 2017-08-07 1:19 AM, Nicholas Nethercote wrote: I think the 2GB "requirement" from Microsoft should be ignored, because plenty of our users are ignoring it. Nick On Mon, Aug 7, 2017 at 5:51

Re: 64-bit Firefox progress report: 2017-07-18

2017-08-08 Thread Chris Peterson
for only 1% of Win64 OS users. As we are preparing to migrate Beta users to 64-bit, we see the minimum memory requirement adds new complexity to both the client and server components of the update process and extra QA for this one-time migration event. On Mon, Aug 7, 2017 at 5:51 PM, Ch

Re: CodeCoverage! Monthly Update

2017-08-10 Thread Chris Peterson
Kyle, do you know if Rust code coverage is blocked on any remaining Rust toolchain issues? chris On 2017-08-10 11:31 AM, Kyle Lahnakoski wrote: Did you have that sense you were missing something? Well, you were right: You were missing your ... # *Monthly CodeCoverage! update!  \o/ * /If

Re: how to make your local --enable-optimize builds compile Rust faster

2017-08-11 Thread Chris Peterson
Matt Brubeck just a patch to disable Rust LTO on local Firefox builds, so you no longer need to manually apply Nathan's patch to disable LTO locally. https://bugzilla.mozilla.org/show_bug.cgi?id=1386371#c34 On 2017-08-09 11:49 AM, Nathan Froyd wrote: TL; DR: apply https://github.com/froydnj

Re: 64-bit Firefox progress report: 2017-07-18

2017-08-14 Thread Chris Peterson
ms wrong. The chart shows more like a 60% improvement instead of a 39% improvement. Perhaps we should just replace this graphic with an up-arrow for security and a down-arrow for crashes? Anyway, sorry to be pedantic, but misleading charts are kind of a pet peeve. Thanks. Ben On Wed, Jul 19, 20

Re: New string types: nsAutoStringN<> and nsAutoCStringN<>

2017-08-21 Thread Chris Peterson
On 2017-08-21 5:31 PM, Eric Rahm wrote: I'm not sure how much backing that has -- we'd be going from nsString => String which is pretty close to std::string -- it would be interesting to get some feedback. Or follow Rust's precedent and use type name `Str`. That would avoid confusion with std:

Re: Stylesheet wait timeout?

2017-08-31 Thread Chris Peterson
Gerv, do you have Stylo enabled? Even if you did not flip the pref (layout.css.servo.enabled), you might be in the Stylo experiment for Nightly users. Check about:support for "Stylo". On 2017-08-31 10:24 AM, Gervase Markham wrote: On 18/08/17 12:11, Gervase Markham wrote: Whereas what I me

Re: Stylesheet wait timeout?

2017-08-31 Thread Chris Peterson
o not have stylo enabled per about:support ("false (disabled by default)"). Dustin 2017-08-31 13:45 GMT-04:00 Chris Peterson : Gerv, do you have Stylo enabled? Even if you did not flip the pref (layout.css.servo.enabled), you might be in the Stylo experiment for Nightly users. Check ab

Re: Stylo now the default configuration for mozilla-central

2017-09-05 Thread Chris Peterson
On 2017-09-05 1:10 PM, J. Ryan Stinnett wrote: Assuming bug 1330412 sticks, Stylo will be the default configuration for mozilla-central for all platforms except Android. Thanks to everyone involved with Stylo that helped us reach this stage! Awesome! Thanks for flipping the switch, Ryan. To

Re: Device Memory header and JS API

2017-09-06 Thread Chris Peterson
On 2017-09-06 11:48 AM, Tom Ritter wrote: Steam's hardware survey shows the following distribution percentages. Less than 512 MB 0.00% 512 Mb to 999 MB 0.03% 1 GB 0.52% 2 GB 3.30% 3 GB 6.27% 4 GB 14.96% 5 GB 0.66% 6 GB 3.23% 7 GB 2.33% 8 GB 42.77% 9 GB 0.04% 10 GB 0.29% 11 GB 0.18% 12 G

Re: Coding style: Placement of binary operators when breaking a long line

2017-09-07 Thread Chris Peterson
On 2017-09-06 8:06 PM, Ehsan Akhgari wrote: The interesting points to consider is the data that Nick alluded to in the previous discussion about the existing prevalent style. Also, the point you up about the pragmatic aspect of the need to be able to use automated tools in order to manage our

Re: test-verify now running as tier 2

2017-10-02 Thread Chris Peterson
This is very cool, Geoff! People have been talking about this idea for a long, so it is great to see it actually running. I'm glad to see chaos mode being tested, too. On 2017-10-02 10:11 AM, Geoffrey Brown wrote: Today the test-verify test task will start running as a tier 2 job. Look for th

Re: Changes to tab min-width

2017-10-03 Thread Chris Peterson
On 2017-10-03 2:18 PM, Boris Zbarsky wrote: Right now, at 60px, I can see 7-10 chars in a tab title.  This is sometimes (but not always) enough for me to make sense of what I'm looking at when the favicon is not helpful.  For example, for bugzilla bugs I can see the whole bug number. In the n

Re: We need better canaries for JS code

2017-10-18 Thread Chris Peterson
On 2017-10-18 4:51 AM, Mark Banner wrote: I expect that this will find a number of lurking errorsy, so we may want to migrate code progressively, using a directive, say "use strict moz-platform" and static analysis to help encourage using this directive. It would definitely be interesting to fail

Re: Nightly Start Time and Daylight Savings

2017-11-06 Thread Chris Peterson
On 2017-11-06 9:46 AM, Justin Wood wrote: Now with Taskcluster the start time is anchored in UTC so doesn't move along with Daylight Savings, currently anchoring at 10am and 10pm UTC. How long do the Nightly builds typically take? If the builds are started at 10am and 10pm UTC (2am and 5pm PST

Re: PSA: Avoid invoking Debug formatters in release-mode Rust

2018-01-16 Thread Chris Peterson
On 2018-01-12 9:07 PM, Bobby Holley wrote: The most common way this seems to happen is in panic!() messages, where it can be tempting to include a stringified value to make the message more informative. Just a friendly reminder: panic messages that are parameterized to include debug data might

Chrome will start marking HTTP pages as "Not secure"

2018-02-08 Thread Chris Peterson
Chrome will start marking HTTP pages as "Not secure" in July 2018 (Chrome 68): https://security.googleblog.com/2018/02/a-secure-web-is-here-to-stay.html Firefox has a similar insecure HTTP warning icon, currently disabled by the `security.insecure_connection_icon.enabled` pref added in bug 131

PSA: C++ virtual function declarations should specify only one of virtual, final, or override

2018-02-16 Thread Chris Peterson
Mozilla's C++ style guide [1] says (since 2015) virtual function declarations should specify only one of `virtual`, `final`, or `override`. Over the weekend, I will land a mach lint check (bug 1436263) that will warn about some virtual style violations such as: virtual void Bad1() final v

Re: PSA: C++ virtual function declarations should specify only one of virtual, final, or override

2018-02-16 Thread Chris Peterson
On 2018-02-16 1:07 PM, L. David Baron wrote: virtual void Bad1() final I think there might be some legitimate use cases for this one, when a function needs to be virtual because it's required for the calling convention (as part of a binary plugin API or binary embedding API, for example), but

Re: PSA: C++ virtual function declarations should specify only one of virtual, final, or override

2018-02-16 Thread Chris Peterson
On 2018-02-16 12:54 PM, Ben Kelly wrote: Are we supposed to just use override or final on methods that are overriden when the class itself is marked final? Personally writing final again seems redundant with the class level final and the override keyword seems more informative. You could use e

Re: Upcoming C++ standards meeting in Rapperswil, Switzerland

2018-05-23 Thread Chris Peterson
On 2018-05-23 1:35 PM, Botond Ballo wrote: There is also work being done in this area outside the formal standards process, in the form of the C++ Core Guidelines [2] (some of which can be checked statically) and the accompanying Guideline Support Library [3], and in the form of Microsoft's lifet

Re: Using clang-cl to ship Windows builds

2018-07-10 Thread Chris Peterson
How does the performance of clang-cl builds compare to MSVC builds on benchmarks like Speedometer? On 2018-07-10 1:29 PM, David Major wrote: Bug 1443590 is switching our official Windows builds to use clang-cl as the compiler. Please keep an eye out for regressions and file a blocking bug for

Re: Intent to ship '-webkit-appearance' and changes to '-moz-appearance' values

2018-08-07 Thread Chris Peterson
Awesome! This should fix some common webcompat issues for Firefox/GeckoView on Android. What are the criteria for letting -webkit-appearance ride the trains? The GeckoView team is eager to ship mobile webcompat fixes, so they might be willing to accept more risk than Firefox desktop. Are the

Fingerprinting of battery status?

2015-08-03 Thread Chris Peterson
What is a legitimate use case for a web page to know my battery status? Battery level and time remaining can be used to fingerprint users. A mobile webapp might use battery level to throttle its activity, but that could be something the OS handles by pausing or throttling apps directly or broa

Rewriting YouTube's Flash video embedding code to use HTML video?

2015-08-21 Thread Chris Peterson
Does Gecko have a precedent for rewriting certain HTML patterns? YouTube is migrating from Flash to HTML video, but many third-party websites copied YouTube's old example code to embedded Flash videos. YouTube's current embedding code automatically switches between Flash and HTML video, but You

Re: Rewriting YouTube's Flash video embedding code to use HTML video?

2015-08-21 Thread Chris Peterson
On 8/21/15 4:31 PM, Hubert Figuière wrote: Disclaimer: I wrote the Firefox add-on mentioned, and I filed the bug mentioned as well. So my opinion is sorta made. Yes, thank you! :) On 21/08/15 06:17 PM, Chris Peterson wrote: Does Gecko have a precedent for rewriting certain HTML patterns

Re: Rewriting YouTube's Flash video embedding code to use HTML video?

2015-08-24 Thread Chris Peterson
On 8/24/15 9:43 AM, Ehsan Akhgari wrote: We have done a site specific workaround in the past for hotmail that we almost shipped , so there is prior art here. I think that for the specific case at hand, it does make sense to add a site-specific

Re: The opt-in FAIL_ON_WARNINGS has been replaced with the opt-out ALLOW_COMPILER_WARNINGS

2015-08-31 Thread Chris Peterson
On 8/30/15 5:53 PM, Nicholas Nethercote wrote: I just landed the patches in bug 1198334 that do exactly that. The option has also changed name and is now called ALLOW_COMPILER_WARNINGS. (If you're wondering why I changed the name, it's because it's easier in mozbuild to have an option that defaul

Re: The opt-in FAIL_ON_WARNINGS has been replaced with the opt-out ALLOW_COMPILER_WARNINGS

2015-08-31 Thread Chris Peterson
On 8/31/15 11:54 AM, Ted Mielczarek wrote: On Mon, Aug 31, 2015, at 01:47 PM, Chris Peterson wrote: >Should we hold third-party code to the same warning levels as Mozilla's >home-grown code? When we find warnings in third-party code, we typically >just suppress them because they w

Updates to Chrome platform support

2015-11-10 Thread Chris Peterson
http://chrome.blogspot.com/2015/11/updates-to-chrome-platform-support.html * Chrome’s support for Windows XP will be extended from December 2015 to April 2016 (after previously extending from April 2015 to December 2015). * Chrome will also drop support for Windows Vista and Mac OS X 10.6, 10

Re: Updates to Chrome platform support

2015-11-10 Thread Chris Peterson
btw, I reposted this on the firefox-dev mailing list because people on IRC thought that was a more appropriate forum: https://mail.mozilla.org/pipermail/firefox-dev/2015-November/003523.html On 11/10/15 1:37 PM, Chris Peterson wrote: http://chrome.blogspot.com/2015/11/updates-to-chrome

FYI: updating yasm on build machines

2015-11-16 Thread Chris Peterson
mozilla-build uses yasm 1.3, but the build machines still use yasm 1.1, which is at least three years out of date. Bug 1224408 will update the build machines to use yasm 1.3. There are no expected problems because local builds using mozilla-build tools already use 1.3. mozilla-central has yasm

Re: FYI: updating yasm on build machines

2015-11-20 Thread Chris Peterson
On 11/20/15 5:09 AM, Neil wrote: Chris Peterson wrote: mozilla-build tools already use 1.3 When did it get upgraded? (My mozilla-build only has yasm 1.1) Last year according to bug 1113450: https://bugzilla.mozilla.org/show_bug.cgi?id=1113450

Re: TIFU by using Math.random()

2015-11-25 Thread Chris Peterson
On 11/25/15 5:51 AM, Xidorn Quan wrote: According to the article, SpiderMonkey's PRNG is not much better than V8's. It seems we are using a even older algorithm, although ironically have a better result. After reading this article as well as some introduction from the wikipedia, it seems to me t

Re: Dan Stillman's concerns about Extension Signing

2015-11-25 Thread Chris Peterson
On 11/25/15 11:16 AM, Jeff Gilbert wrote: I doubt anyone is going to switch to Firefox because our extension signing is safe. (though I do think we should have some form of signing) But they will gladly switch away when anything breaks, particularly when we reduce the activation energy needed to

Re: Status: ASan builds on Windows

2015-12-15 Thread Chris Peterson
On 12/15/15 4:36 PM, Emanuel Hoogeveen wrote: Not to derail the topic, but I wonder how many crashes would be more actionable if they were caught earlier by assertions. I believe Chrome Canary has assertions enabled for their testing audience. I don't know how pleasant this would be for Nightl

Re: Too many oranges!

2015-12-22 Thread Chris Peterson
On 12/22/15 9:39 AM, Jonathan Griffin wrote: If we dedicate a cycle to quality and tests, we should use that opportunity to figure out what a more viable strategy is longer-term for making sure these don't get out of hand again, which might include having teams adopt test, suites, and the intermi

Re: e10s status update (not going to GA in 45)

2015-12-30 Thread Chris Peterson
On 12/30/15 12:30 PM, Brad Lassey wrote: *Population.* Our plan has been to release e10s first to users who have no add-ons and no a11y features enabled due to known issues with those two areas of code. Our crash data from the 44 experiment indicates that we have both sets of users in the experim

Re: Heads-up: SHA1 deprecation (for newly issued certs) causes trouble with local ssl-proxy mitm spyware

2016-01-04 Thread Chris Peterson
On 1/4/16 10:45 AM, Daniel Holbert wrote: On 01/04/2016 10:33 AM, Josh Matthews wrote: >Wouldn't the SSL cert failures also prevent submitting the telemetry >payload to Mozilla's servers? Hmm... actually, I'll bet the cert errors will prevent Firefox updates, for that matter! (I'm assuming the

Re: Does SSE2 usage still need to be conditional?

2016-02-01 Thread Chris Peterson
On 2/1/16 3:56 PM, Mike Hommey wrote: > 64-bits Firefox was only officially released recently, and AFAIK, we're not > offering 32-bits Firefox users an upgrade to 64-bits Firefox if their > system permits. How about we started doing that? There are two steps planned to bring 64-bit Firefox to norm

Re: rr chaos mode update

2016-02-15 Thread Chris Peterson
On 2/14/16 9:16 PM, Robert O'Callahan wrote: Lots of tests have been disabled for intermittency over the years. Now we have the ability to fix (at least some of) them without much pain, it may be worth revisiting them, though i don't know how to prioritize that. We might want to revisit our work

Re: Talos e10s dashboard

2016-02-28 Thread Chris Peterson
On 2/26/16 3:58 PM, William Lachance wrote: I wrote up a dashboard for tracking the performance delta between non-e10s and e10s on the Talos tests on nightly: https://treeherder.allizom.org/perf.html#/e10s (sometime next week, https://treeherder.mozilla.org/perf.html#/e10s will work too) Note

Re: Talos e10s dashboard

2016-03-01 Thread Chris Peterson
On 3/1/16 9:57 AM, William Lachance wrote: Also, mconley suggested being able to compare the results of individual subtests. You can access this view for any given talos test by hovering over the line in the comparison and selecting "subtests". This sometimes give interesting data, for instance o

PSA: Introducing MOZ_FALLTHROUGH to annotate intentional switch fallthroughs

2016-03-06 Thread Chris Peterson
TL;DR? Annotate intentional switch fallthroughs with `MOZ_FALLTHROUGH;` or `MOZ_FALLTHROUGH_ASSERT();` instead of `// fall through` comments. The details: clang's -Wimplicit-fallthrough warning (currently off) reports switch cases that fall through without a break or return statement. MOZ_F

Re: Linux distro readiness for Rust in Gecko

2016-03-20 Thread Chris Peterson
On 3/20/16 3:04 AM, Henri Sivonen wrote: On Sat, Mar 19, 2016 at 2:27 PM, wrote: > On Thursday, 17 March 2016 12:23:32 UTC, Henri Sivonen wrote: >> (rustc originally bootstrapped with OCaml, but >> building the whole history of Rust from the OCaml days to present >> every time Fedora builds

Re: Skia Content on OS X

2016-03-22 Thread Chris Peterson
On 3/22/16 9:03 AM, Mason Chang wrote: It’s also quite nice that micro-level optimizations at the backend level can mostly be done for us as Skia is optimizing performance with Chrome as one of their use cases. On which platforms does Chrome use Skia? _

Re: Linux distro readiness for Rust in Gecko

2016-03-24 Thread Chris Peterson
On 3/24/16 10:13 AM, atu...@mozilla.com wrote: The Rust core team met yesterday and developed a complete plan for Rust to be build with the previous stable compiler as snapshot. We will be landing the infrastructure needed to do this shortly. In terms of release timing, it will take some time

Re: Intent to switch to Visual Studio 2015

2016-03-25 Thread Chris Peterson
On 3/24/16 9:44 AM, Gregory Szorc wrote: Inbound is now building with VS2015! Chromium switched to VS2015 in March 2016. The following blog post details some of the compiler bugs Google found. It might be worth reviewing them in case Firefox runs into any of them. https://randomascii.wordpr

Re: Triage Plan for Firefox Components

2016-03-31 Thread Chris Peterson
On 3/31/16 3:22 PM, Daniel Veditz wrote: ​We get that now, with no marker at all. The only real difference I see with a marker is that people will catch on sooner whereas now it takes a while until they realize they are being ignored. They eventually get discouraged​ or upset either way. Might ev

Re: Triage Plan for Firefox Components

2016-04-01 Thread Chris Peterson
On 4/1/16 10:57 AM, Emma Humphries wrote: Could you add how your team maps the the priority flag, or link to a page describing it? https://wiki.mozilla.org/index.php?title=Bugmasters/Projects/Folk_Knowledge/Priority_Field&action=edit&redlink=1 This is interesting information! Do you have other

Re: Coding style for C++ enums

2016-04-11 Thread Chris Peterson
On 4/8/16 8:10 AM, Kartikaya Gupta wrote: Is there a recommendation for what enum values in C++ code should be styled as? The coding style doesn't say and we use a variety of things in existing code, so I was wondering if we should settle on something for new enums being added to the code, and up

Re: Triage Plan for Firefox Components

2016-04-12 Thread Chris Peterson
I've long thought that Bugzilla should be more like Wikipedia: the "front page" of the bug is editable and always up-to-date (i.e. not incorrect or outdated STRs), but the history and meta discussion is still available on a "back page". On 4/12/16 2:19 PM, David Lawrence wrote: I used to thi

Intent to ship: Treat cookies set over non-secure HTTP as session cookies

2016-04-14 Thread Chris Peterson
Summary: Treat cookies set over non-secure HTTP as session cookies Exactly one year ago today (!), Henri Sivonen proposed [1] treating cookies without the `secure` flag as session cookies. PROS: * Security: login cookies set over non-secure HTTP can be sniffed and replayed. Clearing those co

Re: Intent to ship: Treat cookies set over non-secure HTTP as session cookies

2016-04-14 Thread Chris Peterson
o better understand these scenarios. I'm surprised we don't have much telemetry about cookie usage. Monica Chew wrote [1] about a Mozilla study of cookies, but that was only 573 users back in 2013. chris [1] http://monica-at-mozilla.blogspot.com/2013/10/cookie-counting.html On 4

Re: Intent to ship: Treat cookies set over non-secure HTTP as session cookies

2016-04-15 Thread Chris Peterson
On 4/15/16 7:47 AM, Tantek Çelik wrote: What steps can we take in this direction WITHOUT breaking web compat? Would this feature actually break web compatibility? Or just needlessly annoy users? In his original post, Henri argued that clearing non-HTTPS cookies between sessions would not "B

Re: Intent to ship: Treat cookies set over non-secure HTTP as session cookies

2016-04-17 Thread Chris Peterson
On 4/15/16 2:12 AM, Jason Duell wrote: > Focusing on third-party session cookies is an interesting idea. > "Sessionizing" non-HTTPS third-party cookies would encourage ad networks > and CDNs to use HTTPS, allowing content sites to use HTTPS without mixed > content problems. Much later, we could c

Re: Moving XP to ESR?

2016-04-18 Thread Chris Peterson
On 4/18/16 6:46 AM, Thomas Zimmermann wrote: Am 18.04.2016 um 15:18 schrieb Kyle Huey: > 12% of our users are on Windows XP. And XP still runs on ~10% of all desktops. That's an opportunity to convert some of the users to Firefox. If we want to convert some Chrome XP users, we could run a sma

Re: Intent to ship: Treat cookies set over non-secure HTTP as session cookies

2016-04-19 Thread Chris Peterson
On 4/19/16 1:58 AM, Panos Astithas wrote: Why should we be the ones to take the web compat hit on this? > > is the fundamentally biggest issue. > I realize I'm late to this thread and the discussion has moved the original proposal towards something more refined and hence more likely to succeed,

Re: Proposal: use nsresult& outparams in constructors to represent failure

2016-04-21 Thread Chris Peterson
On 4/20/16 11:43 PM, Gerald Squelart wrote: How about another generic helper, e.g.: template Maybe MakeCheckedMaybe(Args&&... aArgs) { nsresult rv; Maybe m = Some(T(std::forward(aArgs)..., &rv)); if (NS_SUCCEEDED(rv)) { return m; } return Nothing(); } Existing

Re: Intent to ship: Restrict geolocation.watchPosition to secure contexts

2016-04-21 Thread Chris Peterson
On 4/21/16 11:00 AM, Richard Barnes wrote: This is clearly a powerful feature, so it's a natural candidate for restriction. Chromium is restricting all of navigator.geolocation as of 50: https://codereview.chromium.org/1530403002/ Just to be clear, Firefox will still allow getCurrentPosition(

Re: MOZ_WARN_UNUSED_RESULT has been renamed as MOZ_MUST_USE

2016-04-29 Thread Chris Peterson
On 4/29/16 5:53 AM, Nathan Froyd wrote: This is a noble goal, but there is an enormous amount of code that would need to be modified to make this feasible. Perhaps if you exempted nsresult from MOZ_MUST_USE types. In theory, nsresult seems like an important type to check. That said, I once tr

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-05-02 Thread Chris Peterson
On 5/2/16 4:10 PM, Gregory Szorc wrote: So where does that leave us on Universal OS X builds? IIRC our blocker is the need to support 32-bit Silverlight in the plugin container so various streaming services using it don't break. Where are we on that front? (Reminder: killing Universal OS X packag

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-05-02 Thread Chris Peterson
On 5/2/16 5:18 PM, Gregory Szorc wrote: On Mon, May 2, 2016 at 5:12 PM, Chris Peterson wrote: On 5/2/16 4:10 PM, Gregory Szorc wrote: So where does that leave us on Universal OS X builds? IIRC our blocker is the need to support 32-bit Silverlight in the plugin container so various streaming

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-05-03 Thread Chris Peterson
On 5/3/16 3:11 AM, Xidorn Quan wrote: > Then we should plan to drop Universal builds in the same release, > because without supporting 10.6 or 32-bit NPAPI plugins, the 32-bit half > of the build is just cruft. That doesn't mean we can't remove 32-bit NPAPI support on OS X sooner than 53. Most

  1   2   3   4   >