On 12/15/15 4:36 PM, Emanuel Hoogeveen wrote:
Not to derail the topic, but I wonder how many crashes would be more actionable if they were caught earlier by assertions. I believe Chrome Canary has assertions enabled for their testing audience. I don't know how pleasant this would be for Nightly users (like myself), since Nightly right now is usually pretty stable, but turning MOZ_ASSERT into MOZ_RELEASE_ASSERT (at build time) for a select audience would at least be easy to do.
You can selectively enable release asserts in pre-release channels using MOZ_DIAGNOSTIC_ASSERT. It's defined as MOZ_RELEASE_ASSERT in Nightly and Aurora and debug-only MOZ_ASSERT in Beta and Release.
Instead of blindly enabling possibly-flaky MOZ_ASSERTs in Nightly, we could start by converting some important asserts to MOZ_DIAGNOSTIC_ASSERT (or even MOZ_RELEASE_ASSERT).
https://mxr.mozilla.org/mozilla-central/ident?i=MOZ_DIAGNOSTIC_ASSERT _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform