Re: Pink pixel of death (reftest failures due to bad RAM)

2013-07-10 Thread L. David Baron
[ responding to the two months worth flood of email that just resulted from https://bugzilla.mozilla.org/show_bug.cgi?id=891906 ] On Thursday 2013-05-30 14:51 -0400, Armen Zambrano G. wrote: > We have found that sometimes we fail our reftest tests due to a > couple of pixels getting store in bad

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Neil
smaug wrote: One thing, which has often brought up, would be to have other automatic coding style checker than just Ms2ger. At least in the DOM land we try to follow the coding style rules rather strictly and it would ease reviewers work if there was some good tool which does the coding style

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Chris Peterson
On 7/10/13 3:01 PM, Justin Lebar wrote: I can't see how they are a good alternative. With patch queues, I can maintain a complex refactoring in a patch queue containing dozens of smallish patches. In particular, I can easily realize I made a mistake in patch 3 while working on patch 21 and make

Re: review stop-energy (was 24hour review)

2013-07-10 Thread L. David Baron
On Tuesday 2013-07-09 15:46 -0400, Boris Zbarsky wrote: > * When requesting a second review on a patch, provide an interdiff > so that the reviewer can just verify that the changes you made match > what they asked for. Bugzilla's interdiff is totally unsuitable for > this purpose, unfortunately, b

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Taras Glek
L. David Baron wrote: [ responding to the two months worth flood of email that just resulted from https://bugzilla.mozilla.org/show_bug.cgi?id=891906 ] On Tuesday 2013-07-09 12:14 -0700, Taras Glek wrote: a) Realize that reviewing code is more valuable than writing code as it results in hi

Re: review stop-energy (was 24hour review)

2013-07-10 Thread L. David Baron
[ responding to the two months worth flood of email that just resulted from https://bugzilla.mozilla.org/show_bug.cgi?id=891906 ] On Tuesday 2013-07-09 12:14 -0700, Taras Glek wrote: > a) Realize that reviewing code is more valuable than writing code as > it results in higher overall project act

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Mark Côté
On 2013-07-10 2:18 PM, Boris Zbarsky wrote: > On 7/10/13 1:58 PM, Mark Côté wrote: >> The BMO team is again considering switching to ReviewBoard, which should >> fix this problem > > How does ReviewBoard address this? > > Again, what we have in the bug is diff 1 against changeset A and diff 2 > a

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Joshua Cranmer 🐧
On 7/10/2013 5:01 PM, Justin Lebar wrote: History in git is no more or less immutable than in hg. Every time you hg qpop or qref, you're mutating history. However, newer versions of hg make it much harder to mutate "official" history via the phases work. In effect, only the stuff in developmen

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Justin Lebar
One definition of insanity is doing the same thing twice and expecting different results. I recall that Taras has written basically this same e-mail before. We seem to have this conversation every six months or so. Why do we expect different results this time? If I can propose something that's

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Justin Lebar
On Fri, May 31, 2013 at 4:07 PM, Matt Brubeck wrote: > On 5/31/2013 12:32 PM, Boris Zbarsky wrote: >> >> On 5/31/13 3:20 PM, Matt Brubeck wrote: >>> >>> blame mobile/android/chrome/content/browser.xul: >>>git 1.015s >>>hg 0.830s >> >> >> Was this a git blame -C (which would be more simila

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Taras Glek
Boris Zbarsky wrote: On 7/9/13 9:59 PM, therealbrendane...@gmail.com wrote: Yes, that's what I meant. How else could one respond within a day? Some of the "within a day" proposals have suggested that it include weekends, fwiw. Ok. Does this need to go on wiki.m.o or MDN somewhere (not that

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Justin Lebar
> I can't see how they are a good alternative. With patch queues, I can > maintain a complex refactoring in a patch queue > containing dozens of smallish patches. In particular, I can easily realize I > made a mistake in patch 3 while working on patch > 21 and make sure that the fix ends up in pa

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Jeff Walden
On 07/09/2013 07:17 PM, Joshua Cranmer 🐧 wrote: >> I've said this before, not sure it's written in wiki-stone, maybe it should >> be: if you get a review request, respond same-day either with the actual >> review, or an ETA or promise to review by a certain date. > > For reviewers who are not Mo

Re: Mail Explosion

2013-07-10 Thread Benjamin Smedberg
On 7/10/2013 6:09 PM, Dustin Oprea wrote: I've only been auditing the devs for a couple of months, but does anyone know what's going on with the mail? I just received like forty messages. Mail delivery for people subscribed to this forum (and many other forums) via mailman was interrupted, appar

Re: Mail Explosion

2013-07-10 Thread Kevin Brosnan
See https://bugzilla.mozilla.org/show_bug.cgi?id=891906 On Jul 10, 2013 3:11 PM, "Dustin Oprea" wrote: > I've only been auditing the devs for a couple of months, but does anyone > know what's going on with the mail? I just received like forty messages. > > > Dustin Oprea > ___

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Justin Lebar
On Wed, Jun 5, 2013 at 3:25 AM, Philipp Kewisch wrote: > I also agree to Randell and Joshua. I've been using both lately and there > are just a few things missing in git that I am used to in hg. > > Mercurial Queues is the most prominent. I am used to switching the order of > patches in my queue,

Re: review stop-energy (was 24hour review)

2013-07-10 Thread msreckovic
On Wednesday, 10 July 2013 13:06:04 UTC-4, Boris Zbarsky wrote: > On 7/10/13 12:56 PM, Milan wrote: > > > Why not? > > > > Because submitting a first patch is scary enough as it is that we should > > try to minimize the roadblocks involved in it. > > > > This is also why the reviewer in c

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Boris Zbarsky
On 7/10/13 8:31 AM, Mark Banner wrote: The problem is, that doesn't work on the patch submission forms. Or on bzexport. I can't recall the last time I used the Bugzilla UI for requesting review... but I think it would be good to have the option to provide a warning with a little bit of tex

Mail Explosion

2013-07-10 Thread Dustin Oprea
I've only been auditing the devs for a couple of months, but does anyone know what's going on with the mail? I just received like forty messages. Dustin Oprea ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinf

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Joshua Cranmer 🐧
On 7/9/2013 5:11 PM, therealbrendane...@gmail.com wrote: Good news is bugzilla is getting attention now, both back-end and front-end. More on that separately, because it's not the main point of Taras's post. The main point is that review is mandatory and must be prompt or the whole peer review

Re: review stop-energy (was 24hour review)

2013-07-10 Thread therealbrendaneich
Good news is bugzilla is getting attention now, both back-end and front-end. More on that separately, because it's not the main point of Taras's post. The main point is that review is mandatory and must be prompt or the whole peer review potlatch system breaks down. I've said this before, not s

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Chris Peterson
I really wish Bugzilla could let me flag myself as not available for reviews when I'm on vacation, say. Expecting people to comment about being on vacation while on vacation is, imo, not reasonable. I've seen people change their Bugzilla name to include a comment about being on PTO. We should

review stop-energy (was 24hour review)

2013-07-10 Thread Taras Glek
Hi, Browsers are a competitive field. We need to move faster. Eliminating review lag is an obvious step in the right direction. I believe good code review is essential for shipping a good browser. Conversely, poor code review practices hold us back. I am really frustrated with how many excell

Re: running tests in HiDPI mode on the build machines

2013-07-10 Thread Asa Dotzler
On 7/8/2013 8:18 PM, Cameron McCormack wrote: I think it's time we considered having tests running on the build machines in HiDPI mode so that we can catch regressions that only manifest themselves in high resolution configurations. We have at least three platforms we're targeting where this is

Re: Reparenting a XulRunnner window in a Firefox Window

2013-07-10 Thread Neil
Benjamin Smedberg wrote: On Linux and Windows you can mostly do this with windowed plugins and reparented widgets, although you running the risk of introducing new plugin hangs. We should work to make sure that on Windows especially the event loops of the relevant processes are desynchronized.

Re: Replacing Gecko's URL parser

2013-07-10 Thread Axel Hecht
On 7/3/13 8:49 AM, Anne van Kesteren wrote: On Tue, Jul 2, 2013 at 12:09 PM, Benjamin Smedberg wrote: Both resource: and chrome: have host names and need to support relative URIs. Neither of them is a candidate for standardization, though. We should just add them as special known schemes in our

Building with a pre-built libxul.so

2013-07-10 Thread Geoff Lankow
I recently discovered that I can build Firefox by downloading the XULRunner SDK and using it instead of compiling everything. Clobber to finished in under a minute. Great! (Ignoring the not-insignificant download time.) If I build this way I can hack the Firefox-specific UI. Not much else, inc

Re: Sandboxed, off-screen pages for thumbnail capture

2013-07-10 Thread Gervase Markham
On 26/06/13 08:45, Mark Hammond wrote: > There is evidence users find this troubling - eg, bug 762610 reports > that a couple of users wrote to the mozilla webmaster about this. While > it may just be a perception, it seems a perception worth managing. And > even if someone can't read the exact b

Re: Sandboxed, off-screen pages for thumbnail capture

2013-07-10 Thread Mark Hammond
On 25/06/2013 5:29 PM, Gervase Markham wrote: On 17/06/13 21:48, Drew Willcoxon wrote: Toolkit already has a thumbnail module, [PageThumbs], but it can only capture thumbnails of open content windows, same as they appear to the user. Windows may contain sensitive data that should not be recorded

Re: Code coverage take 2, and other code hygiene tools

2013-07-10 Thread Ms2ger
On 06/25/2013 03:50 AM, Clint Talbert wrote: So, the key things I want to know: * Will you support code coverage? Would it be useful to your work to have a regularly scheduled code coverage build & test run? I have looked at decoder's older code coverage data [1] before, and found it very usef

Re: Making proposal for API exposure official

2013-07-10 Thread Boris Zbarsky
On 6/24/13 5:49 PM, Ehsan Akhgari wrote: What about changes made in order to improve compliance with a spec not developed by Mozilla? This is a tough call. My experience is that most specs out there are buggy in their use of WebIDL and in their general API design, so such a change would need

Watching pages on MDN

2013-07-10 Thread Eric Shepherd
Dear devs and writers, We have just thrown the switch, and if you're logged into MDN, you should now have a new "Email me article changes" button next to the Edit button near the top of the page. Click this button, and you'll start receiving emails when that page is changed. The emails will te

Re: Watching pages on MDN

2013-07-10 Thread Boris Zbarsky
On 6/14/13 10:19 AM, Eric Shepherd wrote: We have just thrown the switch, and if you're logged into MDN, you should now have a new "Email me article changes" button next to the Edit button near the top of the page. Thank you for making this happen! -Boris __

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Boris Zbarsky
On 7/10/13 1:58 PM, Mark Côté wrote: The BMO team is again considering switching to ReviewBoard, which should fix this problem How does ReviewBoard address this? Again, what we have in the bug is diff 1 against changeset A and diff 2 against changeset B that incorporates the review changes.

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Boris Zbarsky
On 7/10/13 12:56 PM, msrecko...@mozilla.com wrote: Why not? Because submitting a first patch is scary enough as it is that we should try to minimize the roadblocks involved in it. This is also why the reviewer in cases like that should handle setting the checkin-needed keyword (or just land

Re: Disabling XUL -moz-inline-stack/-moz-stack on the Web?

2013-07-10 Thread Boris Zbarsky
On 6/13/13 11:56 PM, Robert O'Callahan wrote: Bug 875060 made me wonder whether we should disable XUL 'display' values on the Web, perhaps starting with -moz-stack and -moz-inline-stack. They do very little that can't be done with absolute positioning. Perhaps we would leave XUL 'display' values

Re: review stop-energy (was 24hour review)

2013-07-10 Thread smaug
On 07/09/2013 03:14 PM, Taras Glek wrote: Hi, Browsers are a competitive field. We need to move faster. Eliminating review lag is an obvious step in the right direction. I believe good code review is essential for shipping a good browser. Conversely, poor code review practices hold us back. I

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Anthony Ricaud
On 10/07/13 15:09, smaug wrote: One thing, which has often brought up, would be to have other automatic coding style checker than just Ms2ger. At least in the DOM land we try to follow the coding style rules rather strictly and it would ease reviewers work if there was some good tool which does t

running tests in HiDPI mode on the build machines

2013-07-10 Thread jmaher
Can you explain what would need to be done for Android to get into this mode? It might be difficult to make this work with our current solution for automated tests. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/

Re: Possibility of replacing SQLite with LMDB from the OpenLDAP project (or replacing the SQLite backend with LMDB)

2013-07-10 Thread Marco Bonardo
On 06/07/2013 11:26, Philip Chee wrote: "LMDB is an ultra-fast, ultra-compact key-value data store developed by Symas for the OpenLDAP Project. It uses memory-mapped files, so it has the read performance of a pure in-memory database while still offering the persistence of standard disk-based data

Re: [b2g] Proposal for power metering per application framework on FFOS

2013-07-10 Thread kumar
(Disclaimer: I am the co-founder of the company who developed the below tool) We have a tool called LittleEye (http://www.littleeye.co) which does most of what you propose, but built for Android. Its a desktop tool that automatically injects an agent onto a connected phone. It can be used to mon

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Boris Zbarsky
On 7/9/13 6:11 PM, therealbrendane...@gmail.com wrote: I've said this before, not sure it's written in wiki-stone, maybe it should be: if you get a review request, respond same-day either with the actual review, or an ETA or promise to review by a certain date. Again, this is not viable durin

How to find the differnt controls on a FireFox Browser. ?

2013-07-10 Thread Amit Vaid
So the original question is to be able to find different controls on a XUL application. But to make it simpler, i want to be able to find various controls present on the Firefox browser through my JavaScript. I am trying to use the interfaces being exposed by XULRunner. The thing i have tried th

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Boris Zbarsky
On 7/9/13 4:29 PM, Chris Peterson wrote: I've seen people change their Bugzilla name to include a comment about being on PTO. Sure. As a simple example, I did that on June 20th. I got about 20 review requests over the course of the following week and a half, and that's with most of the peop

this.docshell is null

2013-07-10 Thread dramaw
I receive this error when I click to open firefox. I have googled everything and cannot find a cure/fix for this problem. I don't understand it, I'm not that computer savvy. If you could help I would be most greatful. ___ dev-platform mailing list d

Xulrunner app with findbar

2013-07-10 Thread Tomasz G.
Hello, I'm developing application using xulrunner and I need to use find bar (like the one from Firefox). I found something like this: XUL: http://www.google.com/"; type="content-primary"/> JavaScript: var findbar1 = document.getElementById("FindToolbar1"); findbar1.open(0); The findbar show

Re: MOZ_NOT_REACHED and JS_NOT_REACHED are now MOZ_ASSUME_UNREACHABLE, and other changes.

2013-07-10 Thread Nicholas Cameron
On Saturday, June 29, 2013 2:04:58 PM UTC+12, Justin Lebar wrote: > tl;dr - Changes from bug 820686: > > > 4. Don't put code after MOZ_CRASH() or MOZ_ASSUME_UNREACHABLE(); it just > gives > a false sense of security. > This appears not to be true. On Try, Windows builds fail if a method e

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Blake Kaplan
Johnny Stenback wrote: > [TL;DR, I think we need to embrace git in addition to hg for > Firefox/Gecko hacking, what do you think?] > 1: Embrace both git and hg as a first class DVCS. > 2: Switch wholesale to git. For what it's worth, as someone who is happy to use whatever is thrown at me (I use

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Philipp Kewisch
I also agree to Randell and Joshua. I've been using both lately and there are just a few things missing in git that I am used to in hg. Mercurial Queues is the most prominent. I am used to switching the order of patches in my queue, which seems like a pain to me in git. Or maybe I haven't quit

Re: Replacing Gecko's URL parser

2013-07-10 Thread Ms2ger
On 07/01/2013 08:30 PM, Gavin Sharp wrote: .sOn Mon, Jul 1, 2013 at 10:58 AM, Benjamin Smedberg wrote: Idempotent: Currently Gecko's parser and the URL Standard's parser are not idempotent. E.g. http://@/mozilla.org/ becomes http:///mozilla.org/ which when parsed becomes http://mozilla.org/ whi

Possibility of replacing SQLite with LMDB from the OpenLDAP project (or replacing the SQLite backend with LMDB)

2013-07-10 Thread Philip Chee
1. OpenLDAP Lightning Memory-Mapped Database (LMDB): 2. Benchmarks: 3. SQLite3 ported to use MDB instead of its original Btree code: "LMDB is an ultra-fast, ultra-compact key-value data store develo

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Matt Brubeck
On 5/31/2013 12:32 PM, Boris Zbarsky wrote: On 5/31/13 3:20 PM, Matt Brubeck wrote: blame mobile/android/chrome/content/browser.xul: git 1.015s hg 0.830s Was this a git blame -C (which would be more similar to hg blame), or just a git blame? Good catch. (Sorry, I missed your messages

Re: Sandboxed, off-screen pages for thumbnail capture

2013-07-10 Thread Matt Brubeck
On 6/17/2013 9:48 PM, Drew Willcoxon wrote: The desktop Firefox team is building a new Toolkit module that captures thumbnails of off-screen web pages. Critically, we want to avoid capturing any data in these thumbnails that could identify the user. More generally, we're looking for a way to v

Re: Replacing Gecko's URL parser

2013-07-10 Thread Axel Hecht
On 7/1/13 8:30 PM, Gavin Sharp wrote: .sOn Mon, Jul 1, 2013 at 10:58 AM, Benjamin Smedberg wrote: Idempotent: Currently Gecko's parser and the URL Standard's parser are not idempotent. E.g. http://@/mozilla.org/ becomes http:///mozilla.org/ which when parsed becomes http://mozilla.org/ which is

IndexedDB Browser addon

2013-07-10 Thread bent
Hi folks, Anyone who is using IndexedDB may find their lives slightly improved with this new addon: https://addons.mozilla.org/en-US/firefox/addon/indexeddb-browser/ This will let you inspect all the IndexedDB databases in your current profile as well as import external databases. It's stil

Windows XP virtual memory peak appears to be causing talos timeout errors for dromaeo_css

2013-07-10 Thread jmaher
We have a top orange factor failure which is a talos timeout that only happens on windows XP and predominately on the dromaeo_css test. What happens is we appear to complete the test just fine, but the poller we have on the process used to manage firefox never indicates we have finished. After

Re: Block cookies from sites I haven't visited

2013-07-10 Thread Josh Matthews
However, yes, you do want ACCESS_LIMIT_THIRD_PARTY. Cheers, Josh On 06/27/2013 01:17 PM, Josh Matthews wrote: Note that this isn't actually enabled by default on beta or release builds. On 06/27/2013 12:55 PM, Jan Odvarko wrote: Firefox 22 introduced a new cookie feature that allows to block

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Boris Zbarsky
On 5/31/13 3:20 PM, Matt Brubeck wrote: blame mobile/android/chrome/content/browser.xul: git 1.015s hg 0.830s Was this a git blame -C (which would be more similar to hg blame), or just a git blame? -Boris ___ dev-platform mailing list dev-pl

Re: Reparenting a XulRunnner window in a Firefox Window

2013-07-10 Thread Gijs Kruitbosch
On 02/07/13 17:34 , Paul Rouget wrote: The Firefox OS Simulator is a XulRunner instance run from Firefox. Two processes, two windows, two different version of gecko. It would be very useful if we could display the simulator as part of Firefox. Inside a tab. With Linux, we could use XReparentWin

Re: Sandboxed, off-screen pages for thumbnail capture

2013-07-10 Thread Gervase Markham
On 17/06/13 21:48, Drew Willcoxon wrote: > Toolkit already has a thumbnail module, [PageThumbs], but it can only > capture thumbnails of open content windows, same as they appear to > the user. Windows may contain sensitive data that should not be > recorded in an image, however, like bank account

Re: Changes to file purging during builds

2013-07-10 Thread Neil
Gregory Szorc wrote: This may result in a multi-second "jank" at the beginning of the build. As opposed to the multi-minute "jank" of $(RM) -r _tests ? -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-platform@lists.mozilla.

Re: Replacing Gecko's URL parser

2013-07-10 Thread Neil
Mike Hommey wrote: Note that some "custom" schemes may be relying on empty host names. In Gecko, we have about:foo as well as resource:///foo. In both cases, foo is the path part. about:foo is actually an nsSimpleURI, not an nsStandardURL, so it just throws when you try to access its host.

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Mark Côté
On 2013-07-09 4:48 PM, Boris Zbarsky wrote:> On 7/9/13 4:29 PM, Chris Peterson wrote: >>> Bugzilla's interdiff is totally unsuitable for this >>> purpose, unfortunately, because it fails so often. >> >> Can we fix Bugzilla's interdiff? > > Not easily, because it does not have access to the original

Re: Replacing Gecko's URL parser

2013-07-10 Thread Gijs Kruitbosch
On 01/07/13 19:01 , Boris Zbarsky wrote: On 7/1/13 12:43 PM, Anne van Kesteren wrote: I outlined two issues below, but I'm sure there are more. Another big one I'm aware of is the issue of how to treat '\\' in URLs. -Boris We also have issues with hashes and URI-encoding ( https://bugzill

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Axel Hecht
Weirdly enough, I'm hoping we're using one or the other, and I think git is more promising. Yes, I need to rewrite a bunch of stuff l10n-wise, but still. I actually think that we should aim high. Don't bother about command lines, but what takes us to a system where people can just contribute t

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Mark Banner
On 09/07/2013 21:29, Chris Peterson wrote: >> I really >> wish Bugzilla could let me flag myself as not available for reviews when >> I'm on vacation, say. Expecting people to comment about being on >> vacation while on vacation is, imo, not reasonable. > > I've seen people change their Bugzilla

Re: Making proposal for API exposure official

2013-07-10 Thread Chris Peterson
On 6/21/13 1:45 PM, Andrew Overholt wrote: Back in November, Henri Sivonen started a thread here entitled "Proposal: Not shipping prefixed APIs on the release channel" [1]. The policy of not shipping moz-prefixed APIs in releases was accepted AFAICT. I've incorporated that policy into a broader

Bugzilla Keyword Standardization Proposal

2013-07-10 Thread mschifer
We in QA have been discussing ways to help improve our workflows and provide some standardization across the teams in how we use Bugzilla. As part of this process we have come up with a proposal to make a small change to the definition of qawanted keyword and the addition of a new keyword qaurg

Re: Sandboxed, off-screen pages for thumbnail capture

2013-07-10 Thread Mark Hammond
On 27/06/2013 5:15 PM, Gervase Markham wrote: On 26/06/13 08:45, Mark Hammond wrote: There is evidence users find this troubling - eg, bug 762610 reports that a couple of users wrote to the mozilla webmaster about this. While it may just be a perception, it seems a perception worth managing. A

Re: review stop-energy (was 24hour review)

2013-07-10 Thread msreckovic
On Tuesday, 9 July 2013 15:46:31 UTC-4, Boris Zbarsky wrote: > On 7/9/13 3:14 PM, Taras Glek wrote: > > > Conversely, poor code review practices hold us back. > > > > Agreed. At the same time, poor patch practices make reviews _much_ > > harder. We should generally expect good patch practi

Re: Code coverage take 2, and other code hygiene tools

2013-07-10 Thread Joshua Cranmer 🐧
On 6/25/2013 1:19 PM, Dave Townsend wrote: I wish we could get JS code coverage too though. I think JS code coverage is a worthy goal, but it shouldn't block getting automated code coverage. The problem is that getting this to work reliably basically requires changes in the JS engine in the f

Re: review stop-energy (was 24hour review)

2013-07-10 Thread therealbrendaneich
On Tuesday, July 9, 2013 6:49:20 PM UTC-7, Boris Zbarsky wrote: > On 7/9/13 6:11 PM, brendan wrote: > > > I've said this before, not sure it's written in wiki-stone, maybe it should > > be: if you get a review request, respond same-day either with the actual > > review, or an ETA or promise to r

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Boris Zbarsky
On 7/9/13 9:59 PM, therealbrendane...@gmail.com wrote: Yes, that's what I meant. How else could one respond within a day? Some of the "within a day" proposals have suggested that it include weekends, fwiw. Ok. Does this need to go on wiki.m.o or MDN somewhere (not that it would help those

Kyle Huey's Cycle Collector talk from Taipei meetup

2013-07-10 Thread Chris Pearce
At the recent Web Rendering team meetup in Taipei Kyle gave a talk about how Gecko's cycle collector works, including covering what macros you need to use to ensure the cycle collector knows about your objects. We borrowed a camera from one of the Taipei team and recorded the talk, here it is

Re: Fix or disable windows desktop b2g builds

2013-07-10 Thread Dave Townsend
On 6/5/2013 3:48 PM, Chris AtLee wrote: Windows desktop b2g builds have been pretty broken for several weeks now, since around May 24 [1]. At this week's engineering and b2g meetings we discussed shutting these off if nobody has a strong reason to keep them around. If you are currently dependin

Reviewer checklist

2013-07-10 Thread Kartikaya Gupta
Some of us over in #mobile brainstormed a list of things that reviewers (and patch-writers) should check for in patches. The idea is to have a handy list of these things that often get forgotten, overlooked, or otherwise slip through. I have put up our list on the MDN wiki at [1] - please feel

Re: Heads up: difference in reference counting between Mozilla and WebKit worlds

2013-07-10 Thread Neil
Anthony Jones wrote: On 19/06/13 16:02, Robert O'Callahan wrote: I believe that in Webkit you're not supposed to call "new" directly. Instead you call a static "create" method that returns the equivalent of already_AddRefed. Do they have a lint checker we can use for that? Surely

Re: Possibility of replacing SQLite with LMDB from the OpenLDAP project (or replacing the SQLite backend with LMDB)

2013-07-10 Thread highlandsun
On Saturday, July 6, 2013 2:26:27 AM UTC-7, Philip Chee wrote: > 1. OpenLDAP Lightning Memory-Mapped Database (LMDB): > > > > 2. Benchmarks: > > 3. SQLite3 ported to use MDB instead of its original Btree code: > >

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Boris Zbarsky
On 7/9/13 3:14 PM, Taras Glek wrote: Conversely, poor code review practices hold us back. Agreed. At the same time, poor patch practices make reviews _much_ harder. We should generally expect good patch practices from established contributors; obviously expecting them from new contributors

Re: Kyle Huey's Cycle Collector talk from Taipei meetup

2013-07-10 Thread Chris Pearce
On 6/14/2013 10:02 AM, Chris Pearce wrote: At the recent Web Rendering team meetup in Taipei Kyle gave a talk about how Gecko's cycle collector works, including covering what macros you need to use to ensure the cycle collector knows about your objects. We borrowed a camera from one of the Ta

Re: Replacing Gecko's URL parser

2013-07-10 Thread Cameron Kaiser
On 7/1/13 4:51 PM, Mike Hommey wrote: Idempotent: Currently Gecko's parser and the URL Standard's parser are not idempotent. E.g. http://@/mozilla.org/ becomes http:///mozilla.org/ which when parsed becomes http://mozilla.org/ which is somewhat bad for security. My plan is to change the URL Stand

Bugzilla Secure Mail Viewer for GMail now on AMO

2013-07-10 Thread bent
Hi folks, I've finally uploaded my secure mail viewer addon to AMO so that updates will work someday soon. Here's the link: https://addons.mozilla.org/en-US/firefox/addon/bugzilla-secure-mail-viewer/ -bent ___ dev-platform mailing list dev-platform@

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Randell Jesup
>On 5/30/2013 7:56 PM, Johnny Stenback wrote: >> [TL;DR, I think we need to embrace git in addition to hg for >> Firefox/Gecko hacking, what do you think?] > >Personally, the more I use git, the more I hate it. But I also see that >other people love it... jcramner++ :-) >>* Developers can use

A simple appcache question http(s)://*: or just *

2013-07-10 Thread mratcliffe
The spec says that that the only use of an asterisk is a single line containing only the * character in the NETWORK section. At one point Firefox implemented http://* and https://* instead ... does anybody know if this is still the case? ___ dev-platfor

Heads up: JavaScript API for downloads

2013-07-10 Thread Paolo Amadini
Hello, I wanted to mention that work on the new JavaScript API for downloads is proceeding steadily. If you're working on code related to downloads, this is probably going to be relevant to you over the next few months, even though initially the project is focused on Firefox for Desktop. More fre

Re: Replacing Gecko's URL parser

2013-07-10 Thread Boris Zbarsky
On 7/1/13 12:43 PM, Anne van Kesteren wrote: I outlined two issues below, but I'm sure there are more. Another big one I'm aware of is the issue of how to treat '\\' in URLs. -Boris ___ dev-platform mailing list dev-platform@lists.mozilla.org https:/

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Andrew Halberstadt
I used to also really dislike mercurial, but the more I used it the more I started to realize its power. Gps summarized it much better than I ever could have in a blog post last month: http://gregoryszorc.com/blog/2013/05/12/thoughts-on-mercurial-%28and-git%29/ I think mercurial and git are bo

Re: We should drop MathML

2013-07-10 Thread fred . wang
Regarding EPUB3, I don't think anyone said the whole format should be supported natively in browsers. An EPUB file is basically just a set of HTML5 pages (HTML, SVG, MathML and CSS) packed into an archive, together with additional metadata to describe the ebook content (title, author, chapters,

Re: Reparenting a XulRunnner window in a Firefox Window

2013-07-10 Thread Karl Tomlinson
Paul Rouget writes: > The Firefox OS Simulator is a XulRunner instance run > from Firefox. Two processes, two windows, two different > version of gecko. > > It would be very useful if we could display the simulator > as part of Firefox. Inside a tab. Under X11, the XEmbed protocol was designed fo

Re: Windows XP virtual memory peak appears to be causing talos timeout errors for dromaeo_css

2013-07-10 Thread Matt Brubeck
On 6/3/2013 7:28 AM, jmaher wrote: We have a top orange factor failure which is a talos timeout that only happens on windows XP and predominately on the dromaeo_css test. What happens is we appear to complete the test just fine, but the poller we have on the process used to manage firefox neve

Re: Problem with undefined references when building native extension

2013-07-10 Thread Neil
protocolma...@gmail.com wrote: $(XPCOM_LIBS) \ I *think* this needs to be XPCOM_GLUE_LDOPTS instead. -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev

Problem with undefined references when building native extension

2013-07-10 Thread protocolmagic
Hi, I'm looking for a little help building a native extension. I'm getting the following 'undefined reference' errors when linking on a Linux 64bit platform (not tried others yet): Executing: c++ -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wsign-c

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Axel Hecht
On 5/31/13 10:14 PM, Johnny Stenback wrote: On 5/31/2013 12:32 AM, Mike Hommey wrote: [...] Option 1 is where I personally think it's worth investing effort. It means we'd need to set up an atomic bidirectional bridge between hg and git (which I'm told is doable, and there are even commercial so

Re: Code coverage take 2, and other code hygiene tools

2013-07-10 Thread Neil
Joshua Cranmer 🐧 wrote: if you use --disable-debug --enable-optimize='-g' Custom optimisation flags are not supported and should never have been used to turn on symbols anyway; you should use --disable-debug --enable-debug-symbols --disable-optimize instead. -- Warning: May contain traces

Re: Block cookies from sites I haven't visited

2013-07-10 Thread Josh Matthews
Note that this isn't actually enabled by default on beta or release builds. On 06/27/2013 12:55 PM, Jan Odvarko wrote: Firefox 22 introduced a new cookie feature that allows to block cookies from not-visited sites. Blog post here: https://brendaneich.com/2013/06/the-cookie-clearinghouse/

Re: Code Review Session

2013-07-10 Thread Chris Peterson
On 5/24/13 8:46 AM, Benoit Girard wrote: I've got some patches that import webkit's check-style script to check the style[1]. Google and Linux also have style lint scripts (cpplint.py [1] and checkstyle.pl [2] respectively) that don't depend on a particular compiler tool like clang-format.

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Matt Brubeck
On 5/30/2013 5:56 PM, Johnny Stenback wrote: Some of the known issues with embracing git are: * Performance of git on windows is sub-optimal (we're already working on it). This has become a bit of an urban legend; I often see it repeated but seldom with actual measurements. I don't t

Re: Code coverage take 2, and other code hygiene tools

2013-07-10 Thread Dave Townsend
On 6/24/2013 6:50 PM, Clint Talbert wrote: Decoder and Jcranmer got code coverage working on Try[1]. They'd like to expand this into something that runs automatically, generating results over time so that we can actually know what our code coverage status is with our major run-on-checkin test har

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Joshua Cranmer 🐧
On 5/30/2013 7:56 PM, Johnny Stenback wrote: [TL;DR, I think we need to embrace git in addition to hg for Firefox/Gecko hacking, what do you think?] Personally, the more I use git, the more I hate it. But I also see that other people love it... * Developers can use git branches. They jus

Re: Heads up: difference in reference counting between Mozilla and WebKit worlds

2013-07-10 Thread Joshua Cranmer 🐧
On 6/19/2013 3:20 PM, Ehsan Akhgari wrote: On 2013-06-19 12:56 PM, Gregory Szorc wrote: On 6/18/13 9:05 PM, Anthony Jones wrote: On 19/06/13 16:02, Robert O'Callahan wrote: I believe that in Webkit you're not supposed to call "new" directly. Instead you call a static "create" method that retur

  1   2   >