Hi folks,
I added a comment to SQOOP-1272 as the title of the JIRA says sequential
datasets but the code makes references to partitioned datasets only.
Further to this, I had someone attempt to use it on a mainframe and
discover this. Can anyone else confirm this is the case?
If so, can I propos
Hey folks,
What's the go with SQOOP-816 ?
Is there some technical limitation that is making this impossible?
I'm thinking of taking this one on but unsure if it is possible or not
without further investigation.
Kind regards
Chris
Is it OK to include Hive as a test-time dependency for the unit testing
purposes? I'm not sure how this is done in Ant so would appreciate any
guidance on this.
Should this be another JIRA to incorporate test-time Hive dependency into
the Sqoop project?
Kind Regards
Chris
Hi,
I'm trying to complete an integration test for a patch but run into the
following error:-
com.google.protobuf.InvalidProtocolBufferException: Message missing
required fields: callId, status
The patch works as a regular sqoop command so how is it different with
integration tests? I suspect som
/
Testing
---
Unit tests.
Interactive IDE debug step throughs.
No testing on HiveServer as SQOOP-2787 may not yet be in trunk.
End to end testing on PostgresQL to HiveServer performed.
Thanks,
Chris Teoh
.
Thanks,
Chris Teoh
iew172477
---
On April 26, 2017, 12:52 p.m., Chris Teoh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
Lines 82 (patched)
> > <https://reviews.apache.org/r/51912/diff/5/?file=1692719#file1692719line82>
> >
> > Thanks for creating a new test class! Would you please also add test
> > cases that cover the "default path", where we're n
/51912/diff/7/
Changes: https://reviews.apache.org/r/51912/diff/6-7/
Testing
---
Unit tests.
Interactive IDE debug step throughs.
No testing on HiveServer as SQOOP-2787 may not yet be in trunk.
End to end testing on PostgresQL to HiveServer performed.
Thanks,
Chris Teoh
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51912/#review174891
---
On April 30, 2017, 7:48 a.m., Chris Teoh wrote:
>
> ---
/51912/diff/8/
Changes: https://reviews.apache.org/r/51912/diff/7-8/
Testing
---
Unit tests.
Interactive IDE debug step throughs.
No testing on HiveServer as SQOOP-2787 may not yet be in trunk.
End to end testing on PostgresQL to HiveServer performed.
Thanks,
Chris Teoh
end testing on PostgresQL to HiveServer performed.
Thanks,
Chris Teoh
ify some vendor specific FTP commands before
the transfer so it gets included in the dataset when downloading it.
Many thanks in advance
Chris
On Thu, 24 Aug 2017 at 10:38 pm, Chris Teoh (JIRA) wrote:
>
> [
> https://issues.apache.org/jir
src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java f61b9838
src/test/org/apache/sqoop/tool/TestMainframeImportTool.java d51e33e5
Diff: https://reviews.apache.org/r/62492/diff/1/
Testing
---
Unit tests.
Functional testing soon on a mainframe.
Thanks,
Chris Teoh
.
Thanks,
Chris Teoh
/org/apache/sqoop/tool/TestMainframeImportTool.java d51e33e5
src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java d87c75df
Diff: https://reviews.apache.org/r/62523/diff/2/
Changes: https://reviews.apache.org/r/62523/diff/1-2/
Testing
---
Unit tests.
Thanks,
Chris Teoh
src/test/org/apache/sqoop/tool/TestMainframeImportTool.java d51e33e5
Diff: https://reviews.apache.org/r/62492/diff/2/
Changes: https://reviews.apache.org/r/62492/diff/1-2/
Testing
---
Unit tests.
Functional testing soon on a mainframe.
Thanks,
Chris Teoh
://reviews.apache.org/r/62523/diff/2-3/
Testing
---
Unit tests.
File Attachments (updated)
SQOOP-3237-1.patch
https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
Thanks,
Chris Teoh
/
Changes: https://reviews.apache.org/r/62523/diff/3-4/
Testing
---
Unit tests.
File Attachments
SQOOP-3237-1.patch
https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
Thanks,
Chris Teoh
/62523/diff/4/
Testing
---
Unit tests.
File Attachments
SQOOP-3237-1.patch
https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
Thanks,
Chris Teoh
/62492/diff/2/
Testing
---
Unit tests.
Functional testing soon on a mainframe.
Thanks,
Chris Teoh
/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
Thanks,
Chris Teoh
://reviews.apache.org/r/62492/diff/2-3/
Testing
---
Unit tests.
Functional testing soon on a mainframe.
Thanks,
Chris Teoh
tests.
File Attachments
SQOOP-3237-1.patch
https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
Thanks,
Chris Teoh
.
File Attachments
SQOOP-3237-1.patch
https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
Thanks,
Chris Teoh
testing soon on a mainframe.
Thanks,
Chris Teoh
sting
---
Unit testing.
Functional testing on a real mainframe soon.
Thanks,
Chris Teoh
dated)
---
Unit testing.
Some Functional testing on a real mainframe. Binary transfer functionality
somewhat confirmed though some hex values differed. Continued testing.
Thanks,
Chris Teoh
e.org/r/62653/diff/2-3/
Testing (updated)
---
Unit testing.
Functional testing on a real mainframe with a previous combined patch.
Thanks,
Chris Teoh
e the default FTP list parsing.
Thanks. I have put in a mock in the unit test that will throw the exception if
initiateListParsing is called.
- Chris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62653/#review186571
---
62653/diff/3-4/
Testing
---
Unit testing.
Functional testing on a real mainframe with a previous combined patch.
Thanks,
Chris Teoh
org/r/62653/diff/4-5/
Testing
---
Unit testing.
Functional testing on a real mainframe with a previous combined patch.
Thanks,
Chris Teoh
UnitTestRunner.java:1033)
> >
> > Please review your changes there. Also, please avoid any reformatting of
> > any file as it makes difficult to review your change.
> >
> > Thanks,
> > Bogi
Thanks for picking this up. I have updated the code so the unit test passes
erated e-mail. To reply, visit:
https://reviews.apache.org/r/62653/#review186652
-------
On Oct. 2, 2017, 11:12 p.m., Chris Teoh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org
https://reviews.apache.org/r/62653/#review188652
-------
On Oct. 2, 2017, 11:12 p.m., Chris Teoh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62653/
> -
f/5-6/
Testing
---
Unit testing.
Functional testing on a real mainframe with a previous combined patch.
Thanks,
Chris Teoh
/TestMainframeFTPClientUtils.java 90a85194
Diff: https://reviews.apache.org/r/62492/diff/4/
Changes: https://reviews.apache.org/r/62492/diff/3-4/
Testing (updated)
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
rg.junit.rules.ExpectedException here.
Done.
> On Nov. 10, 2017, 4:05 p.m., Szabolcs Vasas wrote:
> > src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java
> > Lines 387 (patched)
> > <https://reviews.apache.org/r/62492/diff/4/?file=1868
,
Chris Teoh
.
Thanks,
Chris Teoh
://reviews.apache.org/r/62492/diff/6-7/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/#review191732
-------
On Nov. 29, 2017, 11:48 a.m., Chris Teoh wrote:
>
> ---
ion() in the parent class I
cannot mock. Do you have any suggestions?
- Chris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/#review192493
---
/62492/diff/7-8/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
/TestMainframeFTPClientUtils.java 90a85194
Diff: https://reviews.apache.org/r/62492/diff/9/
Changes: https://reviews.apache.org/r/62492/diff/8-9/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
90a85194
Diff: https://reviews.apache.org/r/62492/diff/10/
Changes: https://reviews.apache.org/r/62492/diff/9-10/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
/TestMainframeFTPClientUtils.java 90a85194
Diff: https://reviews.apache.org/r/62492/diff/11/
Changes: https://reviews.apache.org/r/62492/diff/10-11/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
/TestMainframeImportTool.java 0b0c6c34
src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194
Diff: https://reviews.apache.org/r/62492/diff/12/
Changes: https://reviews.apache.org/r/62492/diff/11-12/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
/TestMainframeFTPClientUtils.java 90a85194
Diff: https://reviews.apache.org/r/62492/diff/13/
Changes: https://reviews.apache.org/r/62492/diff/12-13/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
iar with FTP... Does it always default to
> > ASCII? In that case, I admit that it would make sense to use this as the
> > default.
The default appears to be ASCII.
- Chris
---
This is an automatically generated e-mail.
src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194
Diff: https://reviews.apache.org/r/62492/diff/14/
Changes: https://reviews.apache.org/r/62492/diff/13-14/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
these lines?
That was from the time when there were legacy namespaces in the project.
- Chris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/#review203969
---
.
Functional testing on mainframe.
Thanks,
Chris Teoh
.
Thanks,
Chris Teoh
/mainframe/TestMainframeFTPFileEntryParser.java
eb0f8c00
Diff: https://reviews.apache.org/r/67407/diff/1/
Testing
---
Unit testing.
Thanks,
Chris Teoh
src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194
Diff: https://reviews.apache.org/r/67408/diff/1/
Testing
---
Unit tests. Integration testing locally on developer machine.
Thanks,
Chris Teoh
Hey folks,
I'm thinking of building integration tests for Sqoop using the following
project:-
https://github.com/realitix/zos-ftpmock
The version I have is modified to what I need to test against.
The question is, can I do this or are there some licensing issues with
using GitHub projects?
Kind
e this is a Python project? How do you plan to add it to the
> Sqoop tests?
>
> Regards,
> Szabolcs
>
> On Fri, Jun 1, 2018 at 9:28 AM, Chris Teoh wrote:
>
> > Hey folks,
> >
> > I'm thinking of building integration tests for Sqoop using the following
to the docker compose file.
> I think it is a good idea to have a better test coverage for the mainframe
> connector.
>
> On Fri, Jun 1, 2018 at 12:51 PM, Chris Teoh wrote:
>
> > I have contacted the developer to see if he can license it to Apache.
> Maybe
> > I need t
. To reply, visit:
https://reviews.apache.org/r/67407/#review204185
---
On May 31, 2018, 11:25 p.m., Chris Teoh wrote:
>
> ---
> This is an automatic
/mapreduce/mainframe/TestMainframeFTPFileEntryParser.java
eb0f8c00
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeImportJob.java
be62efd0
Diff: https://reviews.apache.org/r/67407/diff/2/
Changes: https://reviews.apache.org/r/67407/diff/1-2/
Testing
---
Unit testing.
Than
/mainframe/MainframeFTPFileEntryParser.java
f0b87868
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeFTPFileEntryParser.java
eb0f8c00
Diff: https://reviews.apache.org/r/67407/diff/3/
Changes: https://reviews.apache.org/r/67407/diff/2-3/
Testing
---
Unit testing.
Thanks,
Chris Teoh
Since this is a constant, you could make it final and uppercase (this
> > probably applies to all the other constants in this file)
> >
> > private static final String MIGRATED_STRING = "Migrated";
>
> Chris Teoh wrote:
> Thanks for your review.
/1/
Testing
---
Running the test.
Thanks,
Chris Teoh
/MainframeManagerImportTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/67429/diff/2/
Changes: https://reviews.apache.org/r/67429/diff/1-2/
Testing
---
Running the test.
Thanks,
Chris Teoh
Thanks. Have done it and submitted patch for review.
On Mon, 4 Jun 2018 at 6:25 pm, Szabolcs Vasas wrote:
> Yes, please raise a separate JIRA for that.
>
> Szabolcs
>
> On Sat, Jun 2, 2018 at 12:39 AM, Chris Teoh wrote:
>
> > Thanks. Should this be a separate patch and
.
Thanks,
Chris Teoh
)
---
Running the integration and unit test on a patched version of trunk.
Thanks,
Chris Teoh
tps://reviews.apache.org/r/67429/diff/3/?file=2035228#file2035228line216>
> >
> > You can remove this method since it is empty.
Done.
- Chris
---
This is an automatically generated e-mail. To reply, visit:
https:/
integration and unit test on a patched version of trunk.
Thanks,
Chris Teoh
/
Changes: https://reviews.apache.org/r/67429/diff/5-6/
Testing
---
Running the integration and unit test on a patched version of trunk.
Thanks,
Chris Teoh
/
Changes: https://reviews.apache.org/r/62492/diff/16-17/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
/TestMainframeFTPClientUtils.java 90a85194
Diff: https://reviews.apache.org/r/62492/diff/18/
Changes: https://reviews.apache.org/r/62492/diff/17-18/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
/diff/19/
Changes: https://reviews.apache.org/r/62492/diff/18-19/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
/diff/19-20/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/#review207485
-------
On Aug. 13, 2018, 8:52 p.m., Chris Teoh wrote:
>
> ---
/21/
Changes: https://reviews.apache.org/r/62492/diff/20-21/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34
Diff: https://reviews.apache.org/r/62492/diff/22/
Changes: https://reviews.apache.org/r/62492/diff/21-22/
Testing
---
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
://reviews.apache.org/r/62523/diff/5-6/
Testing
---
Unit tests.
File Attachments
SQOOP-3237-1.patch
https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
Thanks,
Chris Teoh
---
Unit tests. Integration testing locally on developer machine.
Thanks,
Chris Teoh
/mainframe/MainframeFTPFileEntryParser.java
f0b87868
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeFTPFileEntryParser.java
eb0f8c00
Diff: https://reviews.apache.org/r/67407/diff/5/
Changes: https://reviews.apache.org/r/67407/diff/4-5/
Testing
---
Unit testing.
Thanks,
Chris Teoh
/diff/3-4/
Testing
---
Unit tests. Integration testing locally on developer machine.
Thanks,
Chris Teoh
.
Thanks,
Chris Teoh
/62523/diff/7/
Changes: https://reviews.apache.org/r/62523/diff/6-7/
Testing
---
Unit tests.
File Attachments
SQOOP-3237-1.patch
https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
Thanks,
Chris Teoh
s an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62523/#review209738
---
On Oct. 31, 2018, 4:40 p.m., Chris Teoh wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62523/#review209738
-------
On Oct. 31, 2018, 4:40 p.m., Chris Teoh wrote:
>
> -
/
Changes: https://reviews.apache.org/r/62523/diff/8-9/
Testing
---
Unit tests.
File Attachments
SQOOP-3237-1.patch
https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
Thanks,
Chris Teoh
ethod having a
> > self-explanatory name.
Yes I have refactored it out to a method and revised the unit tests.
- Chris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62523/#review210413
--
://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
Thanks,
Chris Teoh
/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
Thanks,
Chris Teoh
getFTPConnection already invokes
> > applyFtpCommands, so you don't have to invoke it again.
Thanks again. It is included in the suggested unit test fix from the previous
issue.
- Chris
---
This is a
://reviews.apache.org/r/62523/diff/11-12/
Testing
---
Unit tests.
File Attachments
SQOOP-3237-1.patch
https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
Thanks,
Chris Teoh
Possible solution here is to modify the query to accommodate the invalid
date with a case statement. Follow up question is, what is the next valid
date for this scenario?
On Fri., 8 Mar. 2019, 3:31 pm Paul Porter (JIRA), wrote:
> Paul Porter created SQOOP-3432:
>
[
https://issues.apache.org/jira/browse/SQOOP-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15288144#comment-15288144
]
Chris Teoh commented on SQOOP-1272:
---
Hi there,
Good job on the patch. It seems to
[
https://issues.apache.org/jira/browse/SQOOP-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Teoh updated SQOOP-2938:
--
Attachment: SQOOP-2938-review.patch
> Mainframe import module extension to support data sets on t
[
https://issues.apache.org/jira/browse/SQOOP-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318061#comment-15318061
]
Chris Teoh commented on SQOOP-2937:
---
SQOOP-2938 includes this patch. Markin
[
https://issues.apache.org/jira/browse/SQOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318064#comment-15318064
]
Chris Teoh commented on SQOOP-2939:
---
SQOOP-2938 committed which covers this ti
[
https://issues.apache.org/jira/browse/SQOOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Teoh resolved SQOOP-2939.
---
Resolution: Fixed
SQOOP-2938 incorporates all the proposed features in this parent task.
> Ext
[
https://issues.apache.org/jira/browse/SQOOP-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493249#comment-15493249
]
Chris Teoh commented on SQOOP-816:
--
Patch added. Please review
https://reviews.apache
[
https://issues.apache.org/jira/browse/SQOOP-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Teoh reassigned SQOOP-816:
Assignee: Chris Teoh
> Scoop and support for external Hive tab
1 - 100 of 123 matches
Mail list logo
