> On May 29, 2018, 12:45 p.m., Boglarka Egyed wrote: > > Hi Chris, > > > > I did a quick review and found a couple of things, please find them below. > > > > Also I have pushed a change to trunk thus your patch doesn't apply there > > anymore. Could you please rebase? > > > > Thanks, > > Bogi
Thanks for your review Bogi. I have rebased. > On May 29, 2018, 12:45 p.m., Boglarka Egyed wrote: > > src/java/org/apache/sqoop/SqoopOptions.java > > Lines 2507 (patched) > > <https://reviews.apache.org/r/62492/diff/11/?file=2031382#file2031382line2507> > > > > Could you please extract "" to a well named constant here? Switched to StringUtils.isEmpty() > On May 29, 2018, 12:45 p.m., Boglarka Egyed wrote: > > src/test/org/apache/sqoop/tool/TestMainframeImportTool.java > > Lines 251-258 (patched) > > <https://reviews.apache.org/r/62492/diff/11/?file=2031399#file2031399line251> > > > > Untofrtunately I don't understand the intention here. What should this > > method do? It was missed from the rebase. > On May 29, 2018, 12:45 p.m., Boglarka Egyed wrote: > > src/test/org/apache/sqoop/tool/TestMainframeImportTool.java > > Lines 251-253 (patched) > > <https://reviews.apache.org/r/62492/diff/11/?file=2031399#file2031399line251> > > > > Why do you need these casting in these lines? That was from the time when there were legacy namespaces in the project. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62492/#review203969 ----------------------------------------------------------- On May 30, 2018, 12:11 p.m., Chris Teoh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62492/ > ----------------------------------------------------------- > > (Updated May 30, 2018, 12:11 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3224 > https://issues.apache.org/jira/browse/SQOOP-3224 > > > Repository: sqoop-trunk > > > Description > ------- > > Added --as-binaryfile and --buffersize to support FTP transfer mode switching. > > > Diffs > ----- > > src/java/org/apache/sqoop/SqoopOptions.java d9984af3 > src/java/org/apache/sqoop/manager/MainframeManager.java 4e8be155 > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 3b542102 > src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21 > > src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java > ea54b07f > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java > 1f78384b > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java > 0b7b5b85 > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java > 8ef30d38 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java c62ee98c > src/java/org/apache/sqoop/tool/ImportTool.java 2c474b7e > src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d > src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb > > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java > PRE-CREATION > > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java > 3547294f > src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34 > src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194 > > > Diff: https://reviews.apache.org/r/62492/diff/14/ > > > Testing > ------- > > Unit tests. > > Functional testing on mainframe. > > > Thanks, > > Chris Teoh > >
