Thanks. Have done it and submitted patch for review. On Mon, 4 Jun 2018 at 6:25 pm, Szabolcs Vasas <va...@cloudera.com> wrote:
> Yes, please raise a separate JIRA for that. > > Szabolcs > > On Sat, Jun 2, 2018 at 12:39 AM, Chris Teoh <chris.t...@gmail.com> wrote: > > > Thanks. Should this be a separate patch and jira? I heard back from the > > developer and he was ok with me using his code. > > > > > > On Sat, 2 Jun 2018 at 12:56 am, Szabolcs Vasas <va...@cloudera.com> > wrote: > > > > > Yes, you could create the a docker image with the emulator installed, > > > upload it to dockerhub and add it to the docker compose file. > > > I think it is a good idea to have a better test coverage for the > > mainframe > > > connector. > > > > > > On Fri, Jun 1, 2018 at 12:51 PM, Chris Teoh <chris.t...@gmail.com> > > wrote: > > > > > > > I have contacted the developer to see if he can license it to Apache. > > > Maybe > > > > I need to ask him if we can use it in Apache project instead. > > > > > > > > I am thinking of putting it in a docker container but I don’t > remember > > > how > > > > the integration tests work at the moment. I just see some scripts > and a > > > > docker compose yaml. > > > > On Fri, 1 Jun 2018 at 8:03 pm, Szabolcs Vasas <va...@cloudera.com> > > > wrote: > > > > > > > > > Hi Chris, > > > > > > > > > > I haven't found any license information about this project so you > > might > > > > be > > > > > a good idea to contact the developer of it and ask him if we can > use > > it > > > > > from an Apache project. > > > > > > > > > > As far as I see this is a Python project? How do you plan to add it > > to > > > > the > > > > > Sqoop tests? > > > > > > > > > > Regards, > > > > > Szabolcs > > > > > > > > > > On Fri, Jun 1, 2018 at 9:28 AM, Chris Teoh <chris.t...@gmail.com> > > > wrote: > > > > > > > > > > > Hey folks, > > > > > > > > > > > > I'm thinking of building integration tests for Sqoop using the > > > > following > > > > > > project:- > > > > > > https://github.com/realitix/zos-ftpmock > > > > > > > > > > > > The version I have is modified to what I need to test against. > > > > > > > > > > > > The question is, can I do this or are there some licensing issues > > > with > > > > > > using GitHub projects? > > > > > > > > > > > > Kind regards > > > > > > Chris > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Szabolcs Vasas > > > > > Software Engineer > > > > > <http://www.cloudera.com> > > > > > > > > > > > > > > > > > > > > > -- > > > Szabolcs Vasas > > > Software Engineer > > > <http://www.cloudera.com> > > > > > > > > > -- > Szabolcs Vasas > Software Engineer > <http://www.cloudera.com> >
