----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/ -----------------------------------------------------------
(Updated Sept. 28, 2017, 7:34 a.m.) Review request for Sqoop. Changes ------- Added settings transfer via the ImportJob class, adjusted binary FTP transfer setting. Bugs: SQOOP-3225 https://issues.apache.org/jira/browse/SQOOP-3225 Repository: sqoop-trunk Description ------- There were some cases where the FTP listing parser was not used for mainframe datasets, only the default was used. This caused some datasets to not be seen by Sqoop as the default parser couldn't find them. This patch addresses this behaviour where it is used to parse FTP listings for sequential and gdg datasets on disk and tape, only partitioned datasets are excluded as their FTP listing looks very different and is handled by the default FTP listing parser. Note: This patch supercedes SQOOP-3224, SQOOP-3237. I could not get both to apply cleanly together as they modified similar areas in the code base. Diffs (updated) ----- src/java/org/apache/sqoop/SqoopOptions.java 587d4e1d src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ea54b07f src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java f222dc8f src/java/org/apache/sqoop/tool/MainframeImportTool.java 0cb91dbc src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java f61b9838 src/test/org/apache/sqoop/tool/TestMainframeImportTool.java d51e33e5 src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java d87c75df Diff: https://reviews.apache.org/r/62653/diff/2/ Changes: https://reviews.apache.org/r/62653/diff/1-2/ Testing (updated) ------- Unit testing. Some Functional testing on a real mainframe. Binary transfer functionality somewhat confirmed though some hex values differed. Continued testing. Thanks, Chris Teoh