----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/ -----------------------------------------------------------
(Updated Oct. 2, 2017, 11:12 p.m.) Review request for Sqoop. Changes ------- Updated based on feedback. Unit test fixes. Bugs: SQOOP-3225 https://issues.apache.org/jira/browse/SQOOP-3225 Repository: sqoop-trunk Description ------- There were some cases where the FTP listing parser was not used for mainframe datasets, only the default was used. This caused some datasets to not be seen by Sqoop as the default parser couldn't find them. This patch addresses this behaviour where it is used to parse FTP listings for sequential and gdg datasets on disk and tape, only partitioned datasets are excluded as their FTP listing looks very different and is handled by the default FTP listing parser. Diffs (updated) ----- src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java f61b9838 src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java d87c75df Diff: https://reviews.apache.org/r/62653/diff/5/ Changes: https://reviews.apache.org/r/62653/diff/4-5/ Testing ------- Unit testing. Functional testing on a real mainframe with a previous combined patch. Thanks, Chris Teoh