> On April 20, 2017, 1:04 p.m., Liz Szilagyi wrote: > > Ship It!
Thanks for the review Liz! :) - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51912/#review172477 ----------------------------------------------------------- On April 26, 2017, 12:52 p.m., Chris Teoh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51912/ > ----------------------------------------------------------- > > (Updated April 26, 2017, 12:52 p.m.) > > > Review request for Sqoop, Kathleen Ting, Attila Szabo, and Liz Szilagyi. > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-816 - Hive External table support. Added --as-external-table option and > --table-location option > > > Diffs > ----- > > src/java/org/apache/sqoop/SqoopOptions.java 801942e > src/java/org/apache/sqoop/hive/TableDefWriter.java 32fcca3 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 46f405f > src/test/org/apache/sqoop/hive/TestTableDefWriter.java PRE-CREATION > src/test/org/apache/sqoop/tool/TestImportTool.java 7e11f54 > > > Diff: https://reviews.apache.org/r/51912/diff/6/ > > > Testing > ------- > > Unit tests. > Interactive IDE debug step throughs. > No testing on HiveServer as SQOOP-2787 may not yet be in trunk. > End to end testing on PostgresQL to HiveServer performed. > > > Thanks, > > Chris Teoh > >