> On Nov. 8, 2018, 9:34 p.m., Boglarka Egyed wrote: > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java > > Lines 86 (patched) > > <https://reviews.apache.org/r/62523/diff/8/?file=2103407#file2103407line86> > > > > Shouldn't this condition be negated? StringUtils.isBalnk will be true > > if the character sequence is null, empty or whitespace. I'm wondering how > > TestMainframeImportTool could pass with your patch.
Apologies you are right. I have updated this. > On Nov. 8, 2018, 9:34 p.m., Boglarka Egyed wrote: > > src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java > > Lines 383-393 (patched) > > <https://reviews.apache.org/r/62523/diff/8/?file=2103411#file2103411line383> > > > > These configurations could be extracted to a separate method having a > > self-explanatory name. Yes I have refactored it out to a method and revised the unit tests. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62523/#review210413 ----------------------------------------------------------- On Nov. 14, 2018, 10:24 a.m., Chris Teoh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62523/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2018, 10:24 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3237 > https://issues.apache.org/jira/browse/SQOOP-3237 > > > Repository: sqoop-trunk > > > Description > ------- > > Added --ftpcmds command to allow comma separated list of FTP commands to send. > > > Diffs > ----- > > src/docs/user/import-mainframe.txt 3ecfb7e4 > src/java/org/apache/sqoop/SqoopOptions.java f06872f9 > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java > 9842daa6 > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java > 90dc2ddd > src/java/org/apache/sqoop/tool/MainframeImportTool.java fbc8c3db > src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java e7c48a6b > src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 00e57bd0 > src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 0714bdcf > > > Diff: https://reviews.apache.org/r/62523/diff/9/ > > > Testing > ------- > > Unit tests. > > > File Attachments > ---------------- > > SQOOP-3237-1.patch > > https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch > > > Thanks, > > Chris Teoh > >
