Acked-by: Justin Pettit
--Justin
On August 25, 2014 at 10:42:24 PM, Alex Wang (al...@nicira.com) wrote:
> Signed-off-by: Alex Wang
> ---
> vswitchd/vswitch.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
> index 6c49250..
On 08/25/14 at 08:10pm, Jesse Gross wrote:
> On Mon, Aug 25, 2014 at 7:19 PM, Jarno Rajahalme
> wrote:
> > instead of:
> >
> > set(ipv4(src=35.8.2.41/0.0.0.0,dst=172.16.0.20/0.0.0.0,proto=6/0xff,tos=0x80/0,ttl=128/0,frag=no/0))
> >
> > we could have:
> >
> > set(ipv4(proto=6))
>
> Yes, that's wh
Fri, Aug 22, 2014 at 09:08:39PM CEST, john.fastab...@gmail.com wrote:
>On 08/21/2014 09:18 AM, Jiri Pirko wrote:
>>The netdevice represents a port in a switch, it will expose
>>IFLA_PHYS_SWITCH_ID value via rtnl. Two netdevices with the same value
>>belong to one physical switch.
>>
>>Signed-off-by
Sun, Aug 24, 2014 at 01:46:05PM CEST, tg...@suug.ch wrote:
>On 08/21/14 at 06:18pm, Jiri Pirko wrote:
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index 39294b9..8b5d14c 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -49,6 +49,8 @@
>>
The branch is unused as size < sizeof dst->inline_values must
always be true for inlined values. Hitting the branch would lead
to corruption as inline_values is accessed out of bounds.
Remove branch and add assertion.
Cc: Jarno Rajahalme
Signed-off-by: Thomas Graf
---
v2: fixed assertion
lib/
nodes is allocated through shash_sort() but never freed.
Signed-off-by: Thomas Graf
---
lib/json.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/json.c b/lib/json.c
index 167c40c..9c819d7 100644
--- a/lib/json.c
+++ b/lib/json.c
@@ -461,6 +461,7 @@ json_hash_object(const struct shash *
Causes the build script to fail if any command inside the
script returns nonzero.
Signed-off-by: Thomas Graf
---
.travis/build.sh | 43 ---
1 file changed, 20 insertions(+), 23 deletions(-)
diff --git a/.travis/build.sh b/.travis/build.sh
index e9bb9e2..a
On 21/08/2014 19:18, Jiri Pirko wrote:
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -868,7 +868,7 @@ static noinline size_t if_nlmsg_size(const struct
net_device *dev,
+ rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS +
IFLA_PORT_SELF */
+ rtnl_li
On 08/25/14 at 06:13pm, Thomas Graf wrote:
> I'll work out the travis.yml details, looks like extending it
> with something like below should do:
>
> notifications:
> email:
> recipients:
> - $BUILD_CI_LIST
>
> Can you setup a mailing list for the reports on openvswitch.org
> and set
On 8/25/14, 3:50 PM, Thomas Graf wrote:
On 08/25/14 at 12:15pm, Jamal Hadi Salim wrote:
On 08/25/14 10:17, Thomas Graf wrote:
On 08/25/14 at 09:53am, Jamal Hadi Salim wrote:
fdb_add() *is* flow based. At least in my understanding, the whole
point here is to extend the idea of fdb_add() and make
On 08/25/14 18:11, Thomas Graf wrote:
First of all, thanks for the animated discussion, wouldn't
want to miss our arguments ;-)
Passion is key my friend;-> It is said that ancient Greeks
would ask of a person whose funeral they are thinking to attend
"was s/he passionate in life?" And if the a
Tue, Aug 26, 2014 at 03:50:21PM CEST, ro...@cumulusnetworks.com wrote:
>On 8/25/14, 3:50 PM, Thomas Graf wrote:
>>On 08/25/14 at 12:15pm, Jamal Hadi Salim wrote:
>>>On 08/25/14 10:17, Thomas Graf wrote:
On 08/25/14 at 09:53am, Jamal Hadi Salim wrote:
fdb_add() *is* flow based. At least in m
Tue, Aug 26, 2014 at 02:23:24PM CEST, ogerl...@mellanox.com wrote:
>On 21/08/2014 19:18, Jiri Pirko wrote:
>>--- a/net/core/rtnetlink.c
>>+++ b/net/core/rtnetlink.c
>>@@ -868,7 +868,7 @@ static noinline size_t if_nlmsg_size(const struct
>>net_device *dev,
>> + rtnl_port_size(dev, ext_f
On 08/26/14 at 10:00am, Jamal Hadi Salim wrote:
> >I would argue that swflow is a superset of a Netlink route. It
> >may infact be very useful to extend the API with something that
> >understands the Netlink representation of a route and have the
> >API translate that to a classifier that can be of
On 08/25/14 18:50, Thomas Graf wrote:
On 08/25/14 at 12:15pm, Jamal Hadi Salim wrote:
On 08/25/14 10:17, Thomas Graf wrote:
I dont think we have a problem handling any of this today.
Yes we do. It's restricted to L2 and we can't extend it easily
It is restricted to L2 because it is L2 pro
On 08/26/14 10:06, Jiri Pirko wrote:
Yes. Flows are phase one. The api will be extended in for whatever is
needed for l2/l3 as you said. Also I see a possibility to implement the
l2/l3 use case with flows as well.
And as a note: This is where i have the disagreement.
It is good there is acknow
On Aug 26, 2014, at 6:50 AM, Roopa Prabhu wrote:
> On 8/25/14, 3:50 PM, Thomas Graf wrote:
>> On 08/25/14 at 12:15pm, Jamal Hadi Salim wrote:
>>> On 08/25/14 10:17, Thomas Graf wrote:
On 08/25/14 at 09:53am, Jamal Hadi Salim wrote:
fdb_add() *is* flow based. At least in my understandin
openvswitch/* no longer matches all the files since commit 826bc7b61345a5d
(build: Add travis continuous integration support) added files with names
beginning with ".".
VMware-BZ: #1298353
Signed-off-by: Ben Pfaff
---
debian/rules | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 08/26/14 11:01, Scott Feldman wrote:
I don’t see it that way. I believe sw_flow can be the intermediary
representation to span flow-based and non-flow-based HW,
and from flow-based world and traditional l2/l3 world.
Is there more magic to this than what Thomas just presented in this
Acked-by: Justin Pettit
--Justin
On August 26, 2014 at 8:07:55 AM, Ben Pfaff (b...@nicira.com) wrote:
> openvswitch/* no longer matches all the files since commit 826bc7b61345a5d
> (build: Add travis continuous integration support) added files with names
> beginning with ".".
>
> VMware-BZ: #1
Applied, thanks!
On Tue, Aug 26, 2014 at 08:15:07AM -0700, Justin Pettit wrote:
> Acked-by: Justin Pettit
>
> --Justin
>
>
> On August 26, 2014 at 8:07:55 AM, Ben Pfaff (b...@nicira.com) wrote:
> > openvswitch/* no longer matches all the files since commit 826bc7b61345a5d
> > (build: Add travi
Tue, Aug 26, 2014 at 04:58:54PM CEST, j...@mojatatu.com wrote:
>On 08/26/14 10:06, Jiri Pirko wrote:
>
>>Yes. Flows are phase one. The api will be extended in for whatever is
>>needed for l2/l3 as you said. Also I see a possibility to implement the
>>l2/l3 use case with flows as well.
>
>And as a n
On 08/26/14 11:22, Jiri Pirko wrote:
I do not think that really matters. Phase one is flows. After that we
can focus on l2/l3. If we would be able to fit in in flows (some drivers
may), then ok. If not, we extend the api with couple of more l2/l3
related ndos. I see no problem there.
Well, it
Thanks, applied.
On Mon, Aug 25, 2014 at 10:38:12AM -0700, Andy Zhou wrote:
> LGTM, Also tested the change.
> Acked-by: Andy Zhou
>
> On Thu, Aug 14, 2014 at 11:14 AM, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
> > ---
> > debian/.gitignore | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
On Tue, Aug 26, 2014 at 02:49:55AM +0200, Thomas Graf wrote:
> tun_key_to_attr() accesses tp_src and tp_dst which are currently
> uinitialized.
>
> Signed-off-by: Thomas Graf
Hmm, maybe we need to parse and format these fields too, but
initializing them predictably is a good start.
Applied, tha
Tue, Aug 26, 2014 at 05:29:10PM CEST, j...@mojatatu.com wrote:
>On 08/26/14 11:22, Jiri Pirko wrote:
>
>>I do not think that really matters. Phase one is flows. After that we
>>can focus on l2/l3. If we would be able to fit in in flows (some drivers
>>may), then ok. If not, we extend the api with c
On Mon, Aug 25, 2014 at 06:13:14PM +0200, Thomas Graf wrote:
> Can you setup a mailing list for the reports on openvswitch.org
> and set an environment variable in the github settings to contain
> the address of the list? [1]
Justin, can we create an "ovs-build" or "ovs-ci" mailing list?
_
On Tue, Aug 26, 2014 at 05:44:59PM +0200, Jiri Pirko wrote:
> Tue, Aug 26, 2014 at 05:29:10PM CEST, j...@mojatatu.com wrote:
> >On 08/26/14 11:22, Jiri Pirko wrote:
> >
> >>I do not think that really matters. Phase one is flows. After that we
> >>can focus on l2/l3. If we would be able to fit in in
> On Aug 26, 2014, at 8:48 AM, Ben Pfaff wrote:
>
>> On Mon, Aug 25, 2014 at 06:13:14PM +0200, Thomas Graf wrote:
>> Can you setup a mailing list for the reports on openvswitch.org
>> and set an environment variable in the github settings to contain
>> the address of the list? [1]
>
> Justin, c
---
datapath-windows/ovsext/Netlink.c | 16 +---
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/datapath-windows/ovsext/Netlink.c
b/datapath-windows/ovsext/Netlink.c
index 1c8d054..7b50221 100644
--- a/datapath-windows/ovsext/Netlink.c
+++ b/datapath-windows/ovsext/N
A typo crept in while respinning get_sock_pid_from_kernel() in the previous
patch. Fixing it now. Also, get_sock_pid_from_kernel() doesn't need an OUT
argument. Fixing that too.
---
lib/netlink-socket.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/netlink-s
On Tue, Aug 26, 2014 at 12:01:34PM +0200, Thomas Graf wrote:
> The branch is unused as size < sizeof dst->inline_values must
> always be true for inlined values. Hitting the branch would lead
> to corruption as inline_values is accessed out of bounds.
>
> Remove branch and add assertion.
>
> Cc:
On Tue, Aug 26, 2014 at 12:23:03PM +0200, Thomas Graf wrote:
> nodes is allocated through shash_sort() but never freed.
>
> Signed-off-by: Thomas Graf
Wow, that's a long-standing bug. It looks like in practice we only ever
hash objects used as identifiers in the OVSDB protocol, and it's not
lik
I didn't realize earlier while defining OvsDpInterfaceExt.h that
there are special values defined in netlink-protocol.h for nlmsg_type.
For Eg. NLMSG_ERROR is defined to be 2. In this patch, we update the
values of the family IDs to not clash with the special defines.
I'm using NLMSG_MIN_TYPE as a
On Tue, Aug 26, 2014 at 12:24:04PM +0200, Thomas Graf wrote:
> Causes the build script to fail if any command inside the
> script returns nonzero.
>
> Signed-off-by: Thomas Graf
We don't seem to have the file that this modifies. Did I miss a patch?
__
On 08/26/14 at 11:54am, Andy Gospodarek wrote:
> It is easy to *say* it could be added later, but connecting to software
> forwarding in the kernel outside of OVS (which is important to some)
> would take significant effort since this set only connects switch
> hardware to OVS.
Can you explain why
Hi,
Changes are fine.
Acked.
Regards,
Ankur
From: Nithin Raju
Sent: Tuesday, August 26, 2014 9:02 AM
To: dev@openvswitch.org; Ankur Sharma
Cc: Nithin Raju
Subject: [PATCH] datapath-windows: trivial formatting changes in Netlink.c
---
datapath-windows/ov
On 08/26/14 at 09:15am, Ben Pfaff wrote:
> On Tue, Aug 26, 2014 at 12:24:04PM +0200, Thomas Graf wrote:
> > Causes the build script to fail if any command inside the
> > script returns nonzero.
> >
> > Signed-off-by: Thomas Graf
>
> We don't seem to have the file that this modifies. Did I miss
Acked-by: Ankur Sharma
Regards,
Ankur
From: Ankur Sharma
Sent: Tuesday, August 26, 2014 9:21 AM
To: Nithin Raju; dev@openvswitch.org
Subject: RE: [PATCH] datapath-windows: trivial formatting changes in Netlink.c
Hi,
Changes are fine.
Acked.
Regards,
Ank
Thanks Ben!
From: Ben Pfaff [b...@nicira.com]
Sent: Friday, August 22, 2014 7:59 PM
To: Samuel Ghinet
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] Agenda for IRC neeting for 8/13 (Nithin Raju)
On Fri, Aug 22, 2014 at 04:27:01PM +, Samuel Ghinet wrote:
Current unconditional call may result in NULL being passed to
nl_msg_put_u32().
Cc: Andy Zhou
Signed-off-by: Thomas Graf
---
lib/odp-util.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 19d0627..8a96068 100644
--- a/lib/odp-util.c
+
Signed-off-by: Thomas Graf
---
lib/dpif-netdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 7401293..c7a1242 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -669,6 +669,8 @@ do_add_port(struct dp_netdev *dp, const char *devname,
co
Hello Nithin,
If there are great odds that only the VPORT multicast group will be used, I
think it would be best not to add the other multicast group ids.
If a need will arise in the future to add support for multicast groups for
datapath, packet, etc. it would be best done only then.
I think t
On Tue, 26 Aug 2014 15:23:24 +0300
Or Gerlitz wrote:
> just a nit, but if this approach/patch goes in, any reason not to change
> IFLA_PHYS_PORT_ID to IFLA_PHYS_ITEM_ID?
Userspace API
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mai
hi Alin/Sam,
These were the items we wanted to discuss:
1. Netlink implementation:
* status
* work has been spread out now, and issues have been created for each
individual task. There should be no confusion now. This was the plan all along,
BTW. We'll discuss anything that is not clear.
2.
hi Samuel,
Sure, I can trim the list to have only the OVS_WIN_NL_VPORT_MCGRP_ID defined
and nothing else. Pls. do note that we also need the OVS_WIN_NL_MCGRP_START_ID.
I'll respin the patch and send it out.
thanks,
Nithin
On Aug 26, 2014, at 9:55 AM, Samuel Ghinet
wrote:
> Hello Nithin,
>
>
Hi Saurabh,
That may not be a very easy answer, but, a better way would be, I believe:
headRoom -> encapBytes
copySize -> headersSize
copySize + headRoom -> (new variable) newMdlSize
It would also be very useful to have documentation comments on the parameters,
e.g.
/*
* headersSize:the numb
On Fri, Aug 22, 2014 at 04:31:11PM -0700, Justin Pettit wrote:
> On Fri, Aug 15, 2014 at 10:28 AM, Ben Pfaff wrote:
> > diff --git a/NEWS b/NEWS
> > index 1ea7bda..656f750 100644
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -17,6 +17,9 @@ Post-v2.3.0
> > * OpenFlow 1.5 (draft) Copy-Field action is n
Nithin,
Perhaps it will also be useful if you could show the relationship between
OVS_WIN_NL_VPORT_MCGRP_ID and OVS_WIN_NL_MCGRP_START_ID in OvsDpInterfaceExt.h.
Something like:
[CODE]
#define OVS_WIN_NL_MCGRP_START_ID100
#define OVS_WIN_NL_VPORT_MCGRP_ID (OVS_WIN_NL_MCGRP
Thx, applied to master and branch-2.3,
On Tue, Aug 26, 2014 at 12:26 AM, Justin Pettit wrote:
> Acked-by: Justin Pettit
>
> --Justin
>
>
> On August 25, 2014 at 10:42:24 PM, Alex Wang (al...@nicira.com) wrote:
> > Signed-off-by: Alex Wang
> > ---
> > vswitchd/vswitch.xml | 2 +-
> > 1 file chan
On Thu, Aug 21, 2014 at 05:42:02PM +1200, Joe Stringer wrote:
> Currently, when a revalidator thread first dumps a flow, it creates a
> 'udpif_key' object and caches a copy of a kernel flow key. This allows
> us to perform lookups in the classifier to attribute stats and validate
> the correctness
Is your mininet packaging targeted at jessie? That is, do you need
ovs-testcontroller in jessie or just in jessie+1? It makes a
difference because jessie will have Open vSwitch 2.3, but the
ovs-testcontroller change will only be in 2.4, and I do not want to
backport the change to 2.3 unless I rea
On Tue, Aug 26, 2014 at 06:25:13PM +0200, Thomas Graf wrote:
> On 08/26/14 at 09:15am, Ben Pfaff wrote:
> > On Tue, Aug 26, 2014 at 12:24:04PM +0200, Thomas Graf wrote:
> > > Causes the build script to fail if any command inside the
> > > script returns nonzero.
> > >
> > > Signed-off-by: Thomas G
On Tue, Aug 26, 2014 at 09:02:07AM -0700, Nithin Raju wrote:
> ---
Needs a Signed-off-by.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Aug 26, 2014 at 09:08:16AM -0700, Nithin Raju wrote:
> A typo crept in while respinning get_sock_pid_from_kernel() in the previous
> patch. Fixing it now. Also, get_sock_pid_from_kernel() doesn't need an OUT
> argument. Fixing that too.
Needs a Signed-off-by.
__
On Tue, Aug 26, 2014 at 09:15:07AM -0700, Nithin Raju wrote:
> I didn't realize earlier while defining OvsDpInterfaceExt.h that
> there are special values defined in netlink-protocol.h for nlmsg_type.
> For Eg. NLMSG_ERROR is defined to be 2. In this patch, we update the
> values of the family IDs
Thanks for the fix. Will push in a short while.
Acked-by: Andy Zhou
On Tue, Aug 26, 2014 at 9:34 AM, Thomas Graf wrote:
> Current unconditional call may result in NULL being passed to
> nl_msg_put_u32().
>
> Cc: Andy Zhou
> Signed-off-by: Thomas Graf
> ---
> lib/odp-util.c | 4 +++-
> 1 file
On Tue, Aug 26, 2014 at 06:36:08PM +0200, Thomas Graf wrote:
> Signed-off-by: Thomas Graf
> ---
> lib/dpif-netdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 7401293..c7a1242 100644
> --- a/lib/dpif-netdev.c
> +++ b/lib/dpif-netdev.c
Too late, I already got this one ;-)
On Tue, Aug 26, 2014 at 11:24:17AM -0700, Andy Zhou wrote:
> Thanks for the fix. Will push in a short while.
>
> Acked-by: Andy Zhou
>
> On Tue, Aug 26, 2014 at 9:34 AM, Thomas Graf wrote:
> > Current unconditional call may result in NULL being passed to
>
Git also told me so. :). Thanks.
On Tue, Aug 26, 2014 at 11:30 AM, Ben Pfaff wrote:
> Too late, I already got this one ;-)
>
> On Tue, Aug 26, 2014 at 11:24:17AM -0700, Andy Zhou wrote:
>> Thanks for the fix. Will push in a short while.
>>
>> Acked-by: Andy Zhou
>>
>> On Tue, Aug 26, 2014 at 9:3
On Tue, Aug 26, 2014 at 05:19:56PM +0100, Thomas Graf wrote:
> On 08/26/14 at 11:54am, Andy Gospodarek wrote:
> > It is easy to *say* it could be added later, but connecting to software
> > forwarding in the kernel outside of OVS (which is important to some)
> > would take significant effort since
On Mon, Aug 25, 2014 at 6:32 PM, Pravin Shelar wrote:
> On Mon, Aug 25, 2014 at 3:24 PM, Andy Zhou wrote:
>> If recirc action is the last action of a action list, the SKB triggers
>> the recirc will be freed twice. This patch fixes this bug.
>>
>> Reported-by: Justin Pettit
>> Signed-off-by: And
On Aug 26, 2014, at 3:01 AM, Thomas Graf wrote:
> The branch is unused as size < sizeof dst->inline_values must
> always be true for inlined values. Hitting the branch would lead
> to corruption as inline_values is accessed out of bounds.
>
Miniflows can also be dynamically allocated to have m
On Thu, Aug 21, 2014 at 06:18:59PM +0200, Jiri Pirko wrote:
> Dummy switch implementation using switchdev interface
>
[...]
> + if (!data || !data[IFLA_DYMMYSWPORT_PHYS_SWITCH_ID])
[...]
> + dsp->psid.id_len = nla_len(data[IFLA_DYMMYSWPORT_PHYS_SWITCH_ID]);
> + memcpy(dsp->psid.id, nla
Hi Samuel,
> -Original Message-
> From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
> Sent: Tuesday, August 26, 2014 10:40 AM
> To: Saurabh Shah
> Cc: dev@openvswitch.org
> Subject: RE: Cloning packets for "action: set field"
>
> Hi Saurabh,
>
> That may not be a very easy answ
>---
> datapath-windows/ovsext/Netlink.c | 16 +---
> 1 files changed, 9 insertions(+), 7 deletions(-)
Acked-by: Saurabh Shah
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
>A typo crept in while respinning get_sock_pid_from_kernel() in the
>previous
>patch. Fixing it now. Also, get_sock_pid_from_kernel() doesn't need an OUT
>argument. Fixing that too.
>---
> lib/netlink-socket.c | 10 +-
> 1 files changed, 5 insertions(+), 5 deletions(-)
Acked-by: Saurabh
Hi, I have a simple question.
When we use metadata as flow-rule,
Does all traffic forward ofproto to match it because there is no match
field in "struct sw_flow" in datapath?
Thanks,
Junguk
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/
On Tue, Aug 26, 2014 at 12:02:48PM -0700, Jarno Rajahalme wrote:
>
> On Aug 26, 2014, at 3:01 AM, Thomas Graf wrote:
>
> > The branch is unused as size < sizeof dst->inline_values must
> > always be true for inlined values. Hitting the branch would lead
> > to corruption as inline_values is acce
On Tue, Aug 26, 2014 at 11:45 AM, Andy Zhou wrote:
> On Mon, Aug 25, 2014 at 6:32 PM, Pravin Shelar wrote:
>> On Mon, Aug 25, 2014 at 3:24 PM, Andy Zhou wrote:
>>> If recirc action is the last action of a action list, the SKB triggers
>>> the recirc will be freed twice. This patch fixes this bug
On Tue, Aug 26, 2014 at 01:36:04PM -0600, Junguk Cho wrote:
> Hi, I have a simple question.
> When we use metadata as flow-rule,
> Does all traffic forward ofproto to match it because there is no match
> field in "struct sw_flow" in datapath?
No, metadata matching still allows for kernel forwardin
On Mon, Aug 25, 2014 at 09:45:08AM -0700, Nithin Raju wrote:
> While we work out whether nl_sock_join_mcgroup() will be the mechanism
> to support VPORT events, it is easy to add support for
> nl_lookup_genl_mcgroup() and make progress on the other commands.
>
> In this patch, we implement support
Oh, really?
Basically, what I understood is datapath keeps some tables based on "struct
sw_flow_key" and used it for evaluating if incoming packet is matched or
not.
Is it right or do I miss something?
If I miss something, can you forward me to metadata matching in datapath?
Thanks,
Junguk
2
Metadata is always 0 at the point that a packet enters the OpenFlow
pipeline, so there's no need for the datapath to match on it--it would
always be a match against 0.
On Tue, Aug 26, 2014 at 01:44:56PM -0600, Junguk Cho wrote:
> Oh, really?
>
> Basically, what I understood is datapath keeps some
On Tue, Aug 26, 2014 at 12:39 PM, Pravin Shelar wrote:
> On Tue, Aug 26, 2014 at 11:45 AM, Andy Zhou wrote:
>> On Mon, Aug 25, 2014 at 6:32 PM, Pravin Shelar wrote:
>>> On Mon, Aug 25, 2014 at 3:24 PM, Andy Zhou wrote:
If recirc action is the last action of a action list, the SKB triggers
Ok. I got it. Maybe I misunderstood the concept of metadata.
Metadata is passed between tables. It is not from packets.
One more question, if we used metadata, is metadata stored in "tun_in" in
"struct ovs_key_ipv4_tunnel"?
Which data structure keeps metadata information?
Thanks,
Junguk
2014-08
On Tue, Aug 26, 2014 at 01:57:32PM -0600, Junguk Cho wrote:
> One more question, if we used metadata, is metadata stored in "tun_in" in
> "struct ovs_key_ipv4_tunnel"?
No.
> Which data structure keeps metadata information?
struct flow's "metadata" member.
On Aug 26, 2014, at 1:01 AM, Thomas Graf wrote:
> On 08/25/14 at 08:10pm, Jesse Gross wrote:
>> On Mon, Aug 25, 2014 at 7:19 PM, Jarno Rajahalme
>> wrote:
>>> instead of:
>>>
>>> set(ipv4(src=35.8.2.41/0.0.0.0,dst=172.16.0.20/0.0.0.0,proto=6/0xff,tos=0x80/0,ttl=128/0,frag=no/0))
>>>
>>> we c
This patch includes the file renaming and accommodations needed for the file
renaming to build the forwarding extension for Hyper-V.
This patch is also a follow-up for the thread:
http://openvswitch.org/pipermail/dev/2014-August/044005.html
Signed-off-by: Samuel Ghinet
Co-authored-by: Alin Gabr
On Tue, Aug 26, 2014 at 9:19 AM, Thomas Graf wrote:
>
> Wait... I don't want to use OpenFlow to configure my laptop ;-)
+1
> We should leave the controller out of this discussion though. A
> controller is not required to run OVS at all. OpenStack Neutron
> is a very good example for that. There
"Let me think a little more about this. The functionality is meant to be
generic, so I don't like calling the variable 'encapBytes', since it becomes a
specific usage of the API."
I know, but I think "encapBytes" is the only usage we could ever have for the
project.
We could also use something
On 08/26/14 at 01:13pm, Alexei Starovoitov wrote:
> I think it's important distinction. In-kernel OVS is not OF.
> It's a networking function that has hard-coded packet parser,
> N-tuple match and programmable actions.
> There were times when HW vendors were using OF check-box
> to sell more chips,
On 08/26/14 at 11:28am, Ben Pfaff wrote:
> On Tue, Aug 26, 2014 at 06:36:08PM +0200, Thomas Graf wrote:
> > Signed-off-by: Thomas Graf
> > ---
> > lib/dpif-netdev.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> > index 7401293..c7a1242 1
But, it is in "struct flow" in lib/flow.h.
It is not from "struct sw_flow_key" in /datapath/flow.h.
I assume metadata is used in action in datapath.
Is it right?
Thanks,
Junguk
2014-08-26 14:00 GMT-06:00 Ben Pfaff :
> On Tue, Aug 26, 2014 at 01:57:32PM -0600, Junguk Cho wrote:
> > One more qu
On Tue, Aug 26, 2014 at 03:14:10PM -0600, Junguk Cho wrote:
> But, it is in "struct flow" in lib/flow.h.
> It is not from "struct sw_flow_key" in /datapath/flow.h.
>
> I assume metadata is used in action in datapath.
metadata is not a datapath concept. There is no need for it to be a
datapath co
What I thought is to generally use metadata as matching rule in datapath.
It is not just between tables.
Thanks,
Junguk
2014-08-26 15:15 GMT-06:00 Ben Pfaff :
> On Tue, Aug 26, 2014 at 03:14:10PM -0600, Junguk Cho wrote:
> > But, it is in "struct flow" in lib/flow.h.
> > It is not from "stru
On 27 August 2014 06:09, Ben Pfaff wrote:
> On Thu, Aug 21, 2014 at 05:42:02PM +1200, Joe Stringer wrote:
> > Currently, when a revalidator thread first dumps a flow, it creates a
> > 'udpif_key' object and caches a copy of a kernel flow key. This allows
> > us to perform lookups in the classifie
On 26/08/14 11:13, Ben Pfaff wrote:
> Is your mininet packaging targeted at jessie? That is, do you need
> ovs-testcontroller in jessie or just in jessie+1? It makes a
> difference because jessie will have Open vSwitch 2.3, but the
> ovs-testcontroller change will only be in 2.4, and I do not wan
Not sure if it was this patch, but after git pull:
tests/test-controller.8.in not found in: . .
make[2]: *** [manpages.mk] Error 1
make[2]: Failed to remake makefile `Makefile'.
make[2]: *** No rule to make target `tests/test-controller.c', needed by
`tests/test-controller.o’.
Jarno
On Aug 26
On 08/26/14 at 12:02pm, Jarno Rajahalme wrote:
> Miniflows can also be dynamically allocated to have more inline space than
> the default amount. classifier.c makes use of that, but it never calls
> miniflow_move (even indirectly) so you are not getting an assert fail. The
> motivation for right
You probably need to "autoreconf".
On Tue, Aug 26, 2014 at 03:17:32PM -0700, Jarno Rajahalme wrote:
> Not sure if it was this patch, but after git pull:
>
> tests/test-controller.8.in not found in: . .
> make[2]: *** [manpages.mk] Error 1
> make[2]: Failed to remake makefile `Makefile'.
> make[2]
If recirc action is the last action of a action list, the SKB triggers
the recirc will be freed twice. This patch fixes this bug.
Reported-by: Justin Pettit
Signed-off-by: Andy Zhou
---
datapath/actions.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff -
Miniflows can nowadays be dynamically allocated to different inline
sizes, as done by lib/classifier.c, but this had not been documented
at the struct miniflow definition.
Also, MINI_N_INLINE had a different value for 32-bit and 64-bit builds
due to a historical reason. Now we use 8 for both.
Fi
Although the check is present already, a missing !error branch
in the next condition prevents the error from being reported back.
Signed-off-by: Thomas Graf
---
ovsdb/execution.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ovsdb/execution.c b/ovsdb/execution.c
index 6314757..2be131d 10
On 08/26/14 at 03:42pm, Jarno Rajahalme wrote:
> Miniflows can nowadays be dynamically allocated to different inline
> sizes, as done by lib/classifier.c, but this had not been documented
> at the struct miniflow definition.
>
> Also, MINI_N_INLINE had a different value for 32-bit and 64-bit build
On Aug 26, 2014, at 3:29 PM, Thomas Graf wrote:
> On 08/26/14 at 12:02pm, Jarno Rajahalme wrote:
>> Miniflows can also be dynamically allocated to have more inline space than
>> the default amount. classifier.c makes use of that, but it never calls
>> miniflow_move (even indirectly) so you are
An error returned from ovsdb_row_from_json() currently results in
leaking of row.
Signed-off-by: Thomas Graf
---
ovsdb/execution.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ovsdb/execution.c b/ovsdb/execution.c
index 7a1db0c..6314757 100644
--- a/ovsdb/execution.c
+++ b/ovsdb/execution
On Tue, Aug 26, 2014 at 03:42:33PM -0700, Jarno Rajahalme wrote:
> Finally, use change the storage type of 'values_inline' to uint8_t, as
> uint64_t looks kind of wide for a boolean, even though we intend the
> bit be carved out from the uint64_t where 'map' resides.
It can't be type "bool"?
_
On Aug 26, 2014, at 3:53 PM, Ben Pfaff wrote:
> On Tue, Aug 26, 2014 at 03:42:33PM -0700, Jarno Rajahalme wrote:
>> Finally, use change the storage type of 'values_inline' to uint8_t, as
>> uint64_t looks kind of wide for a boolean, even though we intend the
>> bit be carved out from the uint64_
On Aug 26, 2014, at 3:44 PM, Thomas Graf wrote:
> On 08/26/14 at 03:42pm, Jarno Rajahalme wrote:
>> Miniflows can nowadays be dynamically allocated to different inline
>> sizes, as done by lib/classifier.c, but this had not been documented
>> at the struct miniflow definition.
>>
>> Also, MINI_
1 - 100 of 126 matches
Mail list logo
